DPDK patches and discussions
 help / color / mirror / Atom feed
* [Bug 1193] examples/vdpa closes port in non signal safe manner
@ 2023-03-20 17:02 bugzilla
  0 siblings, 0 replies; only message in thread
From: bugzilla @ 2023-03-20 17:02 UTC (permalink / raw)
  To: dev

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

https://bugs.dpdk.org/show_bug.cgi?id=1193

            Bug ID: 1193
           Summary: examples/vdpa closes port in non signal safe manner
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: examples
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

The vdpa sample application does:

signal(SIGINT, signal_handler);

Then signal_handler() doess
    vdpa_signal_quit() which calls close_vdpa()
    close_vdpa() calls rte_vhost_driver_detach_vdpa_device and unregister

These close and detach routines are not signal safe. It could cause a race
condition in vdpa driver if signal was received and processed by one thread
while another thread was in middle of interacting with host.

The correct way to handle this is to set a flag in the signal handler,
and exit the main processing loop; then cleanup.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #2: Type: text/html, Size: 3005 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-03-20 17:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 17:02 [Bug 1193] examples/vdpa closes port in non signal safe manner bugzilla

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).