DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Weiguo Li <liwg06@foxmail.com>, vsrivast@xilinx.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2] vdpa/sfc: fix null dereference
Date: Thu, 3 Feb 2022 14:49:18 +0100	[thread overview]
Message-ID: <c0252397-4246-066f-5547-284e85b6e7a3@redhat.com> (raw)
In-Reply-To: <tencent_C4CD294184ACCEE037C708ABC84E8C39CF06@qq.com>



On 1/29/22 19:07, Weiguo Li wrote:
> Fixes: b11961363b4a ("vdpa/sfc: support device configure and close")
> 
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
>   drivers/vdpa/sfc/sfc_vdpa_ops.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> index c4ce4474ef..b3d9b6cd56 100644
> --- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
> +++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> @@ -611,7 +611,7 @@ sfc_vdpa_dev_config(int vid)
>   
>   	ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
>   	if (ops_data == NULL) {
> -		sfc_vdpa_err(ops_data->dev_handle,
> +		SFC_VDPA_GENERIC_LOG(ERR,
>   			     "invalid vDPA device : %p, vid : %d",
>   			     vdpa_dev, vid);
>   		return -1;
> @@ -666,7 +666,7 @@ sfc_vdpa_dev_close(int vid)
>   
>   	ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
>   	if (ops_data == NULL) {
> -		sfc_vdpa_err(ops_data->dev_handle,
> +		SFC_VDPA_GENERIC_LOG(ERR,
>   			     "invalid vDPA device : %p, vid : %d",
>   			     vdpa_dev, vid);
>   		return -1;

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2022-02-03 13:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-29 18:07 Weiguo Li
2022-02-03 13:49 ` Maxime Coquelin [this message]
2022-02-10 15:12 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0252397-4246-066f-5547-284e85b6e7a3@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=liwg06@foxmail.com \
    --cc=vsrivast@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).