* [PATCH v2] vdpa/sfc: fix null dereference
@ 2022-01-29 18:07 Weiguo Li
2022-02-03 13:49 ` Maxime Coquelin
2022-02-10 15:12 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Weiguo Li @ 2022-01-29 18:07 UTC (permalink / raw)
To: vsrivast; +Cc: dev
Fixes: b11961363b4a ("vdpa/sfc: support device configure and close")
Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
drivers/vdpa/sfc/sfc_vdpa_ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
index c4ce4474ef..b3d9b6cd56 100644
--- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
+++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
@@ -611,7 +611,7 @@ sfc_vdpa_dev_config(int vid)
ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
if (ops_data == NULL) {
- sfc_vdpa_err(ops_data->dev_handle,
+ SFC_VDPA_GENERIC_LOG(ERR,
"invalid vDPA device : %p, vid : %d",
vdpa_dev, vid);
return -1;
@@ -666,7 +666,7 @@ sfc_vdpa_dev_close(int vid)
ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
if (ops_data == NULL) {
- sfc_vdpa_err(ops_data->dev_handle,
+ SFC_VDPA_GENERIC_LOG(ERR,
"invalid vDPA device : %p, vid : %d",
vdpa_dev, vid);
return -1;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] vdpa/sfc: fix null dereference
2022-01-29 18:07 [PATCH v2] vdpa/sfc: fix null dereference Weiguo Li
@ 2022-02-03 13:49 ` Maxime Coquelin
2022-02-10 15:12 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-02-03 13:49 UTC (permalink / raw)
To: Weiguo Li, vsrivast; +Cc: dev
On 1/29/22 19:07, Weiguo Li wrote:
> Fixes: b11961363b4a ("vdpa/sfc: support device configure and close")
>
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
> drivers/vdpa/sfc/sfc_vdpa_ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> index c4ce4474ef..b3d9b6cd56 100644
> --- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
> +++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> @@ -611,7 +611,7 @@ sfc_vdpa_dev_config(int vid)
>
> ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
> if (ops_data == NULL) {
> - sfc_vdpa_err(ops_data->dev_handle,
> + SFC_VDPA_GENERIC_LOG(ERR,
> "invalid vDPA device : %p, vid : %d",
> vdpa_dev, vid);
> return -1;
> @@ -666,7 +666,7 @@ sfc_vdpa_dev_close(int vid)
>
> ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
> if (ops_data == NULL) {
> - sfc_vdpa_err(ops_data->dev_handle,
> + SFC_VDPA_GENERIC_LOG(ERR,
> "invalid vDPA device : %p, vid : %d",
> vdpa_dev, vid);
> return -1;
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] vdpa/sfc: fix null dereference
2022-01-29 18:07 [PATCH v2] vdpa/sfc: fix null dereference Weiguo Li
2022-02-03 13:49 ` Maxime Coquelin
@ 2022-02-10 15:12 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-02-10 15:12 UTC (permalink / raw)
To: Weiguo Li, vsrivast; +Cc: dev
On 1/29/22 19:07, Weiguo Li wrote:
> Fixes: b11961363b4a ("vdpa/sfc: support device configure and close")
>
> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
> ---
> drivers/vdpa/sfc/sfc_vdpa_ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> index c4ce4474ef..b3d9b6cd56 100644
> --- a/drivers/vdpa/sfc/sfc_vdpa_ops.c
> +++ b/drivers/vdpa/sfc/sfc_vdpa_ops.c
> @@ -611,7 +611,7 @@ sfc_vdpa_dev_config(int vid)
>
> ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
> if (ops_data == NULL) {
> - sfc_vdpa_err(ops_data->dev_handle,
> + SFC_VDPA_GENERIC_LOG(ERR,
> "invalid vDPA device : %p, vid : %d",
> vdpa_dev, vid);
> return -1;
> @@ -666,7 +666,7 @@ sfc_vdpa_dev_close(int vid)
>
> ops_data = sfc_vdpa_get_data_by_dev(vdpa_dev);
> if (ops_data == NULL) {
> - sfc_vdpa_err(ops_data->dev_handle,
> + SFC_VDPA_GENERIC_LOG(ERR,
> "invalid vDPA device : %p, vid : %d",
> vdpa_dev, vid);
> return -1;
Applied to dpdk-next-virtio/main with fixing the title and cc'ing
stable.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-10 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29 18:07 [PATCH v2] vdpa/sfc: fix null dereference Weiguo Li
2022-02-03 13:49 ` Maxime Coquelin
2022-02-10 15:12 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).