DPDK patches and discussions
 help / color / mirror / Atom feed
From: fengchengwen <fengchengwen@huawei.com>
To: Vipin Varghese <vipin.varghese@amd.com>, <dev@dpdk.org>
Cc: <ferruh.yigit@amd.com>, <neerav.parikh@amd.com>
Subject: Re: [PATCH v3] app/dma-perf: add average latency per worker
Date: Tue, 12 Mar 2024 09:53:49 +0800	[thread overview]
Message-ID: <c70996f4-c18d-58ec-5c87-e3be13ce72de@huawei.com> (raw)
In-Reply-To: <20240308190646.1456-1-vipin.varghese@amd.com>

Acked-by: Chengwen Feng <fengchengwen@huawei.com>

On 2024/3/9 3:06, Vipin Varghese wrote:
> Modify the user information with total average latency per worker
> in both CSV and console logs.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
> 
> V3 Changes:
>  - update CSV_TOTAL_LINE_FMT to change Avg Cycles / op per worker
> 
> V2 Changes:
>  - keep one-digit precision is enough, suggested by Chengwen
> ---
>  app/test-dma-perf/benchmark.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test-dma-perf/benchmark.c b/app/test-dma-perf/benchmark.c
> index 9b1f58c78c..fca3ba24f7 100644
> --- a/app/test-dma-perf/benchmark.c
> +++ b/app/test-dma-perf/benchmark.c
> @@ -23,7 +23,7 @@
>  #define CSV_LINE_DMA_FMT "Scenario %u,%u,%s,%u,%u,%u,%u,%.2lf,%" PRIu64 ",%.3lf,%.3lf\n"
>  #define CSV_LINE_CPU_FMT "Scenario %u,%u,NA,NA,NA,%u,%u,%.2lf,%" PRIu64 ",%.3lf,%.3lf\n"
>  
> -#define CSV_TOTAL_LINE_FMT "Scenario %u Summary, , , , , ,%u,%.2lf,%u,%.3lf,%.3lf\n"
> +#define CSV_TOTAL_LINE_FMT "Scenario %u Summary, , , , , ,%u,%.2lf,%.1lf,%.3lf,%.3lf\n"
>  
>  struct worker_info {
>  	bool ready_flag;
> @@ -470,10 +470,11 @@ mem_copy_benchmark(struct test_configure *cfg, bool is_dma)
>  		bandwidth_total += bandwidth;
>  		avg_cycles_total += avg_cycles;
>  	}
> -	printf("\nTotal Bandwidth: %.3lf Gbps, Total MOps: %.3lf\n", bandwidth_total, mops_total);
> +	printf("\nAverage Cycles/op per worker: %.1lf, Total Bandwidth: %.3lf Gbps, Total MOps: %.3lf\n",
> +		(avg_cycles_total * (float) 1.0) / nb_workers, bandwidth_total, mops_total);
>  	snprintf(output_str[MAX_WORKER_NB], MAX_OUTPUT_STR_LEN, CSV_TOTAL_LINE_FMT,
>  			cfg->scenario_id, nr_buf, memory * nb_workers,
> -			avg_cycles_total / nb_workers, bandwidth_total, mops_total);
> +			(avg_cycles_total * (float) 1.0) / nb_workers, bandwidth_total, mops_total);
>  
>  out:
>  	/* free mbufs used in the test */
> 

  reply	other threads:[~2024-03-12  1:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 16:40 [PATCH] " Vipin Varghese
2024-02-23  9:45 ` fengchengwen
2024-02-27  9:50   ` Varghese, Vipin
2024-02-27 13:09     ` fengchengwen
2024-02-28  3:06       ` Varghese, Vipin
2024-02-28  3:05   ` Varghese, Vipin
2024-03-06 15:06 ` [PATCH v2] " Vipin Varghese
2024-03-08  1:15   ` fengchengwen
2024-03-08  2:39     ` Varghese, Vipin
2024-03-08 19:06   ` [PATCH v3] " Vipin Varghese
2024-03-12  1:53     ` fengchengwen [this message]
2024-03-18  2:36       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c70996f4-c18d-58ec-5c87-e3be13ce72de@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=neerav.parikh@amd.com \
    --cc=vipin.varghese@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).