From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 09/15] net/sfc: use new rte_eth_linkstatus functions
Date: Tue, 9 Jan 2018 22:29:24 +0300 [thread overview]
Message-ID: <cdc3e654-20a3-bb61-ab15-21012cd21e19@solarflare.com> (raw)
In-Reply-To: <20180109082732.4ba9115b@xeon-e3>
On 01/09/2018 07:27 PM, Stephen Hemminger wrote:
> On Tue, 9 Jan 2018 13:35:58 +0300
> Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>
>> On 01/08/2018 08:45 PM, Stephen Hemminger wrote:
>>> Use the new API (_rte_eth_linkstatus_set) to handle link status update.
>>>
>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>> ---
>>> drivers/net/sfc/sfc_ethdev.c | 27 +++++++--------------------
>>> drivers/net/sfc/sfc_ev.c | 23 ++++-------------------
>>> 2 files changed, 11 insertions(+), 39 deletions(-)
>>>
>>> diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
>>> index 2f5f86f84877..e0a12b32b1a3 100644
>>> --- a/drivers/net/sfc/sfc_ethdev.c
>>> +++ b/drivers/net/sfc/sfc_ethdev.c
>>> @@ -238,22 +238,12 @@ static int
>>> sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
>>> {
>>> struct sfc_adapter *sa = dev->data->dev_private;
>>> - struct rte_eth_link *dev_link = &dev->data->dev_link;
>>> - struct rte_eth_link old_link;
>>> struct rte_eth_link current_link;
>>>
>>> sfc_log_init(sa, "entry");
>>>
>>> -retry:
>>> - EFX_STATIC_ASSERT(sizeof(*dev_link) == sizeof(rte_atomic64_t));
>>> - *(int64_t *)&old_link = rte_atomic64_read((rte_atomic64_t *)dev_link);
>>> -
>>> if (sa->state != SFC_ADAPTER_STARTED) {
>>> sfc_port_link_mode_to_info(EFX_LINK_UNKNOWN, ¤t_link);
>>> - if (!rte_atomic64_cmpset((volatile uint64_t *)dev_link,
>>> - *(uint64_t *)&old_link,
>>> - *(uint64_t *)¤t_link))
>>> - goto retry;
>>> } else if (wait_to_complete) {
>>> efx_link_mode_t link_mode;
>>>
>>> @@ -261,21 +251,18 @@ sfc_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
>>> link_mode = EFX_LINK_UNKNOWN;
>>> sfc_port_link_mode_to_info(link_mode, ¤t_link);
>>>
>>> - if (!rte_atomic64_cmpset((volatile uint64_t *)dev_link,
>>> - *(uint64_t *)&old_link,
>>> - *(uint64_t *)¤t_link))
>>> - goto retry;
>>> } else {
>>> sfc_ev_mgmt_qpoll(sa);
>>> - *(int64_t *)¤t_link =
>>> - rte_atomic64_read((rte_atomic64_t *)dev_link);
>>> + _rte_eth_linkstatus_get(dev, ¤t_link);
>>> }
>>>
>>> - if (old_link.link_status != current_link.link_status)
>>> - sfc_info(sa, "Link status is %s",
>>> - current_link.link_status ? "UP" : "DOWN");
>>> + if (_rte_eth_linkstatus_set(dev, ¤t_link) == 0)
>>> + return 0;
>>> +
>>> + sfc_info(sa, "Link status is %s",
>>> + current_link.link_status ? "UP" : "DOWN");
>>>
>>> - return old_link.link_status == current_link.link_status ? 0 : -1;
>>> + return -1;
>>> }
>>>
>>> static void
>>> diff --git a/drivers/net/sfc/sfc_ev.c b/drivers/net/sfc/sfc_ev.c
>>> index a16dc27b380e..3e96536a9d60 100644
>>> --- a/drivers/net/sfc/sfc_ev.c
>>> +++ b/drivers/net/sfc/sfc_ev.c
>>> @@ -404,29 +404,14 @@ sfc_ev_link_change(void *arg, efx_link_mode_t link_mode)
>>> {
>>> struct sfc_evq *evq = arg;
>>> struct sfc_adapter *sa = evq->sa;
>>> - struct rte_eth_link *dev_link = &sa->eth_dev->data->dev_link;
>>> struct rte_eth_link new_link;
>>> - uint64_t new_link_u64;
>>> - uint64_t old_link_u64;
>>> -
>>> - EFX_STATIC_ASSERT(sizeof(*dev_link) == sizeof(rte_atomic64_t));
>>>
>>> sfc_port_link_mode_to_info(link_mode, &new_link);
>>> + if (_rte_eth_linkstatus_set(sa->eth_dev, &new_link) == 0)
>>> + return B_FALSE;
>>>
>>> - new_link_u64 = *(uint64_t *)&new_link;
>>> - do {
>>> - old_link_u64 = rte_atomic64_read((rte_atomic64_t *)dev_link);
>>> - if (old_link_u64 == new_link_u64)
>>> - break;
>>> -
>>> - if (rte_atomic64_cmpset((volatile uint64_t *)dev_link,
>>> - old_link_u64, new_link_u64)) {
>>> - evq->sa->port.lsc_seq++;
>>> - break;
>>> - }
>>> - } while (B_TRUE);
>>> -
>>> - return B_FALSE;
>>> + evq->sa->port.lsc_seq++;
>>> + return B_TRUE;
>> It still returns B_TRUE, but should return B_FALSE as before.
>> Also before the patch lsc_seq is incremented in the case of any
>> changes in link status, but now in the case of up/down change only.
> The old code looked broken and did not match the comments.
> It always returned B_FALSE independent of whether link status changed
> or not.
Which comments does it not match?
Yes, because it is internal callback and return value is unrelated to link
status changes. Return value affects further events processing.
If B_TRUE is returned, it means something bad has happened and
events processing should be aborted.
next prev parent reply other threads:[~2018-01-09 19:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 17:44 [dpdk-dev] [PATCH v3 00/15] common ethdev linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-11 17:01 ` Ferruh Yigit
2018-01-25 23:24 ` Stephen Hemminger
2018-03-08 22:12 ` Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-09 10:30 ` Andrew Rybchenko
2018-01-09 16:29 ` Stephen Hemminger
2018-01-11 17:01 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-11 17:02 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-11 17:02 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 05/15] net/dpaa2: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 09/15] net/sfc: use new " Stephen Hemminger
2018-01-09 10:35 ` Andrew Rybchenko
2018-01-09 16:27 ` Stephen Hemminger
2018-01-09 19:29 ` Andrew Rybchenko [this message]
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 10/15] net/i40e: use " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 11/15] net/liquidio: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 12/15] net/thunderx: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 13/15] net/szedata: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 15/15] net/enic: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 01/15] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 02/15] ethdev: add linkstatus get/set helper functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 03/15] net/virtio: use eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 04/15] net/vmxnet3: use rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 05/15] net/dpaa2: " Ferruh Yigit
2018-01-16 9:44 ` Shreyansh Jain
2018-01-16 9:57 ` Shreyansh Jain
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 06/15] net/nfp: use rte_eth_linkstatus functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 07/15] net/e1000: use rte_eth_linkstatus helpers Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 08/15] net/ixgbe: use rte_eth_linkstatus functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 09/15] net/sfc: use new " Ferruh Yigit
2018-01-12 7:45 ` Andrew Rybchenko
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 10/15] net/i40e: use " Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 11/15] net/liquidio: use _rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 12/15] net/thunderx: " Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 13/15] net/szedata: " Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 14/15] net/octeontx: use rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 15/15] net/enic: use _rte_eth_linkstatus_set Ferruh Yigit
2018-01-12 14:05 ` Hyong Youb Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdc3e654-20a3-bb61-ab15-21012cd21e19@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).