DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Huang, ZhiminX" <zhiminx.huang@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, AlvinX" <alvinx.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF
Date: Fri, 19 Feb 2021 09:06:27 +0000	[thread overview]
Message-ID: <d389a8557c82466e8375ce6db7cc3548@intel.com> (raw)
In-Reply-To: <20210219051346.12992-1-alvinx.zhang@intel.com>

Tested-by: Huang, ZhiminX <zhiminx.huang@intel.com>

Regards,
HuangZhiMin


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Alvin Zhang
> Sent: Friday, February 19, 2021 1:14 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF
> 
> The macro flag DEV_RX_OFFLOAD_VLAN_FILTER is used to enable/disable
> Rx VLAN filter, but not Tx VLAN filter. Therefore, Tx VLAN filter should not
> be enabled/disabled in function ice_vsi_config_vlan_filter called after
> checking DEV_RX_OFFLOAD_VLAN_FILTER flag.
> 
> In addition, the kernel driver doesn't enable/disable the TX VLAN filter in
> the similar function ice_cfg_vlan_pruning.
> 
> This patch removes the setting about the TX VLAN filter in function
> ice_vsi_config_vlan_filter.
> 
> Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index dfd99ac..8999d44 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4011,20 +4011,16 @@ static int ice_macaddr_set(struct
> rte_eth_dev *dev,  {
>  	struct ice_hw *hw = ICE_VSI_TO_HW(vsi);
>  	struct ice_vsi_ctx ctxt;
> -	uint8_t sec_flags, sw_flags2;
> +	uint8_t sw_flags2;
>  	int ret = 0;
> 
> -	sec_flags = ICE_AQ_VSI_SEC_TX_VLAN_PRUNE_ENA <<
> -		    ICE_AQ_VSI_SEC_TX_PRUNE_ENA_S;
>  	sw_flags2 = ICE_AQ_VSI_SW_FLAG_RX_VLAN_PRUNE_ENA;
> 
> -	if (on) {
> -		vsi->info.sec_flags |= sec_flags;
> +	if (on)
>  		vsi->info.sw_flags2 |= sw_flags2;
> -	} else {
> -		vsi->info.sec_flags &= ~sec_flags;
> +	else
>  		vsi->info.sw_flags2 &= ~sw_flags2;
> -	}
> +
>  	vsi->info.sw_id = hw->port_info->sw_id;
>  	(void)rte_memcpy(&ctxt.info, &vsi->info, sizeof(vsi->info));
>  	ctxt.info.valid_sections =
> --
> 1.8.3.1


  reply	other threads:[~2021-02-19  9:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  5:07 Alvin Zhang
2021-02-19  5:13 ` Alvin Zhang
2021-02-19  9:06   ` Huang, ZhiminX [this message]
2021-02-22 12:39     ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d389a8557c82466e8375ce6db7cc3548@intel.com \
    --to=zhiminx.huang@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).