From: "Doherty, Declan" <declan.doherty@intel.com>
To: Ciara Power <ciara.power@intel.com>, dev@dpdk.org
Cc: akhil.goyal@nxp.com
Subject: Re: [dpdk-dev] [PATCH 2/4] test/cryptodev: improve csv output for perf tests
Date: Mon, 11 Jan 2021 15:43:23 +0000 [thread overview]
Message-ID: <d74ba43d-1746-3ea7-0265-940770b7dad6@intel.com> (raw)
In-Reply-To: <20201211173114.1924772-3-ciara.power@intel.com>
On 11/12/2020 5:31 PM, Ciara Power wrote:
> The csv outputs for performance tests were not easily consumed, due to
> unnecessary whitespaces and capitals. The delimiter is modified to now
> be "," instead of ";" which was present in some cases. Some unnecessary
> values were also removed from the output.
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> app/test-crypto-perf/cperf_test_latency.c | 13 +++++--------
> app/test-crypto-perf/cperf_test_throughput.c | 12 ++++++------
> 2 files changed, 11 insertions(+), 14 deletions(-)
>
> diff --git a/app/test-crypto-perf/cperf_test_latency.c b/app/test-crypto-perf/cperf_test_latency.c
> index c2590a4dcf..f3c09b8c1c 100644
> --- a/app/test-crypto-perf/cperf_test_latency.c
> +++ b/app/test-crypto-perf/cperf_test_latency.c
> @@ -309,18 +309,15 @@ cperf_latency_test_runner(void *arg)
>
> if (ctx->options->csv) {
> if (rte_atomic16_test_and_set(&display_once))
> - printf("\n# lcore, Buffer Size, Burst Size, Pakt Seq #, "
> - "cycles, time (us)");
> + printf("\n#buffer_size(b),burst_size,time(us)");
>
> for (i = 0; i < ctx->options->total_ops; i++) {
>
> - printf("\n%u;%u;%u;%"PRIu64";%"PRIu64";%.3f",
> - ctx->lcore_id, ctx->options->test_buffer_size,
> - test_burst_size, i + 1,
> - ctx->res[i].tsc_end - ctx->res[i].tsc_start,
> + printf("\n%u,%u,%.3f",
> + ctx->options->test_buffer_size,
> + test_burst_size,
> tunit * (double) (ctx->res[i].tsc_end
> - - ctx->res[i].tsc_start)
> - / tsc_hz);
> + - ctx->res[i].tsc_start) / tsc_hz);
>
> }
> } else {
> diff --git a/app/test-crypto-perf/cperf_test_throughput.c b/app/test-crypto-perf/cperf_test_throughput.c
> index f30f7d5c2c..a841a890b9 100644
> --- a/app/test-crypto-perf/cperf_test_throughput.c
> +++ b/app/test-crypto-perf/cperf_test_throughput.c
> @@ -294,13 +294,13 @@ cperf_throughput_test_runner(void *test_ctx)
> cycles_per_packet);
> } else {
> if (rte_atomic16_test_and_set(&display_once))
> - printf("#lcore id,Buffer Size(B),"
> - "Burst Size,Enqueued,Dequeued,Failed Enq,"
> - "Failed Deq,Ops(Millions),Throughput(Gbps),"
> - "Cycles/Buf\n\n");
> + printf("#lcore_id,buffer_size(b),"
> + "burst_size,enqueued,dequeued,failed_enq,"
> + "failed_deq,ops(millions),throughput(gbps),"
> + "cycles_per_buf\n\n");
>
> - printf("%u;%u;%u;%"PRIu64";%"PRIu64";%"PRIu64";%"PRIu64";"
> - "%.3f;%.3f;%.3f\n",
> + printf("%u,%u,%u,%"PRIu64",%"PRIu64",%"PRIu64",%"PRIu64","
> + "%.3f,%.3f,%.3f\n",
> ctx->lcore_id,
> ctx->options->test_buffer_size,
> test_burst_size,
>
I would suggest limiting the changes here to just fixing the delimiter
here to being comma's instead of semi-colon's, that way it should be
possible to make the python script support only versions of the output
which wouldn't be possible if we change column names.
next prev parent reply other threads:[~2021-01-11 15:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 17:31 [dpdk-dev] [PATCH 0/4] add crypto perf test graphing script Ciara Power
2020-12-11 17:31 ` [dpdk-dev] [PATCH 1/4] test/cryptodev: fix latency test csv output Ciara Power
2020-12-11 17:31 ` [dpdk-dev] [PATCH 2/4] test/cryptodev: improve csv output for perf tests Ciara Power
2021-01-11 15:43 ` Doherty, Declan [this message]
2020-12-11 17:31 ` [dpdk-dev] [PATCH 3/4] usertools: add script to graph crypto perf results Ciara Power
2020-12-11 19:35 ` Stephen Hemminger
2021-01-11 16:03 ` Doherty, Declan
2020-12-11 17:31 ` [dpdk-dev] [PATCH 4/4] maintainers: update crypto perf app maintainers Ciara Power
2021-01-14 10:41 ` [dpdk-dev] [PATCH v2 0/4] add crypto perf test graphing script Ciara Power
2021-01-14 10:41 ` [dpdk-dev] [PATCH v2 1/4] test/cryptodev: fix latency test csv output Ciara Power
2021-01-15 9:42 ` Dybkowski, AdamX
2021-01-14 10:41 ` [dpdk-dev] [PATCH v2 2/4] test/cryptodev: fix csv output format Ciara Power
2021-01-15 9:42 ` Dybkowski, AdamX
2021-01-14 10:41 ` [dpdk-dev] [PATCH v2 3/4] usertools: add script to graph crypto perf results Ciara Power
2021-01-15 9:43 ` Dybkowski, AdamX
2021-01-14 10:41 ` [dpdk-dev] [PATCH v2 4/4] maintainers: update crypto perf app maintainers Ciara Power
2021-01-15 10:13 ` Dybkowski, AdamX
2021-01-15 8:31 ` [dpdk-dev] [PATCH v2 0/4] add crypto perf test graphing script Doherty, Declan
2021-01-15 15:54 ` Akhil Goyal
2021-01-19 17:31 ` Thomas Monjalon
2021-01-19 17:34 ` Akhil Goyal
2021-01-20 17:29 ` [dpdk-dev] [PATCH v3 " Ciara Power
2021-01-20 17:29 ` [dpdk-dev] [PATCH v3 1/4] test/cryptodev: fix latency test csv output Ciara Power
2021-01-20 17:29 ` [dpdk-dev] [PATCH v3 2/4] test/cryptodev: fix csv output format Ciara Power
2021-01-20 17:29 ` [dpdk-dev] [PATCH v3 3/4] test/cryptodev: add script to graph perf results Ciara Power
2021-01-20 17:29 ` [dpdk-dev] [PATCH v3 4/4] maintainers: update crypto perf app maintainers Ciara Power
2021-01-25 18:28 ` [dpdk-dev] [PATCH v3 0/4] add crypto perf test graphing script Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d74ba43d-1746-3ea7-0265-940770b7dad6@intel.com \
--to=declan.doherty@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).