From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wenjun Wu <wenjun1.wu@intel.com>, <dev@dpdk.org>,
<qiming.yang@intel.com>, <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/2] net/ice: remove redundant default RSS field for IP fragment packets
Date: Fri, 13 Aug 2021 13:02:21 +0100 [thread overview]
Message-ID: <e2a413ba-a4bf-1cc7-575e-5649393cde7f@intel.com> (raw)
In-Reply-To: <20210802083659.1003658-1-wenjun1.wu@intel.com>
On 8/2/2021 9:36 AM, Wenjun Wu wrote:
> This patch removes redundant default RSS field for IP fragment packets,
> only src MAC address and dst MAC address are needed.
>
Same comments with first patch.
Impact is not clear, and this patch seems a little different from first path,
this clears one flag from 'cfg.hash_flds', why and if this is not causing any
impact (that is what I understand from description) can you explain in the
commit log why it doesn't change the behavior of the code?
Also again long patch title.
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index a4cd39c954..64ee569525 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -2975,7 +2975,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
>
> if (rss_hf & ETH_RSS_FRAG_IPV4) {
> cfg.addl_hdrs = ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_FRAG;
> - cfg.hash_flds = ICE_FLOW_HASH_IPV4 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_ID);
> + cfg.hash_flds = ICE_FLOW_HASH_IPV4;
> ret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg);
> if (ret)
> PMD_DRV_LOG(ERR, "%s IPV4_FRAG rss flow fail %d",
> @@ -2984,7 +2984,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf)
>
> if (rss_hf & ETH_RSS_FRAG_IPV6) {
> cfg.addl_hdrs = ICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_FRAG;
> - cfg.hash_flds = ICE_FLOW_HASH_IPV6 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_ID);
> + cfg.hash_flds = ICE_FLOW_HASH_IPV6;
> ret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg);
> if (ret)
> PMD_DRV_LOG(ERR, "%s IPV6_FRAG rss flow fail %d",
>
next prev parent reply other threads:[~2021-08-13 12:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 8:36 Wenjun Wu
2021-08-13 12:02 ` Ferruh Yigit [this message]
2021-08-17 6:53 ` [dpdk-dev] [PATCH v2 2/2] net/ice: fix " Wenjun Wu
2021-08-17 8:45 ` [dpdk-dev] [PATCH v3 " Wenjun Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2a413ba-a4bf-1cc7-575e-5649393cde7f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).