DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: "Van Haaren\, Harry" <harry.van.haaren@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "Amber\,
	Kumar" <kumar.amber@intel.com>, "dev\@dpdk.org" <dev@dpdk.org>,
	"Wang\, Yipeng1" <yipeng1.wang@intel.com>, "Yigit\,
	Ferruh" <ferruh.yigit@intel.com>, "Thakur\,
	Sham Singh" <sham.singh.thakur@intel.com>,
	David Marchand <dmarchan@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query key id
Date: Tue, 26 Nov 2019 10:58:36 -0500	[thread overview]
Message-ID: <f7ta78ik4sz.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <MN2PR11MB44474DD92460B094C4EF1C98D7450@MN2PR11MB4447.namprd11.prod.outlook.com> (Van Haaren's message of "Tue, 26 Nov 2019 13:19:02 +0000")

"Van Haaren, Harry" <harry.van.haaren@intel.com> writes:

> Hi Aaron,
>
>> -----Original Message-----
>> From: Aaron Conole <aconole@redhat.com>
>> Sent: Monday, November 25, 2019 10:54 PM
>> To: Thomas Monjalon <thomas@monjalon.net>
>> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Amber, Kumar
>> <kumar.amber@intel.com>; dev@dpdk.org; Wang, Yipeng1
>> <yipeng1.wang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Thakur,
>> Sham Singh <sham.singh.thakur@intel.com>; David Marchand
>> <dmarchan@redhat.com>
>> Subject: Re: [dpdk-dev] [PATCH v3] hash: added a new API to hash to query
>> key id
>> 
>> Aaron Conole <aconole@redhat.com> writes:
>> 
>> > Thomas Monjalon <thomas@monjalon.net> writes:
>> >
>> >>> From: Aaron Conole <aconole@redhat.com>
>> >>> > -	if (!service_valid(id))
>> >>> > +	if (id >= RTE_SERVICE_NUM_MAX || !service_valid(id))
>> >>
>> >> Why not adding this check in service_valid()?
>> >
>> > I think the best fix is to use SERVICE_VALID_GET_OR_ERR_RET() in these
>> > places.  For this, I at least want to try and show that there aren't any
>> > further errors.  And my test loop has been running for a while now
>> > without any more errors or segfaults, so I guess it's okay to build a
>> > proper patch.
>> 
>> This popped up:
>> 
>> EAL: Test assert service_lcore_en_dis_able line 487 failed: Ex-service core
>> function call had no effect.
>> 
>> So I'll spend some time in this area, it seems.
>
>
> The below diff makes it 100% reproducible here, failing every time.
>
> It seems like the main thread is returning, before the service thread has returned.
>
> The rte_eal_mp_wait_lcore() call seems to not wait on the service-core, which allows
> the main thread to read the "service_remote_launch_flag" value as 0 (before the service-thread writes it to 1).
>
> Adding the delay between the service launch and service write being performed makes this issue much much more likely to occur - so the above description I have confidence in.
>
> What I'm not clear on (yet) is why the eal_mp_wait_lcore() isn't waiting...

As I wrote in the other thread, it's because eal_mp_wait_lcore won't
look at lcores with ROLE_SERVICE.

> -H

I've been running something similar to the suggested patch for 24
minutes now with no failure.  I've also removed the eal_mp_wait_lcore()
call in other areas throughout the test and switched to individual core
waiting "just in case."  I don't think it's the right fix, though.


  parent reply	other threads:[~2019-11-26 15:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 14:59 [dpdk-dev] [PATCH v2] " Kumar Amber
2019-11-22 18:21 ` [dpdk-dev] [PATCH v3] " Kumar Amber
2019-11-25 11:08   ` Kumar Amber
2019-11-25 15:50     ` Amber, Kumar
2019-11-25 16:01       ` Aaron Conole
2019-11-25 16:58       ` Aaron Conole
2019-11-25 17:16         ` Van Haaren, Harry
2019-11-25 17:54           ` Thomas Monjalon
2019-11-25 18:10             ` Aaron Conole
2019-11-25 22:53               ` Aaron Conole
2019-11-26 13:19                 ` Van Haaren, Harry
2019-11-26 13:29                   ` Van Haaren, Harry
2019-11-26 13:57                     ` Aaron Conole
2019-11-27 11:37                       ` Van Haaren, Harry
2019-11-26 15:58                   ` Aaron Conole [this message]
2019-11-25 19:41     ` Wang, Yipeng1
2019-11-26  2:39   ` [dpdk-dev] [PATCH v4] " Kumar Amber
2019-11-27  1:59     ` Wang, Yipeng1
2020-01-20  0:16       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7ta78ik4sz.fsf@dhcp-25.97.bos.redhat.com \
    --to=aconole@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmarchan@redhat.com \
    --cc=ferruh.yigit@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=kumar.amber@intel.com \
    --cc=sham.singh.thakur@intel.com \
    --cc=thomas@monjalon.net \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).