DPDK patches and discussions
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: John Romein <romein@astron.nl>
Cc: dev@dpdk.org, Elena Agostini <eagostini@nvidia.com>
Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include
Date: Wed, 13 Sep 2023 07:12:56 -0400	[thread overview]
Message-ID: <f7tcyym2uo7.fsf@redhat.com> (raw)
In-Reply-To: <8e6f8751-9475-cce5-b827-646f772f64a6@astron.nl> (John Romein's message of "Tue, 12 Sep 2023 19:08:43 +0200")

John Romein <romein@astron.nl> writes:

> getenv needs stdlib.h to be included.
>
> Bugzilla ID: 1133
>
> Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy")
> Signed-off-by: John Romein <romein@astron.nl>
> ---

Hi John,

Thanks so much for the contribution.  It looks like the patch got
corrupted by something.  Please check your mail client settings.  I'll
point out some of the specific characters here.  You may also need to
switch to using a gmail server or some other mail service to email the
patch.

-Aaron

>   drivers/gpu/cuda/gdrcopy.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/cuda/gdrcopy.c b/drivers/gpu/cuda/gdrcopy.c
> index 322a5dbeb2..f19ad396f1 100644
> --- a/drivers/gpu/cuda/gdrcopy.c
> +++ b/drivers/gpu/cuda/gdrcopy.c
> @@ -2,6 +2,8 @@
>    * Copyright (c) 2022 NVIDIA Corporation & Affiliates

   ^  This character looks incorrect
>    */

   ^ Same here
   
>
> +#include <stdlib.h>
> +
>   #include "common.h"

   ^ Same here

>   #ifdef DRIVERS_GPU_CUDA_GDRCOPY_H

   ^ Same here


  reply	other threads:[~2023-09-13 11:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 17:08 John Romein
2023-09-13 11:12 ` Aaron Conole [this message]
2023-09-26 18:23 Aaron Conole
2023-09-29 14:58 ` David Marchand
2023-10-05 12:43   ` Elena Agostini
2023-10-06  8:09     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tcyym2uo7.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=dev@dpdk.org \
    --cc=eagostini@nvidia.com \
    --cc=romein@astron.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).