From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: mingli.yu@windriver.com, dev@dpdk.org
Cc: Jiri Slaby <jslaby@suse.cz>,
"Min Hu (Connor)" <humin29@huawei.com>,
Ferruh Yigit <ferruh.yigit@xilinx.com>
Subject: Re: [PATCH] kni_net.c: use netif_rx() instead of netif_rx_ni()
Date: Tue, 31 May 2022 19:47:09 +0300 [thread overview]
Message-ID: <fb9de9f9-4177-6b1e-5d82-dbb27ddb4890@oktetlabs.ru> (raw)
In-Reply-To: <20220511112334.3233433-1-mingli.yu@windriver.com>
On 5/11/22 14:23, mingli.yu@windriver.com wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
>
> The netif_rx_ni is removed in below commit after kernel upgraded
> to 5.18, so change accordingly to fix the gap.
> 2655926aea9b net: Remove netif_rx_any_context() and netif_rx_ni().
>
> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
> kernel/linux/kni/kni_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
> index 7fcfa106cb..58e8fe5af6 100644
> --- a/kernel/linux/kni/kni_net.c
> +++ b/kernel/linux/kni/kni_net.c
> @@ -368,7 +368,7 @@ kni_net_rx_normal(struct kni_dev *kni)
> skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> /* Call netif interface */
> - netif_rx_ni(skb);
> + netif_rx(skb);
>
> /* Update statistics */
> kni->stats.rx_bytes += len;
There are two more patches [1] and [2] in the patchwork on the topic and
it looks like the latest is the best one. Do you have any comments on
[2]?
[1]
https://patches.dpdk.org/project/dpdk/patch/20220521070642.35413-1-humin29@huawei.com/
[2]https://patches.dpdk.org/project/dpdk/patch/20220525102641.20982-1-jslaby@suse.cz/
prev parent reply other threads:[~2022-05-31 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 11:23 mingli.yu
2022-05-31 16:47 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb9de9f9-4177-6b1e-5d82-dbb27ddb4890@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=humin29@huawei.com \
--cc=jslaby@suse.cz \
--cc=mingli.yu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).