DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Xia, Chenbo" <chenbo.xia@intel.com>,
	"amorenoz@redhat.com" <amorenoz@redhat.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"michaelba@nvidia.com" <michaelba@nvidia.com>,
	"viacheslavo@nvidia.com" <viacheslavo@nvidia.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>,
	"yvugenfi@redhat.com" <yvugenfi@redhat.com>,
	"ybendito@redhat.com" <ybendito@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: add missing flow types in port info
Date: Wed, 29 Sep 2021 09:27:06 +0200	[thread overview]
Message-ID: <fd80c990-3183-e0cd-91d2-39204bea5b97@redhat.com> (raw)
In-Reply-To: <DM4PR11MB553455EC6BD42E0C6FCDEA1C99A29@DM4PR11MB5534.namprd11.prod.outlook.com>



On 9/22/21 13:31, Li, Xiaoyun wrote:
> Hi
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Wednesday, September 22, 2021 17:58
>> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
>> amorenoz@redhat.com; david.marchand@redhat.com;
>> andrew.rybchenko@oktetlabs.ru; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> michaelba@nvidia.com; viacheslavo@nvidia.com; Li, Xiaoyun
>> <xiaoyun.li@intel.com>
>> Cc: stable@dpdk.org; nelio.laranjeiro@6wind.com; yvugenfi@redhat.com;
>> ybendito@redhat.com; Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH v2 5/5] app/testpmd: add missing flow types in port info
>>
>> This patch adds missing IPv6-Ex flow types to port info command.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>>   app/test-pmd/config.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
>> 9a4a0c232b..3550e0a18f 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -4528,6 +4528,9 @@ flowtype_to_str(uint16_t flow_type)
>>   		{"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP},
>>   		{"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER},
>>   		{"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD},
>> +		{"ipv6-ex", RTE_ETH_FLOW_IPV6_EX},
>> +		{"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX},
>> +		{"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX},
>>   		{"port", RTE_ETH_FLOW_PORT},
>>   		{"vxlan", RTE_ETH_FLOW_VXLAN},
>>   		{"geneve", RTE_ETH_FLOW_GENEVE},
> 
> You add missing ipv6 ex why not adding RTE_ETH_FLOW_GTPU too. It's also missing.
> 
> Also, flowtype_to_str is added but what about str2flowtype() in cmdline.c?

Both suggestions are added to the next revision.

Thanks,
Maxime

>> --
>> 2.31.1
> 


      reply	other threads:[~2021-09-29  7:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22  9:57 [dpdk-dev] [PATCH v2 0/5] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-22  9:57 ` [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support Maxime Coquelin
2021-09-22 11:20   ` Andrew Rybchenko
2021-09-22 12:28     ` Maxime Coquelin
2021-09-23  7:35   ` Xia, Chenbo
2021-09-29  9:02     ` Maxime Coquelin
2021-09-22  9:57 ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: fix RSS key length Maxime Coquelin
2021-09-22 11:25   ` Li, Xiaoyun
2021-09-23  7:52   ` Xia, Chenbo
2021-09-22  9:57 ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: fix RSS type display Maxime Coquelin
2021-09-22 12:01   ` Li, Xiaoyun
2021-09-23  7:59   ` Xia, Chenbo
2021-09-22  9:57 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: fix RSS RETA update Maxime Coquelin
2021-09-22  9:57 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: add missing flow types in port info Maxime Coquelin
2021-09-22 11:31   ` Li, Xiaoyun
2021-09-29  7:27     ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd80c990-3183-e0cd-91d2-39204bea5b97@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=michaelba@nvidia.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    --cc=ybendito@redhat.com \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).