test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to forbid misc packets
@ 2019-07-02  7:33 zhang,yan
  0 siblings, 0 replies; 4+ messages in thread
From: zhang,yan @ 2019-07-02  7:33 UTC (permalink / raw)
  To: dts; +Cc: zhang,yan

1. disable promisc mode to forbid misc packets.
2. Add judge NIC type, make test_two_vms_add_multi_exact_mac_on_vf applies to fortpark, sagevill, and sagepond NIC.

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_sriov_kvm.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index eadeb05..3518f8f 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -627,12 +627,14 @@ class TestSriovKvm(TestCase):
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
+        self.vm0_testpmd.execute_cmd('set promisc all off')
         self.vm0_testpmd.execute_cmd('start')
 
         self.vm1_dut_ports = self.vm_dut_1.get_ports('any')
         self.vm1_testpmd = PmdOutput(self.vm_dut_1)
         self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm1_testpmd.execute_cmd('set fwd mac')
+        self.vm1_testpmd.execute_cmd('set promisc all off')
         self.vm1_testpmd.execute_cmd('start')
 
         self.setup_2vm_prerequisite_flag = 1
@@ -676,6 +678,7 @@ class TestSriovKvm(TestCase):
         self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
         vf1_mac = self.vm1_testpmd.get_port_mac(port_id_0)
         self.vm1_testpmd.execute_cmd('set fwd mac')
+        self.vm1_testpmd.execute_cmd("set promisc all off")
         self.vm1_testpmd.execute_cmd('start')
 
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
@@ -683,6 +686,7 @@ class TestSriovKvm(TestCase):
             VM_CORES_MASK, "--eth-peer=0,%s" % vf1_mac)
         vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
         self.vm0_testpmd.execute_cmd('set fwd mac')
+        self.vm0_testpmd.execute_cmd("set promisc all off")
         self.vm0_testpmd.execute_cmd('start')
 
         self.setup_2vm_prerequisite_flag = 1
@@ -982,9 +986,9 @@ class TestSriovKvm(TestCase):
         packet_num = 10
 
         for vf_mac in ["00:11:22:33:44:55", "00:55:44:33:22:11"]:
-            if self.nic.startswith('niantic'):
+            if self.nic.startswith('niantic') or self.nic.startswith('sage'):
                 set_mac_cmd = "mac_addr add port %d vf %d %s"
-            elif self.nic.startswith('fortville'):
+            elif self.nic.startswith('fortville') or self.nic.startswith('fortpark'):
                 set_mac_cmd = "set port %d vf %d %s exact-mac-vlan on"
             self.host_testpmd.execute_cmd(set_mac_cmd % (port_id_0, vf_num, vf_mac))
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to forbid misc packets
  2019-07-02  7:36 zhang,yan
  2019-07-02  7:51 ` Zhu, ShuaiX
@ 2019-07-03  5:42 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2019-07-03  5:42 UTC (permalink / raw)
  To: Zhang, YanX A, dts; +Cc: Zhang, YanX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
> Sent: Tuesday, July 2, 2019 3:37 PM
> To: dts@dpdk.org
> Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to
> forbid misc packets
> 
> 1. disable promisc mode to forbid misc packets.
> 2. Add judge NIC type, make test_two_vms_add_multi_exact_mac_on_vf
> applies to fortpark, sagevill, and sagepond NIC.
> 
> Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
> ---
>  tests/TestSuite_sriov_kvm.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
> index eadeb05..3518f8f 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -627,12 +627,14 @@ class TestSriovKvm(TestCase):
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
>          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm0_testpmd.execute_cmd('set fwd rxonly')
> +        self.vm0_testpmd.execute_cmd('set promisc all off')
>          self.vm0_testpmd.execute_cmd('start')
> 
>          self.vm1_dut_ports = self.vm_dut_1.get_ports('any')
>          self.vm1_testpmd = PmdOutput(self.vm_dut_1)
>          self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm1_testpmd.execute_cmd('set fwd mac')
> +        self.vm1_testpmd.execute_cmd('set promisc all off')
>          self.vm1_testpmd.execute_cmd('start')
> 
>          self.setup_2vm_prerequisite_flag = 1 @@ -676,6 +678,7 @@ class
> TestSriovKvm(TestCase):
>          self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
>          vf1_mac = self.vm1_testpmd.get_port_mac(port_id_0)
>          self.vm1_testpmd.execute_cmd('set fwd mac')
> +        self.vm1_testpmd.execute_cmd("set promisc all off")
>          self.vm1_testpmd.execute_cmd('start')
> 
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0) @@ -683,6 +686,7 @@
> class TestSriovKvm(TestCase):
>              VM_CORES_MASK, "--eth-peer=0,%s" % vf1_mac)
>          vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
>          self.vm0_testpmd.execute_cmd('set fwd mac')
> +        self.vm0_testpmd.execute_cmd("set promisc all off")
>          self.vm0_testpmd.execute_cmd('start')
> 
>          self.setup_2vm_prerequisite_flag = 1 @@ -982,9 +986,9 @@ class
> TestSriovKvm(TestCase):
>          packet_num = 10
> 
>          for vf_mac in ["00:11:22:33:44:55", "00:55:44:33:22:11"]:
> -            if self.nic.startswith('niantic'):
> +            if self.nic.startswith('niantic') or self.nic.startswith('sage'):
>                  set_mac_cmd = "mac_addr add port %d vf %d %s"
> -            elif self.nic.startswith('fortville'):
> +            elif self.nic.startswith('fortville') or self.nic.startswith('fortpark'):
>                  set_mac_cmd = "set port %d vf %d %s exact-mac-vlan on"
>              self.host_testpmd.execute_cmd(set_mac_cmd % (port_id_0, vf_num,
> vf_mac))
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to forbid misc packets
  2019-07-02  7:36 zhang,yan
@ 2019-07-02  7:51 ` Zhu, ShuaiX
  2019-07-03  5:42 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Zhu, ShuaiX @ 2019-07-02  7:51 UTC (permalink / raw)
  To: Zhang, YanX A, dts; +Cc: Zhang, YanX A, Zhu, ShuaiX

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
> Sent: Tuesday, July 2, 2019 3:37 PM
> To: dts@dpdk.org
> Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to
> forbid misc packets
> 
> 1. disable promisc mode to forbid misc packets.
> 2. Add judge NIC type, make test_two_vms_add_multi_exact_mac_on_vf
> applies to fortpark, sagevill, and sagepond NIC.
> 
> Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
> ---
>  tests/TestSuite_sriov_kvm.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py index
> eadeb05..3518f8f 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -627,12 +627,14 @@ class TestSriovKvm(TestCase):
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
>          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm0_testpmd.execute_cmd('set fwd rxonly')
> +        self.vm0_testpmd.execute_cmd('set promisc all off')
>          self.vm0_testpmd.execute_cmd('start')
> 
>          self.vm1_dut_ports = self.vm_dut_1.get_ports('any')
>          self.vm1_testpmd = PmdOutput(self.vm_dut_1)
>          self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm1_testpmd.execute_cmd('set fwd mac')
> +        self.vm1_testpmd.execute_cmd('set promisc all off')
>          self.vm1_testpmd.execute_cmd('start')
> 
>          self.setup_2vm_prerequisite_flag = 1 @@ -676,6 +678,7 @@ class
> TestSriovKvm(TestCase):
>          self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
>          vf1_mac = self.vm1_testpmd.get_port_mac(port_id_0)
>          self.vm1_testpmd.execute_cmd('set fwd mac')
> +        self.vm1_testpmd.execute_cmd("set promisc all off")
>          self.vm1_testpmd.execute_cmd('start')
> 
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0) @@ -683,6 +686,7
> @@ class TestSriovKvm(TestCase):
>              VM_CORES_MASK, "--eth-peer=0,%s" % vf1_mac)
>          vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
>          self.vm0_testpmd.execute_cmd('set fwd mac')
> +        self.vm0_testpmd.execute_cmd("set promisc all off")
>          self.vm0_testpmd.execute_cmd('start')
> 
>          self.setup_2vm_prerequisite_flag = 1 @@ -982,9 +986,9 @@ class
> TestSriovKvm(TestCase):
>          packet_num = 10
> 
>          for vf_mac in ["00:11:22:33:44:55", "00:55:44:33:22:11"]:
> -            if self.nic.startswith('niantic'):
> +            if self.nic.startswith('niantic') or self.nic.startswith('sage'):
>                  set_mac_cmd = "mac_addr add port %d vf %d %s"
> -            elif self.nic.startswith('fortville'):
> +            elif self.nic.startswith('fortville') or
> self.nic.startswith('fortpark'):
>                  set_mac_cmd = "set port %d vf %d %s exact-mac-vlan on"
>              self.host_testpmd.execute_cmd(set_mac_cmd % (port_id_0,
> vf_num, vf_mac))
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to forbid misc packets
@ 2019-07-02  7:36 zhang,yan
  2019-07-02  7:51 ` Zhu, ShuaiX
  2019-07-03  5:42 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: zhang,yan @ 2019-07-02  7:36 UTC (permalink / raw)
  To: dts; +Cc: zhang,yan

1. disable promisc mode to forbid misc packets.
2. Add judge NIC type, make test_two_vms_add_multi_exact_mac_on_vf applies to fortpark, sagevill, and sagepond NIC.

Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
---
 tests/TestSuite_sriov_kvm.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py
index eadeb05..3518f8f 100644
--- a/tests/TestSuite_sriov_kvm.py
+++ b/tests/TestSuite_sriov_kvm.py
@@ -627,12 +627,14 @@ class TestSriovKvm(TestCase):
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
         self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm0_testpmd.execute_cmd('set fwd rxonly')
+        self.vm0_testpmd.execute_cmd('set promisc all off')
         self.vm0_testpmd.execute_cmd('start')
 
         self.vm1_dut_ports = self.vm_dut_1.get_ports('any')
         self.vm1_testpmd = PmdOutput(self.vm_dut_1)
         self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
         self.vm1_testpmd.execute_cmd('set fwd mac')
+        self.vm1_testpmd.execute_cmd('set promisc all off')
         self.vm1_testpmd.execute_cmd('start')
 
         self.setup_2vm_prerequisite_flag = 1
@@ -676,6 +678,7 @@ class TestSriovKvm(TestCase):
         self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
         vf1_mac = self.vm1_testpmd.get_port_mac(port_id_0)
         self.vm1_testpmd.execute_cmd('set fwd mac')
+        self.vm1_testpmd.execute_cmd("set promisc all off")
         self.vm1_testpmd.execute_cmd('start')
 
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
@@ -683,6 +686,7 @@ class TestSriovKvm(TestCase):
             VM_CORES_MASK, "--eth-peer=0,%s" % vf1_mac)
         vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
         self.vm0_testpmd.execute_cmd('set fwd mac')
+        self.vm0_testpmd.execute_cmd("set promisc all off")
         self.vm0_testpmd.execute_cmd('start')
 
         self.setup_2vm_prerequisite_flag = 1
@@ -982,9 +986,9 @@ class TestSriovKvm(TestCase):
         packet_num = 10
 
         for vf_mac in ["00:11:22:33:44:55", "00:55:44:33:22:11"]:
-            if self.nic.startswith('niantic'):
+            if self.nic.startswith('niantic') or self.nic.startswith('sage'):
                 set_mac_cmd = "mac_addr add port %d vf %d %s"
-            elif self.nic.startswith('fortville'):
+            elif self.nic.startswith('fortville') or self.nic.startswith('fortpark'):
                 set_mac_cmd = "set port %d vf %d %s exact-mac-vlan on"
             self.host_testpmd.execute_cmd(set_mac_cmd % (port_id_0, vf_num, vf_mac))
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-03  5:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-02  7:33 [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to forbid misc packets zhang,yan
2019-07-02  7:36 zhang,yan
2019-07-02  7:51 ` Zhu, ShuaiX
2019-07-03  5:42 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).