test suite reviews and discussions
 help / color / mirror / Atom feed
From: "zhu,shuai" <shuaix.zhu@intel.com>
To: dts@dpdk.org
Cc: yinan.wang@intel.com, "zhu,shuai" <shuaix.zhu@intel.com>
Subject: [dts] [PATCH V1 9/9] tests/vhost_dequeue_zero_copy:add create_eal_parameters function.
Date: Sat, 18 Jan 2020 16:38:12 +0800	[thread overview]
Message-ID: <1579336692-98775-9-git-send-email-shuaix.zhu@intel.com> (raw)
In-Reply-To: <1579336692-98775-1-git-send-email-shuaix.zhu@intel.com>

add create_eal_parameters function.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_vhost_dequeue_zero_copy.py | 24 ++++++++--------------
 1 file changed, 9 insertions(+), 15 deletions(-)

diff --git a/tests/TestSuite_vhost_dequeue_zero_copy.py b/tests/TestSuite_vhost_dequeue_zero_copy.py
index 0bce1ae..9e65543 100644
--- a/tests/TestSuite_vhost_dequeue_zero_copy.py
+++ b/tests/TestSuite_vhost_dequeue_zero_copy.py
@@ -127,16 +127,11 @@ class TestVhostDequeueZeroCopy(TestCase):
         elif txfreet == "vector_rx":
             txfreet_args = "--txd=1024 --rxd=1024 --txfreet=992 --txrs=32"
 
-        eal_params = self.dut.create_eal_parameters(cores=self.core_list,
-                    prefix='vhost', ports=[self.port_pci])
-        command_client = self.dut.target + "/app/testpmd %s " + \
-                         " --socket-mem 1024,1024 --legacy-mem " + \
-                         " --vdev 'eth_vhost0,iface=%s/vhost-net,queues=%d,dequeue-zero-copy=%d%s' " + \
-                         " -- -i --nb-cores=%d --rxq=%d --txq=%d %s"
-        command_line_client = command_client % (
-            eal_params, self.base_dir, self.queue_number,
-            zero_copy_info, mode_info, self.nb_cores,
-            self.queue_number, self.queue_number, txfreet_args)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = [r"'eth_vhost0,iface=%s/vhost-net,queues=%d,dequeue-zero-copy=%d%s'" % (self.base_dir, self.queue_number, zero_copy_info, mode_info)]
+        para = " -- -i --nb-cores=%d --rxq=%d --txq=%d %s" % (self.nb_cores, self.queue_number, self.queue_number, txfreet_args)
+        eal_params = self.dut.create_eal_parameters(cores=self.core_list, prefix='vhost', ports=[self.port_pci], vdevs=vdev)
+        command_line_client = testcmd + eal_params + para
         self.vhost_user.send_expect(command_line_client, "testpmd> ", 120)
         self.vhost_user.send_expect("set fwd mac", "testpmd> ", 120)
 
@@ -151,13 +146,12 @@ class TestVhostDequeueZeroCopy(TestCase):
                 core_config, socket=self.ports_socket)
         self.verify(len(core_list) >= (len(self.core_list) + 3),
                 "There has not enought cores to test this case %s" % self.running_case)
+        testcmd = self.dut.target + "/app/testpmd "
+        vdev = " --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,queue_size=1024,%s" % path_mode
+        para = " -- -i --tx-offloads=0x0 --nb-cores=%d --txd=1024 --rxd=1024" % self.nb_cores
         eal_params = self.dut.create_eal_parameters(cores=core_list[len(self.core_list):],
                         prefix='virtio', no_pci=True)
-        command_line = self.dut.target + "/app/testpmd %s " + \
-                        "--socket-mem 1024,1024 --legacy-mem " + \
-                        "--vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,queue_size=1024,%s " + \
-                        "-- -i --tx-offloads=0x0 --nb-cores=%d --txd=1024 --rxd=1024"
-        command_line = command_line % (eal_params, path_mode, self.nb_cores)
+        command_line = testcmd + eal_params + vdev + para
         self.virtio_user.send_expect(command_line, 'testpmd> ', 120)
         self.virtio_user.send_expect('set fwd mac', 'testpmd> ', 120)
         self.virtio_user.send_expect('start', 'testpmd> ', 120)
-- 
2.17.2


  parent reply	other threads:[~2020-01-18  8:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-18  8:38 [dts] [PATCH V1 1/9] tests/vhost_1024_ethports:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 2/9] tests/vhost_enqueue_interrupt:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 3/9] tests/vhost_event_idx_interrupt:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 4/9] tests/vhost_multi_queue_qemu:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 5/9] tests/vhost_pmd_xstats:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 6/9] tests/vhost_virtio_user_interrupt:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 7/9] tests/vhost_virtio_pmd_interrupt:add " zhu,shuai
2020-01-18  8:38 ` [dts] [PATCH V1 8/9] tests/vhost_user_live_migration:add " zhu,shuai
2020-01-18  8:38 ` zhu,shuai [this message]
2020-01-19  8:35 ` [dts] [PATCH V1 1/9] tests/vhost_1024_ethports:add " Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1579336692-98775-9-git-send-email-shuaix.zhu@intel.com \
    --to=shuaix.zhu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).