test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1 0/2] test_plans/dcf_lifecycle: update test plan
@ 2020-06-17  2:43 yufengmx
  2020-06-17  2:43 ` [dts] [PATCH V1 1/2] tests/dcf_lifecycle: " yufengmx
  2020-06-17  2:43 ` [dts] [PATCH V1 2/2] tests/dcf_lifecycle: add test plan index yufengmx
  0 siblings, 2 replies; 6+ messages in thread
From: yufengmx @ 2020-06-17  2:43 UTC (permalink / raw)
  To: dts, zhaoyan.chen; +Cc: yufengmx

 update test plan. 
 rename test plan to correct format. 
 fix typo. 

yufengmx (2):
  tests/dcf_lifecycle: update test plan
  tests/dcf_lifecycle: add test plan index

 ...e_test.rst => dcf_lifecycle_test_plan.rst} | 60 +++++++++----------
 test_plans/index.rst                          |  1 +
 2 files changed, 31 insertions(+), 30 deletions(-)
 rename test_plans/{dcf_lifecycle_test.rst => dcf_lifecycle_test_plan.rst} (93%)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 1/2] tests/dcf_lifecycle: update test plan
  2020-06-17  2:43 [dts] [PATCH V1 0/2] test_plans/dcf_lifecycle: update test plan yufengmx
@ 2020-06-17  2:43 ` " yufengmx
  2020-06-19  6:20   ` Tu, Lijuan
  2020-06-19  8:17   ` Chen, Zhaoyan
  2020-06-17  2:43 ` [dts] [PATCH V1 2/2] tests/dcf_lifecycle: add test plan index yufengmx
  1 sibling, 2 replies; 6+ messages in thread
From: yufengmx @ 2020-06-17  2:43 UTC (permalink / raw)
  To: dts, zhaoyan.chen; +Cc: yufengmx


update test plan.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 ...e_test.rst => dcf_lifecycle_test_plan.rst} | 60 +++++++++----------
 1 file changed, 30 insertions(+), 30 deletions(-)
 rename test_plans/{dcf_lifecycle_test.rst => dcf_lifecycle_test_plan.rst} (93%)

diff --git a/test_plans/dcf_lifecycle_test.rst b/test_plans/dcf_lifecycle_test_plan.rst
similarity index 93%
rename from test_plans/dcf_lifecycle_test.rst
rename to test_plans/dcf_lifecycle_test_plan.rst
index c7d66c6..4f32a9f 100644
--- a/test_plans/dcf_lifecycle_test.rst
+++ b/test_plans/dcf_lifecycle_test_plan.rst
@@ -47,13 +47,13 @@ The DCF can act as a special VF talking to the kernel PF over the same
 virtchannel mailbox to configure the underlying device (port) for the VFs.
 
 The test suite covers the lifecycle of DCF context in Kernel PF, such as
-launch, and exit, switch rules handling, reseting, and exception exit.
+launch, and exit, switch rules handling, resetting, and exception exit.
 
 
 Configuration
 =============
 
-NIC: 2x25G or 2x100G, serveral TC need breakout mode.
+NIC: 2x25G or 2x100G, several TC need breakout mode.
 NIC should have 2 PF ports at least, and connect to tester's ports.
 
 Topology
@@ -106,8 +106,7 @@ Launch dpdk on the VF, request DCF mode ::
 
 Expected: VF get DCF mode. There are outputs in testpmd launching ::
 
-    EAL: PCI device 0000:18:01.0 on NUMA socket 0
-    EAL: probe driver: 8086:1889 net_ice_dcf
+    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0 (socket 0)
 
 
 TC02: DCF on 2 PFs, 1 trust VF on each PF
@@ -134,11 +133,9 @@ Launch dpdk on the VF on each PF, request DCF mode ::
 
 Expected: VF get DCF mode. There are outputs in each testpmd launching ::
 
-    EAL: PCI device 0000:18:01.0 on NUMA socket 0
-    EAL: probe driver: 8086:1889 net_ice_dcf
+    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0 (socket 0)
 
-    EAL: PCI device 0000:18:11.0 on NUMA socket 0
-    EAL: probe driver: 8086:1889 net_ice_dcf
+    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:11.0 (socket 0)
 
 
 TC03: Check only VF zero can get DCF mode
@@ -159,13 +156,13 @@ Launch dpdk on the VF, request DCF mode ::
 
 Expected: VF can NOT get DCF mode. testpmd should provide a friendly output ::
 
-    ice_dcf_get_vf_resource(): Fail to get response of OP_GET_VF_RESOURCE
+    ice_dcf_get_vf_resource(): Failed to get response of OP_GET_VF_RESOURCE
     ice_dcf_init_hw(): Failed to get VF resource
     ice_dcf_dev_init(): Failed to init DCF hardware
 
 Error message in dmesg ::
 
-    ice 0000:18:00.0: Only VF0 can request for DCF.
+    ice 0000:18:00.0: VF 1 requested DCF capability, but only VF 0 is allowed to request DCF capability
     ice 0000:18:00.0: VF 1 failed opcode 3, retval: -5
 
 
@@ -187,13 +184,13 @@ Launch dpdk on the VF, request DCF mode ::
 
 Expected: VF can NOT get DCF mode. testpmd should provide a friendly output ::
 
-    ice_dcf_get_vf_resource(): Fail to get response of OP_GET_VF_RESOURCE
+    ice_dcf_get_vf_resource(): Failed to get response of OP_GET_VF_RESOURCE
     ice_dcf_init_hw(): Failed to get VF resource
     ice_dcf_dev_init(): Failed to init DCF hardware
 
 Error message in dmesg ::
 
-    ice 0000:18:00.0: DCF needs to be trusted.
+    ice 0000:18:00.0: VF needs to be trusted to configure DCF capability
     ice 0000:18:00.0: VF 0 failed opcode 3, retval: -5
 
 
@@ -269,7 +266,8 @@ Launch another testpmd on the VF1, and start mac forward ::
 
     ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 --file-prefix=vf -- -i
     set verbose 1
-    set fwd macstart
+    set fwd mac
+    start
 
 Set switch rule to VF1 0000:18:01.1 from DCF ::
 
@@ -280,7 +278,7 @@ Send a scapy packet to VF1 ::
     p = Ether(dst='xx:xx:xx:xx:xx:xx')/IP(src='192.168.0.2', dst='192.168.0.3')/Raw(64*'x')
     sendp(p, iface='testeri0', count=1)
 
-Check VF1 received the packet. Stats shows 1 packet received and forwarded. ::
+Check VF1 received the packet. Stats shows 1 packet received and forwarded ::
 
     show port stats all
 
@@ -317,7 +315,8 @@ Launch another testpmd on the VF1, and start mac forward ::
 
     ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 --file-prefix=vf -- -i
     set verbose 1
-    set fwd macstart
+    set fwd mac
+    start
 
 Set switch rule to VF1 0000:18:01.1 from DCF ::
 
@@ -337,11 +336,11 @@ Kill DCF process ::
     ps -ef |grep testpmd #Check the process id
     kill -9 <pid>
 
-Send scapy packet again. Check VF1 can't receive the packet ::
+Send scapy packet again. DCF flow rule is still valid, check VF1 can receive the packet ::
 
     show port stats all
 
-Expect: VF1 can't receive the packet
+Expect: VF1 can receive the packet
 
 
 TC13: Launch 2nd DCF process on the same VF
@@ -350,7 +349,7 @@ TC13: Launch 2nd DCF process on the same VF
 Launch 2nd DCF process on the same VF, PF shall reject the request.
 DPDK does not support to open 2nd DCF PMD driver on same VF.
 
-Generate 4 VFs on PF
+Generate 4 VFs on PF ::
 
     echo 4 > /sys/bus/pci/devices/0000:18:00.0/sriov_numvfs
 
@@ -460,7 +459,8 @@ Launch another testpmd on the VF1, and start mac forward ::
 
     ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 -w 18:01.2 --file-prefix=vf -- -i
     set verbose 1
-    set fwd macstart
+    set fwd mac
+    start
 
 Set switch rule to VF1 0000:18:01.1 and VF2 0000:18:01.2 from DCF ::
 
@@ -484,7 +484,7 @@ Reset PF by lanconf command::
     Select "SV Menu" and then select "Reset Menu"
     Select "PF Reset" to trigger PF reset event
 
-Send scapy packet again. Check VF1 can't receive the packet
+Send scapy packet again. Check VF1 can't receive the packet::
 
     show port stats all
 
@@ -560,6 +560,7 @@ Remove ADQ on PF ::
     tc qdisc del dev enp24s0f0 root mqprio
     tc qdisc del dev enp24s0f0 ingress
     tc qdisc show dev enp24s0f0
+    ethtool -K enp24s0f0 hw-tc-offload off
 
 Launch dpdk on the VF, request DCF mode ::
 
@@ -568,8 +569,7 @@ Launch dpdk on the VF, request DCF mode ::
 
 Expect: testpmd can launch successfully. DCF mode can be grant ::
 
-    EAL: PCI device 0000:18:01.0 on NUMA socket 0
-    EAL: probe driver: 8086:1889 net_ice_dcf
+    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0 (socket 0)
 
 
 TC20: When DCF mode enabled, ADQ setting on PF shall fail
@@ -667,8 +667,8 @@ Just change the ADQ commands to MAC-VLAN ::
 
 Remove MAC-VLAN commands ::
 
-  ip link del macvlan0
-  ethtool -K enp24s0f0 l2-fwd-offload off
+   ip link del macvlan0
+   ethtool -K enp24s0f0 l2-fwd-offload off
 
 
 TC23: When DCF mode enabled, PF can't set L2 forwarding
@@ -688,8 +688,8 @@ Just change the ADQ commands to MAC-VLAN ::
 
 Remove MAC-VLAN commands ::
 
-  ip link del macvlan0
-  ethtool -K enp24s0f0 l2-fwd-offload off
+    ip link del macvlan0
+    ethtool -K enp24s0f0 l2-fwd-offload off
 
 
 TC24: DCF and L2 forwarding can be enabled on different PF
@@ -702,12 +702,12 @@ Similar to ADQ test TC21
 
 Just change the ADQ commands to MAC-VLAN ::
 
-    ethtool -K enp24s0f0 l2-fwd-offload on
-    ip link add link macvlan0 link enp24s0f0 type macvlan
+    ethtool -K enp24s0f1 l2-fwd-offload on
+    ip link add link macvlan0 link enp24s0f1 type macvlan
     ifconfig macvlan0 192.168.1.111
     ipconfig macvlan0 up
 
 Remove MAC-VLAN commands ::
 
-  ip link del macvlan0
-  ethtool -K enp24s0f0 l2-fwd-offload off
+    ip link del macvlan0
+    ethtool -K enp24s0f1 l2-fwd-offload off
-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 2/2] tests/dcf_lifecycle: add test plan index
  2020-06-17  2:43 [dts] [PATCH V1 0/2] test_plans/dcf_lifecycle: update test plan yufengmx
  2020-06-17  2:43 ` [dts] [PATCH V1 1/2] tests/dcf_lifecycle: " yufengmx
@ 2020-06-17  2:43 ` yufengmx
  2020-06-19  8:17   ` Chen, Zhaoyan
  1 sibling, 1 reply; 6+ messages in thread
From: yufengmx @ 2020-06-17  2:43 UTC (permalink / raw)
  To: dts, zhaoyan.chen; +Cc: yufengmx


add test plan index.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 test_plans/index.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test_plans/index.rst b/test_plans/index.rst
index 6f5724b..2491e16 100644
--- a/test_plans/index.rst
+++ b/test_plans/index.rst
@@ -45,6 +45,7 @@ The following are the test plans for the DPDK DTS automated test system.
     cvl_advanced_rss_test_plan
     cvl_fdir_test_plan
     cvl_switch_filter_test_plan
+    dcf_lifecycle_test_plan
     crypto_perf_cryptodev_perf_test_plan
     ddp_gtp_qregion_test_plan
     ddp_gtp_test_plan
-- 
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/dcf_lifecycle: update test plan
  2020-06-17  2:43 ` [dts] [PATCH V1 1/2] tests/dcf_lifecycle: " yufengmx
@ 2020-06-19  6:20   ` Tu, Lijuan
  2020-06-19  8:17   ` Chen, Zhaoyan
  1 sibling, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2020-06-19  6:20 UTC (permalink / raw)
  To: Mo, YufengX, dts, Chen, Zhaoyan; +Cc: Mo, YufengX

Applied the series, thanks

-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of yufengmx
Sent: 2020^[$BG/^[(B6^[$B7n^[(B17^[$BF|^[(B 10:43
To: dts@dpdk.org; Chen, Zhaoyan <zhaoyan.chen@intel.com>
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts] [PATCH V1 1/2] tests/dcf_lifecycle: update test plan


update test plan.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 ...e_test.rst => dcf_lifecycle_test_plan.rst} | 60 +++++++++----------
 1 file changed, 30 insertions(+), 30 deletions(-)  rename test_plans/{dcf_lifecycle_test.rst => dcf_lifecycle_test_plan.rst} (93%)

diff --git a/test_plans/dcf_lifecycle_test.rst b/test_plans/dcf_lifecycle_test_plan.rst
similarity index 93%
rename from test_plans/dcf_lifecycle_test.rst rename to test_plans/dcf_lifecycle_test_plan.rst
index c7d66c6..4f32a9f 100644
--- a/test_plans/dcf_lifecycle_test.rst
+++ b/test_plans/dcf_lifecycle_test_plan.rst
@@ -47,13 +47,13 @@ The DCF can act as a special VF talking to the kernel PF over the same  virtchannel mailbox to configure the underlying device (port) for the VFs.
 
 The test suite covers the lifecycle of DCF context in Kernel PF, such as -launch, and exit, switch rules handling, reseting, and exception exit.
+launch, and exit, switch rules handling, resetting, and exception exit.
 
 
 Configuration
 =============
 
-NIC: 2x25G or 2x100G, serveral TC need breakout mode.
+NIC: 2x25G or 2x100G, several TC need breakout mode.
 NIC should have 2 PF ports at least, and connect to tester's ports.
 
 Topology
@@ -106,8 +106,7 @@ Launch dpdk on the VF, request DCF mode ::
 
 Expected: VF get DCF mode. There are outputs in testpmd launching ::
 
-    EAL: PCI device 0000:18:01.0 on NUMA socket 0
-    EAL: probe driver: 8086:1889 net_ice_dcf
+    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0 
+ (socket 0)
 
 
 TC02: DCF on 2 PFs, 1 trust VF on each PF @@ -134,11 +133,9 @@ Launch dpdk on the VF on each PF, request DCF mode ::
 
 Expected: VF get DCF mode. There are outputs in each testpmd launching ::
 
-    EAL: PCI device 0000:18:01.0 on NUMA socket 0
-    EAL: probe driver: 8086:1889 net_ice_dcf
+    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0 
+ (socket 0)
 
-    EAL: PCI device 0000:18:11.0 on NUMA socket 0
-    EAL: probe driver: 8086:1889 net_ice_dcf
+    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:11.0 
+ (socket 0)
 
 
 TC03: Check only VF zero can get DCF mode @@ -159,13 +156,13 @@ Launch dpdk on the VF, request DCF mode ::
 
 Expected: VF can NOT get DCF mode. testpmd should provide a friendly output ::
 
-    ice_dcf_get_vf_resource(): Fail to get response of OP_GET_VF_RESOURCE
+    ice_dcf_get_vf_resource(): Failed to get response of 
+ OP_GET_VF_RESOURCE
     ice_dcf_init_hw(): Failed to get VF resource
     ice_dcf_dev_init(): Failed to init DCF hardware
 
 Error message in dmesg ::
 
-    ice 0000:18:00.0: Only VF0 can request for DCF.
+    ice 0000:18:00.0: VF 1 requested DCF capability, but only VF 0 is 
+ allowed to request DCF capability
     ice 0000:18:00.0: VF 1 failed opcode 3, retval: -5
 
 
@@ -187,13 +184,13 @@ Launch dpdk on the VF, request DCF mode ::
 
 Expected: VF can NOT get DCF mode. testpmd should provide a friendly output ::
 
-    ice_dcf_get_vf_resource(): Fail to get response of OP_GET_VF_RESOURCE
+    ice_dcf_get_vf_resource(): Failed to get response of 
+ OP_GET_VF_RESOURCE
     ice_dcf_init_hw(): Failed to get VF resource
     ice_dcf_dev_init(): Failed to init DCF hardware
 
 Error message in dmesg ::
 
-    ice 0000:18:00.0: DCF needs to be trusted.
+    ice 0000:18:00.0: VF needs to be trusted to configure DCF 
+ capability
     ice 0000:18:00.0: VF 0 failed opcode 3, retval: -5
 
 
@@ -269,7 +266,8 @@ Launch another testpmd on the VF1, and start mac forward ::
 
     ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 --file-prefix=vf -- -i
     set verbose 1
-    set fwd macstart
+    set fwd mac
+    start
 
 Set switch rule to VF1 0000:18:01.1 from DCF ::
 
@@ -280,7 +278,7 @@ Send a scapy packet to VF1 ::
     p = Ether(dst='xx:xx:xx:xx:xx:xx')/IP(src='192.168.0.2', dst='192.168.0.3')/Raw(64*'x')
     sendp(p, iface='testeri0', count=1)
 
-Check VF1 received the packet. Stats shows 1 packet received and forwarded. ::
+Check VF1 received the packet. Stats shows 1 packet received and forwarded ::
 
     show port stats all
 
@@ -317,7 +315,8 @@ Launch another testpmd on the VF1, and start mac forward ::
 
     ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 --file-prefix=vf -- -i
     set verbose 1
-    set fwd macstart
+    set fwd mac
+    start
 
 Set switch rule to VF1 0000:18:01.1 from DCF ::
 
@@ -337,11 +336,11 @@ Kill DCF process ::
     ps -ef |grep testpmd #Check the process id
     kill -9 <pid>
 
-Send scapy packet again. Check VF1 can't receive the packet ::
+Send scapy packet again. DCF flow rule is still valid, check VF1 can receive the packet ::
 
     show port stats all
 
-Expect: VF1 can't receive the packet
+Expect: VF1 can receive the packet
 
 
 TC13: Launch 2nd DCF process on the same VF @@ -350,7 +349,7 @@ TC13: Launch 2nd DCF process on the same VF  Launch 2nd DCF process on the same VF, PF shall reject the request.
 DPDK does not support to open 2nd DCF PMD driver on same VF.
 
-Generate 4 VFs on PF
+Generate 4 VFs on PF ::
 
     echo 4 > /sys/bus/pci/devices/0000:18:00.0/sriov_numvfs
 
@@ -460,7 +459,8 @@ Launch another testpmd on the VF1, and start mac forward ::
 
     ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 -w 18:01.2 --file-prefix=vf -- -i
     set verbose 1
-    set fwd macstart
+    set fwd mac
+    start
 
 Set switch rule to VF1 0000:18:01.1 and VF2 0000:18:01.2 from DCF ::
 
@@ -484,7 +484,7 @@ Reset PF by lanconf command::
     Select "SV Menu" and then select "Reset Menu"
     Select "PF Reset" to trigger PF reset event
 
-Send scapy packet again. Check VF1 can't receive the packet
+Send scapy packet again. Check VF1 can't receive the packet::
 
     show port stats all
 
@@ -560,6 +560,7 @@ Remove ADQ on PF ::
     tc qdisc del dev enp24s0f0 root mqprio
     tc qdisc del dev enp24s0f0 ingress
     tc qdisc show dev enp24s0f0
+    ethtool -K enp24s0f0 hw-tc-offload off
 
 Launch dpdk on the VF, request DCF mode ::
 
@@ -568,8 +569,7 @@ Launch dpdk on the VF, request DCF mode ::
 
 Expect: testpmd can launch successfully. DCF mode can be grant ::
 
-    EAL: PCI device 0000:18:01.0 on NUMA socket 0
-    EAL: probe driver: 8086:1889 net_ice_dcf
+    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0 
+ (socket 0)
 
 
 TC20: When DCF mode enabled, ADQ setting on PF shall fail @@ -667,8 +667,8 @@ Just change the ADQ commands to MAC-VLAN ::
 
 Remove MAC-VLAN commands ::
 
-  ip link del macvlan0
-  ethtool -K enp24s0f0 l2-fwd-offload off
+   ip link del macvlan0
+   ethtool -K enp24s0f0 l2-fwd-offload off
 
 
 TC23: When DCF mode enabled, PF can't set L2 forwarding @@ -688,8 +688,8 @@ Just change the ADQ commands to MAC-VLAN ::
 
 Remove MAC-VLAN commands ::
 
-  ip link del macvlan0
-  ethtool -K enp24s0f0 l2-fwd-offload off
+    ip link del macvlan0
+    ethtool -K enp24s0f0 l2-fwd-offload off
 
 
 TC24: DCF and L2 forwarding can be enabled on different PF @@ -702,12 +702,12 @@ Similar to ADQ test TC21
 
 Just change the ADQ commands to MAC-VLAN ::
 
-    ethtool -K enp24s0f0 l2-fwd-offload on
-    ip link add link macvlan0 link enp24s0f0 type macvlan
+    ethtool -K enp24s0f1 l2-fwd-offload on
+    ip link add link macvlan0 link enp24s0f1 type macvlan
     ifconfig macvlan0 192.168.1.111
     ipconfig macvlan0 up
 
 Remove MAC-VLAN commands ::
 
-  ip link del macvlan0
-  ethtool -K enp24s0f0 l2-fwd-offload off
+    ip link del macvlan0
+    ethtool -K enp24s0f1 l2-fwd-offload off
--
2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/dcf_lifecycle: update test plan
  2020-06-17  2:43 ` [dts] [PATCH V1 1/2] tests/dcf_lifecycle: " yufengmx
  2020-06-19  6:20   ` Tu, Lijuan
@ 2020-06-19  8:17   ` Chen, Zhaoyan
  1 sibling, 0 replies; 6+ messages in thread
From: Chen, Zhaoyan @ 2020-06-19  8:17 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Chen, Zhaoyan

Acked-by: Chen, Zhaoyan <zhaoyan.chen@intel.com>



Regards,
Zhaoyan Chen

> -----Original Message-----
> From: Mo, YufengX <yufengx.mo@intel.com>
> Sent: Wednesday, June 17, 2020 10:43 AM
> To: dts@dpdk.org; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 1/2] tests/dcf_lifecycle: update test plan
> 
> 
> update test plan.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  ...e_test.rst => dcf_lifecycle_test_plan.rst} | 60 +++++++++----------
>  1 file changed, 30 insertions(+), 30 deletions(-)  rename
> test_plans/{dcf_lifecycle_test.rst => dcf_lifecycle_test_plan.rst} (93%)
> 
> diff --git a/test_plans/dcf_lifecycle_test.rst
> b/test_plans/dcf_lifecycle_test_plan.rst
> similarity index 93%
> rename from test_plans/dcf_lifecycle_test.rst rename to
> test_plans/dcf_lifecycle_test_plan.rst
> index c7d66c6..4f32a9f 100644
> --- a/test_plans/dcf_lifecycle_test.rst
> +++ b/test_plans/dcf_lifecycle_test_plan.rst
> @@ -47,13 +47,13 @@ The DCF can act as a special VF talking to the
> kernel PF over the same  virtchannel mailbox to configure the underlying
> device (port) for the VFs.
> 
>  The test suite covers the lifecycle of DCF context in Kernel PF, such as -
> launch, and exit, switch rules handling, reseting, and exception exit.
> +launch, and exit, switch rules handling, resetting, and exception exit.
> 
> 
>  Configuration
>  =============
> 
> -NIC: 2x25G or 2x100G, serveral TC need breakout mode.
> +NIC: 2x25G or 2x100G, several TC need breakout mode.
>  NIC should have 2 PF ports at least, and connect to tester's ports.
> 
>  Topology
> @@ -106,8 +106,7 @@ Launch dpdk on the VF, request DCF mode ::
> 
>  Expected: VF get DCF mode. There are outputs in testpmd launching ::
> 
> -    EAL: PCI device 0000:18:01.0 on NUMA socket 0
> -    EAL: probe driver: 8086:1889 net_ice_dcf
> +    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0
> + (socket 0)
> 
> 
>  TC02: DCF on 2 PFs, 1 trust VF on each PF @@ -134,11 +133,9 @@ Launch
> dpdk on the VF on each PF, request DCF mode ::
> 
>  Expected: VF get DCF mode. There are outputs in each testpmd
> launching ::
> 
> -    EAL: PCI device 0000:18:01.0 on NUMA socket 0
> -    EAL: probe driver: 8086:1889 net_ice_dcf
> +    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0
> + (socket 0)
> 
> -    EAL: PCI device 0000:18:11.0 on NUMA socket 0
> -    EAL: probe driver: 8086:1889 net_ice_dcf
> +    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:11.0
> + (socket 0)
> 
> 
>  TC03: Check only VF zero can get DCF mode @@ -159,13 +156,13 @@
> Launch dpdk on the VF, request DCF mode ::
> 
>  Expected: VF can NOT get DCF mode. testpmd should provide a friendly
> output ::
> 
> -    ice_dcf_get_vf_resource(): Fail to get response of
> OP_GET_VF_RESOURCE
> +    ice_dcf_get_vf_resource(): Failed to get response of
> + OP_GET_VF_RESOURCE
>      ice_dcf_init_hw(): Failed to get VF resource
>      ice_dcf_dev_init(): Failed to init DCF hardware
> 
>  Error message in dmesg ::
> 
> -    ice 0000:18:00.0: Only VF0 can request for DCF.
> +    ice 0000:18:00.0: VF 1 requested DCF capability, but only VF 0 is
> + allowed to request DCF capability
>      ice 0000:18:00.0: VF 1 failed opcode 3, retval: -5
> 
> 
> @@ -187,13 +184,13 @@ Launch dpdk on the VF, request DCF mode ::
> 
>  Expected: VF can NOT get DCF mode. testpmd should provide a friendly
> output ::
> 
> -    ice_dcf_get_vf_resource(): Fail to get response of
> OP_GET_VF_RESOURCE
> +    ice_dcf_get_vf_resource(): Failed to get response of
> + OP_GET_VF_RESOURCE
>      ice_dcf_init_hw(): Failed to get VF resource
>      ice_dcf_dev_init(): Failed to init DCF hardware
> 
>  Error message in dmesg ::
> 
> -    ice 0000:18:00.0: DCF needs to be trusted.
> +    ice 0000:18:00.0: VF needs to be trusted to configure DCF
> + capability
>      ice 0000:18:00.0: VF 0 failed opcode 3, retval: -5
> 
> 
> @@ -269,7 +266,8 @@ Launch another testpmd on the VF1, and start mac
> forward ::
> 
>      ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 --file-
> prefix=vf -- -i
>      set verbose 1
> -    set fwd macstart
> +    set fwd mac
> +    start
> 
>  Set switch rule to VF1 0000:18:01.1 from DCF ::
> 
> @@ -280,7 +278,7 @@ Send a scapy packet to VF1 ::
>      p = Ether(dst='xx:xx:xx:xx:xx:xx')/IP(src='192.168.0.2',
> dst='192.168.0.3')/Raw(64*'x')
>      sendp(p, iface='testeri0', count=1)
> 
> -Check VF1 received the packet. Stats shows 1 packet received and
> forwarded. ::
> +Check VF1 received the packet. Stats shows 1 packet received and
> forwarded ::
> 
>      show port stats all
> 
> @@ -317,7 +315,8 @@ Launch another testpmd on the VF1, and start mac
> forward ::
> 
>      ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 --file-
> prefix=vf -- -i
>      set verbose 1
> -    set fwd macstart
> +    set fwd mac
> +    start
> 
>  Set switch rule to VF1 0000:18:01.1 from DCF ::
> 
> @@ -337,11 +336,11 @@ Kill DCF process ::
>      ps -ef |grep testpmd #Check the process id
>      kill -9 <pid>
> 
> -Send scapy packet again. Check VF1 can't receive the packet ::
> +Send scapy packet again. DCF flow rule is still valid, check VF1 can receive
> the packet ::
> 
>      show port stats all
> 
> -Expect: VF1 can't receive the packet
> +Expect: VF1 can receive the packet
> 
> 
>  TC13: Launch 2nd DCF process on the same VF @@ -350,7 +349,7 @@
> TC13: Launch 2nd DCF process on the same VF  Launch 2nd DCF process
> on the same VF, PF shall reject the request.
>  DPDK does not support to open 2nd DCF PMD driver on same VF.
> 
> -Generate 4 VFs on PF
> +Generate 4 VFs on PF ::
> 
>      echo 4 > /sys/bus/pci/devices/0000:18:00.0/sriov_numvfs
> 
> @@ -460,7 +459,8 @@ Launch another testpmd on the VF1, and start mac
> forward ::
> 
>      ./x86_64-native-linuxapp-gcc/app/testpmd -l 11-14 -n 4 -w 18:01.1 -w
> 18:01.2 --file-prefix=vf -- -i
>      set verbose 1
> -    set fwd macstart
> +    set fwd mac
> +    start
> 
>  Set switch rule to VF1 0000:18:01.1 and VF2 0000:18:01.2 from DCF ::
> 
> @@ -484,7 +484,7 @@ Reset PF by lanconf command::
>      Select "SV Menu" and then select "Reset Menu"
>      Select "PF Reset" to trigger PF reset event
> 
> -Send scapy packet again. Check VF1 can't receive the packet
> +Send scapy packet again. Check VF1 can't receive the packet::
> 
>      show port stats all
> 
> @@ -560,6 +560,7 @@ Remove ADQ on PF ::
>      tc qdisc del dev enp24s0f0 root mqprio
>      tc qdisc del dev enp24s0f0 ingress
>      tc qdisc show dev enp24s0f0
> +    ethtool -K enp24s0f0 hw-tc-offload off
> 
>  Launch dpdk on the VF, request DCF mode ::
> 
> @@ -568,8 +569,7 @@ Launch dpdk on the VF, request DCF mode ::
> 
>  Expect: testpmd can launch successfully. DCF mode can be grant ::
> 
> -    EAL: PCI device 0000:18:01.0 on NUMA socket 0
> -    EAL: probe driver: 8086:1889 net_ice_dcf
> +    EAL: Probe PCI driver: net_ice_dcf (8086:1889) device: 0000:18:01.0
> + (socket 0)
> 
> 
>  TC20: When DCF mode enabled, ADQ setting on PF shall fail @@ -667,8
> +667,8 @@ Just change the ADQ commands to MAC-VLAN ::
> 
>  Remove MAC-VLAN commands ::
> 
> -  ip link del macvlan0
> -  ethtool -K enp24s0f0 l2-fwd-offload off
> +   ip link del macvlan0
> +   ethtool -K enp24s0f0 l2-fwd-offload off
> 
> 
>  TC23: When DCF mode enabled, PF can't set L2 forwarding @@ -688,8
> +688,8 @@ Just change the ADQ commands to MAC-VLAN ::
> 
>  Remove MAC-VLAN commands ::
> 
> -  ip link del macvlan0
> -  ethtool -K enp24s0f0 l2-fwd-offload off
> +    ip link del macvlan0
> +    ethtool -K enp24s0f0 l2-fwd-offload off
> 
> 
>  TC24: DCF and L2 forwarding can be enabled on different PF @@ -702,12
> +702,12 @@ Similar to ADQ test TC21
> 
>  Just change the ADQ commands to MAC-VLAN ::
> 
> -    ethtool -K enp24s0f0 l2-fwd-offload on
> -    ip link add link macvlan0 link enp24s0f0 type macvlan
> +    ethtool -K enp24s0f1 l2-fwd-offload on
> +    ip link add link macvlan0 link enp24s0f1 type macvlan
>      ifconfig macvlan0 192.168.1.111
>      ipconfig macvlan0 up
> 
>  Remove MAC-VLAN commands ::
> 
> -  ip link del macvlan0
> -  ethtool -K enp24s0f0 l2-fwd-offload off
> +    ip link del macvlan0
> +    ethtool -K enp24s0f1 l2-fwd-offload off
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 2/2] tests/dcf_lifecycle: add test plan index
  2020-06-17  2:43 ` [dts] [PATCH V1 2/2] tests/dcf_lifecycle: add test plan index yufengmx
@ 2020-06-19  8:17   ` Chen, Zhaoyan
  0 siblings, 0 replies; 6+ messages in thread
From: Chen, Zhaoyan @ 2020-06-19  8:17 UTC (permalink / raw)
  To: Mo, YufengX, dts; +Cc: Chen, Zhaoyan

Acked-by: Chen, Zhaoyan <zhaoyan.chen@intel.com>



Regards,
Zhaoyan Chen

> -----Original Message-----
> From: Mo, YufengX <yufengx.mo@intel.com>
> Sent: Wednesday, June 17, 2020 10:43 AM
> To: dts@dpdk.org; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/dcf_lifecycle: add test plan index
> 
> 
> add test plan index.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  test_plans/index.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test_plans/index.rst b/test_plans/index.rst index
> 6f5724b..2491e16 100644
> --- a/test_plans/index.rst
> +++ b/test_plans/index.rst
> @@ -45,6 +45,7 @@ The following are the test plans for the DPDK DTS
> automated test system.
>      cvl_advanced_rss_test_plan
>      cvl_fdir_test_plan
>      cvl_switch_filter_test_plan
> +    dcf_lifecycle_test_plan
>      crypto_perf_cryptodev_perf_test_plan
>      ddp_gtp_qregion_test_plan
>      ddp_gtp_test_plan
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17  2:43 [dts] [PATCH V1 0/2] test_plans/dcf_lifecycle: update test plan yufengmx
2020-06-17  2:43 ` [dts] [PATCH V1 1/2] tests/dcf_lifecycle: " yufengmx
2020-06-19  6:20   ` Tu, Lijuan
2020-06-19  8:17   ` Chen, Zhaoyan
2020-06-17  2:43 ` [dts] [PATCH V1 2/2] tests/dcf_lifecycle: add test plan index yufengmx
2020-06-19  8:17   ` Chen, Zhaoyan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox