test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V2 0/2] switch i40evf to iavf
  2021-01-11 10:26 [dts] [PATCH V2 0/2] switch i40evf to iavf Xie wei
@ 2021-01-11 10:26 ` Xie, WeiX
  2021-01-11 10:26 ` [dts] [PATCH V2 1/2] tests/TestSuite_vf_jumboframe:Rx packet size need add 4 bytes Xie wei
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Xie, WeiX @ 2021-01-11 10:26 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Monday, January 11, 2021 6:26 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V2 0/2] switch i40evf to iavf


[-- Attachment #2: TestVEBSwitching.log --]
[-- Type: application/octet-stream, Size: 2270768 bytes --]

[-- Attachment #3: TestVfJumboFrame.log --]
[-- Type: application/octet-stream, Size: 66162 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V2 0/2] switch i40evf to iavf
@ 2021-01-11 10:26 Xie wei
  2021-01-11 10:26 ` Xie, WeiX
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Xie wei @ 2021-01-11 10:26 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.

Xie wei (2):
  tests/TestSuite_vf_jumboframe:Rx packet size need add 4 bytes
  tests/TestSuite_veb_switch:vf1 RX-bytes need add 4 bytes

 tests/TestSuite_veb_switch.py    |  7 +++++++
 tests/TestSuite_vf_jumboframe.py | 13 ++++++++++++-
 2 files changed, 19 insertions(+), 1 deletion(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V2 1/2] tests/TestSuite_vf_jumboframe:Rx packet size need add 4 bytes
  2021-01-11 10:26 [dts] [PATCH V2 0/2] switch i40evf to iavf Xie wei
  2021-01-11 10:26 ` Xie, WeiX
@ 2021-01-11 10:26 ` Xie wei
  2021-01-11 10:26 ` [dts] [PATCH V2 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes " Xie wei
  2021-01-13  8:24 ` [dts] [PATCH V2 0/2] switch i40evf to iavf Tu, Lijuan
  3 siblings, 0 replies; 5+ messages in thread
From: Xie wei @ 2021-01-11 10:26 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.
After testing, found that:
when send a packet which length is 1513 bytes.
for net_iavf driver; the statistic from "show port stats 0" is: RX-bytes: 1513
for net_i40e_vf driver; the statistic from "show port stats 0" is: RX-bytes: 1517

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index 6da2c5e5..cb77cf31 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -192,6 +192,11 @@ class TestVfJumboFrame(TestCase):
         else:
             return None
 
+    def check_vf_driver(self):
+        output = self.vm_testpmd.execute_cmd("show port info 0")
+        vf0_driver = re.findall("Driver\s*name:\s*(\w+)", output)
+        return vf0_driver[0]
+
     def jumboframes_send_packet(self, pktsize, received=True):
         """
         Send 1 packet to portid
@@ -216,13 +221,19 @@ class TestVfJumboFrame(TestCase):
         rx_bytes -= rx_bytes_ori
         rx_err -= rx_err_ori
 
+        vf_driver = self.check_vf_driver()
+
         if received:
             self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error")
 
             if self.kdriver == "ixgbe" or self.kdriver == 'ice':
                 self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
             else:
-                self.verify(rx_bytes == pktsize, "Rx packet size should be equal to packet size")
+                if self.kdriver == "i40e":
+                    if vf_driver == "net_iavf":
+                        self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
+                    else:
+                        self.verify(rx_bytes == pktsize, "Rx packet size should be equal to packet size")
 
             if self.kdriver == "igb":
                 self.verify(tx_bytes == pktsize, "Tx packet size should be packet size")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V2 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add 4 bytes
  2021-01-11 10:26 [dts] [PATCH V2 0/2] switch i40evf to iavf Xie wei
  2021-01-11 10:26 ` Xie, WeiX
  2021-01-11 10:26 ` [dts] [PATCH V2 1/2] tests/TestSuite_vf_jumboframe:Rx packet size need add 4 bytes Xie wei
@ 2021-01-11 10:26 ` Xie wei
  2021-01-13  8:24 ` [dts] [PATCH V2 0/2] switch i40evf to iavf Tu, Lijuan
  3 siblings, 0 replies; 5+ messages in thread
From: Xie wei @ 2021-01-11 10:26 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.
After testing, found that:
when send a packet which length is 60 bytes.
for net_iavf driver; the statistic from "show port stats 0" is: RX-bytes:56,
but set verbose 1, we can see the packet length is 60.
for net_i40e_vf driver; the statistic from "show port stats 0" is: RX-bytes: 60

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_veb_switch.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/TestSuite_veb_switch.py b/tests/TestSuite_veb_switch.py
index 00dd76e7..cdd2b3c4 100644
--- a/tests/TestSuite_veb_switch.py
+++ b/tests/TestSuite_veb_switch.py
@@ -283,11 +283,18 @@ class TestVEBSwitching(TestCase):
 
         self.dut.send_expect("stop", "testpmd>", 2)
         self.session_secondary.send_expect("stop", "testpmd>", 2)
+        out = self.session_secondary.send_expect("show port info 0", "testpmd>")
+        vf1_driver = re.findall("Driver\s*name:\s*(\w+)", out)[0]
 
         vf0_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
         vf1_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
         if self.kdriver == 'ice':
             vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
+        if self.kdriver == 'i40e':
+            if vf1_driver == 'net_iavf':
+                vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
+            else:
+                vf1_rx_stats[-1] = vf1_rx_stats[-1]
         self.verify(vf0_tx_stats[0] != 0, "no packet was sent by VF0")
         self.verify(vf0_tx_stats == vf1_rx_stats, "VF1 failed to receive packets from VF0")
     
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V2 0/2] switch i40evf to iavf
  2021-01-11 10:26 [dts] [PATCH V2 0/2] switch i40evf to iavf Xie wei
                   ` (2 preceding siblings ...)
  2021-01-11 10:26 ` [dts] [PATCH V2 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes " Xie wei
@ 2021-01-13  8:24 ` Tu, Lijuan
  3 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2021-01-13  8:24 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

> DTS framework has switched i40evf to iavf, so align with it.
> 
> Xie wei (2):
>   tests/TestSuite_vf_jumboframe:Rx packet size need add 4 bytes
>   tests/TestSuite_veb_switch:vf1 RX-bytes need add 4 bytes

Applied, next time please use subject as below
e.g. tests/ vf_jumboframe: rx packet size need add 4 bytes
e.g. tests/ veb_switch: vf1 RX-bytes need add 4 bytes

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-01-13  8:24 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 10:26 [dts] [PATCH V2 0/2] switch i40evf to iavf Xie wei
2021-01-11 10:26 ` Xie, WeiX
2021-01-11 10:26 ` [dts] [PATCH V2 1/2] tests/TestSuite_vf_jumboframe:Rx packet size need add 4 bytes Xie wei
2021-01-11 10:26 ` [dts] [PATCH V2 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes " Xie wei
2021-01-13  8:24 ` [dts] [PATCH V2 0/2] switch i40evf to iavf Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git