test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH v1]test_plans: change test plan according to DPDK-25551
@ 2021-01-28  2:13 Peng Yuan
  0 siblings, 0 replies; only message in thread
From: Peng Yuan @ 2021-01-28  2:13 UTC (permalink / raw)
  To: dts; +Cc: Peng Yuan

the related test plans:
cvl_dcf_switch_filter_test_plan.rst
dcf_lifecycle_test_plan.rst
iavf_fdir_test_plan.rst

Signed-off-by: Peng Yuan <yuan.peng@intel.com>

diff --git a/test_plans/cvl_dcf_switch_filter_test_plan.rst b/test_plans/cvl_dcf_switch_filter_test_plan.rst
index 3b63c041..11d35f0f 100644
--- a/test_plans/cvl_dcf_switch_filter_test_plan.rst
+++ b/test_plans/cvl_dcf_switch_filter_test_plan.rst
@@ -4549,13 +4549,7 @@ Subcase 1: DCF stop/DCF start
      tetspmd> port stop 0
      testpmd> port start 0
 
-4. check the rule list::
-
-     testpmd> flow list 0
-
-   check the rule is still there.
-
-5. send matched packets, port 1 can still receive the packets.
+4. send matched packets, port 1 can still receive the packets.
 
 Test case: Drop action test
 ===========================
diff --git a/test_plans/dcf_lifecycle_test_plan.rst b/test_plans/dcf_lifecycle_test_plan.rst
index 1e5fcecd..ad54272a 100644
--- a/test_plans/dcf_lifecycle_test_plan.rst
+++ b/test_plans/dcf_lifecycle_test_plan.rst
@@ -950,8 +950,7 @@ TC30: DCF enabled, DCF VF reset
     port start 0
     start
 
-4. check the rule still be listed.
-   send the packet with new mac address of VF1 again, check the packet still be dropped by VF1.
+4. send the packet with new mac address of VF1 again, check the packet still be dropped by VF1.
    the rule still take effect.
 
 DCF mode and any ACL filters (not added by DCF) shall be mutually exclusive
diff --git a/test_plans/iavf_fdir_test_plan.rst b/test_plans/iavf_fdir_test_plan.rst
index 6de28d2c..09fe1793 100644
--- a/test_plans/iavf_fdir_test_plan.rst
+++ b/test_plans/iavf_fdir_test_plan.rst
@@ -4077,9 +4077,9 @@ Subcase 1: port stop/port start
     testpmd> port stop 0
     testpmd> port start 0
 
-4. show the rule list, the rule is still there.
+4. show the rule list, there is no rule listed.
 
-5. verify matched packet can be still redirected to queue 1 with FDIR matched ID=0x0.
+5. verify matched packet is distributed by RSS without FDIR matched ID.
 
 Subcase 2: delete rules
 -----------------------
@@ -4182,8 +4182,9 @@ Subcase 3: VF port reset and create a new rule
 
    the port can be stop/reset/start normally without error message.
 
-4. check the rule still be listed,
-   send matched packet to vf0, check the packet is redirected by RSS without FDIR matched ID.
+4. check there is not rule listed on port 0.
+   the rule of port 1 is still be listed.
+   send matched packet to vf0, check the packet is distributed by RSS.
    send matched packet to vf1, check the packet is redirected to queue 5 with FDIR matched ID=0x0.
 
 5. create rule 0 on port 0 again, the rule can be created successfully.
@@ -4210,18 +4211,18 @@ Subcase 4: VF port reset and delete the rule
 
 3. vf reset::
 
-    port stop 0
-    port reset 0
-    port start 0
+    port stop 1
+    port reset 1
+    port start 1
 
    the port can be stop/reset/start normally without error message.
 
-4. check the rule still be listed,
-   send matched packet to vf0, check the packet is redirected by RSS without FDIR matched ID.
-   send matched packet to vf1, check the packet is redirected to queue 5 with FDIR matched ID=0x0.
+4. check there is not rule listed on port 1.
+   the rule of port 0 is still be listed.
+   send matched packet to vf0, check the packet is redirected to queue 5 with FDIR matched ID=0x0.
+   send matched packet to vf1, check the packet is distributed by RSS.
 
-5. destroy rule 0 of vf0, report error, but no core dump.
-   destroy rule 0 of vf1 successfully.
+5. destroy rule 0 of vf0 successfully.
    send matched packet to vf0, check the packet is redirected by RSS without FDIR matched ID.
    send matched packet to vf1, check the packet is redirected by RSS without FDIR matched ID.
 
@@ -4260,7 +4261,7 @@ Subcase 5: PF reset VF and create a new rule
 
    the port can be stop/reset/start normally without error message.
 
-5. check the rule of vf0 still be listed,
+5. check there is not rule listed on vf0.
    send matched packet to vf0 with new mac address, check the packet is redirected by RSS without FDIR matched ID.
    send matched packet to vf1, check the packet is redirected to queue 5 with FDIR matched ID=0x0.
 
@@ -4295,23 +4296,23 @@ Subcase 6: PF reset VF and delete the rule
 
 4. testpmd shows::
 
-    Port 0: reset event
+    Port 1: reset event
 
    then vf reset::
 
-    port stop 0
-    port reset 0
-    port start 0
+    port stop 1
+    port reset 1
+    port start 1
 
    the port can be stop/reset/start normally without error message.
 
-5. destroy rule 0 of vf0, report error, but no core dump.
-   destroy rule 0 of vf1 successfully.
+5. check there is not rule listed on vf1.
+   destroy rule 0 of vf0 successfully.
    send matched packet to vf0, check the packet is redirected by RSS without FDIR matched ID.
    send matched packet to vf1, check the packet is redirected by RSS without FDIR matched ID.
 
-6. create rule 0 on port 0 again, the rule can be created successfully.
-   send matched packet to port 0, the packet can be redirected to queue 5 with FDIR matched ID=0x0.
+6. create rule 1 on port 1 again, the rule can be created successfully.
+   send matched packet to port 1, the packet can be redirected to queue 5 with FDIR matched ID=0x0.
 
 7. quit and relaunch testpmd, then create same rules successfully.
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-01-28  9:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28  2:13 [dts] [PATCH v1]test_plans: change test plan according to DPDK-25551 Peng Yuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git