test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [V1] ixia_network/ixnet: fix bug of changing string content
@ 2022-05-11  6:14 Jun Dong
  2022-05-18  9:12 ` lijuan.tu
  0 siblings, 1 reply; 2+ messages in thread
From: Jun Dong @ 2022-05-11  6:14 UTC (permalink / raw)
  To: dts; +Cc: lijuan.tu, qingx.sun, junx.dong

In history patch that add OUTPUT_DIR variable into initional function to 
fix E1101 error that instance has no member error[pylint checking]. this 
intruduce a bug, OUTPUT_DIR was defined in subclass as a property contained 
a string  , and when parent class initial, the OUTPUT_DIR attribute was 
already exist and couldn't redefine again. this patch attempt to fix it 
that  through reflection mechanism to get the value instead of using 
the variable directly and to avoid the E1101 error.

Signed-off-by: Jun Dong <junx.dong@intel.com>
---
 framework/ixia_network/ixnet.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/framework/ixia_network/ixnet.py b/framework/ixia_network/ixnet.py
index 08aaf568..5d54fa30 100644
--- a/framework/ixia_network/ixnet.py
+++ b/framework/ixia_network/ixnet.py
@@ -70,7 +70,6 @@ class IxnetTrafficGenerator(object):
         # initialize ixNetwork
         self.new_blank_config()
         self.tg_vports = self.assign_ports(self.tg_ports)
-        self.OUTPUT_DIR = None
 
     def get_session_id(self, api_server):
         url = "{server}/api/v1/sessions".format(server=api_server)
@@ -746,7 +745,10 @@ class IxnetTrafficGenerator(object):
 
         timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
         copy_to_path = os.sep.join(
-            [self.OUTPUT_DIR, "ixnet" + datetime.now().strftime("%Y%m%d_%H%M%S")]
+            [
+                getattr(self, "OUTPUT_DIR"),
+                "ixnet" + datetime.now().strftime("%Y%m%d_%H%M%S"),
+            ]
         )
         if not os.path.exists(copy_to_path):
             os.makedirs(copy_to_path)
-- 
2.33.1.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-05-18  9:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-11  6:14 [dts] [V1] ixia_network/ixnet: fix bug of changing string content Jun Dong
2022-05-18  9:12 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).