test suite reviews and discussions
 help / color / Atom feed
From: "Zhang, YanX A" <yanx.a.zhang@intel.com>
To: "Li, WenjieX A" <wenjiex.a.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] tests/ipgre: optimize script
Date: Mon, 9 Sep 2019 02:36:54 +0000
Message-ID: <2C49E4B25FAD1D419F7564D633EF72E1F47503@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <1567795350-70617-1-git-send-email-wenjiex.a.li@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1969 bytes --]

Tested-by:  Zhang, YanX A <yanx.a.zhang@intel.com>

Notes: One case failed due to a bug. The bug ID is 15071

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Saturday, September 7, 2019 2:43 AM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/ipgre: optimize script

1. could support cvl nic, add cvl to nic list 2. move dut.kill_all from tear_down_all to tear_down, since testpmd will be started in every case, if one case is failed, the testpmd is still runnning, this will affect the following cases.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_ipgre.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py index 7fbddf1..e10b0e0 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -63,7 +63,7 @@ class TestIpgre(TestCase):
         """
         self.printFlag = self._enable_debug
         ports = self.dut.get_ports()
-        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville"],
+        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", 
+ "fortville_spirit_single", "fortville_25g", "carlsville", 
+ "columbiaville_25g", "columbiaville_100g"],
                     "GRE tunnel packet type only support by fortville and carlsville")
         self.verify(len(ports) >= 1, "Insufficient ports for testing")
         valports = [_ for _ in ports if self.tester.get_local_port(_) != -1] @@ -439,12 +439,11 @@ class TestIpgre(TestCase):
         Run after each test case.
         Nothing to do.
         """
-        pass
+        self.dut.kill_all()
 
     def tear_down_all(self):
         """
         Run after each test suite.
         Nothing to do.
         """
-        self.dut.kill_all()
         pass
--
2.17.1


[-- Attachment #2: TestIpgre.log --]
[-- Type: application/octet-stream, Size: 85292 bytes --]

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 18:42 Wenjie Li
2019-09-09  2:36 ` Zhang, YanX A [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2C49E4B25FAD1D419F7564D633EF72E1F47503@SHSMSX105.ccr.corp.intel.com \
    --to=yanx.a.zhang@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenjiex.a.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox