test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use differents cores between vf to vf
@ 2020-12-29  1:57 Xie wei
  2020-12-29  1:57 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:use " Xie wei
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Xie wei @ 2020-12-29  1:57 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

If several testpmd are started at the same time for vfs, the rx_stats scale between vf to vf are quite different.    
So different cores should be used.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_floating_veb.py | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_floating_veb.py b/tests/TestSuite_floating_veb.py
index f4d62deb..8bfc4c49 100644
--- a/tests/TestSuite_floating_veb.py
+++ b/tests/TestSuite_floating_veb.py
@@ -161,6 +161,12 @@ class TestFloatingVEBSwitching(TestCase):
         self.pf_pci = self.dut.ports_info[self.used_dut_port]['pci']
         self.path = self.dut.apps_name['test-pmd']
 
+        self.dut.init_reserved_core()
+        self.cores_vf0 = self.dut.get_reserved_core('2C', 0)
+        self.cores_vf1 = self.dut.get_reserved_core('2C', 0)
+        self.cores_vf2 = self.dut.get_reserved_core('2C', 0)
+        self.cores_vf3 = self.dut.get_reserved_core('2C', 0)
+
     def set_up(self):
         """
         This is to clear up environment before the case run.
@@ -304,14 +310,14 @@ class TestFloatingVEBSwitching(TestCase):
         self.dut.send_expect("port start all", "testpmd>")
         time.sleep(2)
         # start VF0
-        self.pmdout_2.start_testpmd("Default", prefix="test2", ports=[self.sriov_vfs_port[0].pci])
+        self.pmdout_2.start_testpmd(self.cores_vf0, prefix="test2", ports=[self.sriov_vfs_port[0].pci])
         self.session_secondary.send_expect("mac_addr add 0 %s" % self.vf0_mac, "testpmd>")
         self.session_secondary.send_expect("set fwd rxonly", "testpmd>")
         self.session_secondary.send_expect("set promisc all off", "testpmd>")
         self.session_secondary.send_expect("start", "testpmd>")
         time.sleep(2)
         # start VF1
-        self.pmdout_3.start_testpmd("Default", prefix="test3", ports=[self.sriov_vfs_port[1].pci], param="--eth-peer=0,%s" % self.vf0_mac)
+        self.pmdout_3.start_testpmd(self.cores_vf1, prefix="test3", ports=[self.sriov_vfs_port[1].pci], param="--eth-peer=0,%s" % self.vf0_mac)
         self.session_third.send_expect("set fwd txonly", "testpmd>")
         self.session_third.send_expect("set promisc all off", "testpmd>")
         self.session_third.send_expect("start", "testpmd>")
@@ -415,12 +421,12 @@ class TestFloatingVEBSwitching(TestCase):
         # VF0->VF2
         # start VF0
         self.dut.send_expect("port start all", "testpmd>")
-        self.pmdout_2.start_testpmd("Default", prefix="test2", ports=[self.sriov_vfs_port[0].pci], param="--eth-peer=0,%s" % self.vf2_mac)
+        self.pmdout_2.start_testpmd(self.cores_vf0, prefix="test2", ports=[self.sriov_vfs_port[0].pci], param="--eth-peer=0,%s" % self.vf2_mac)
         self.session_secondary.send_expect("mac_addr add 0 %s" % self.vf0_mac, "testpmd>")
         self.session_secondary.send_expect("set fwd txonly", "testpmd>")
         self.session_secondary.send_expect("set promisc all off", "testpmd>")
         # start VF2
-        self.pmdout_3.start_testpmd("Default", prefix="test3", ports=[self.sriov_vfs_port[2].pci])
+        self.pmdout_3.start_testpmd(self.cores_vf2, prefix="test3", ports=[self.sriov_vfs_port[2].pci])
         self.session_third.send_expect("mac_addr add 0 %s" % self.vf2_mac, "testpmd>")
         self.session_third.send_expect("set fwd rxonly", "testpmd>")
         self.session_third.send_expect("set promisc all off", "testpmd>")
@@ -449,12 +455,12 @@ class TestFloatingVEBSwitching(TestCase):
         # VF3->VF2
         # start VF3
         self.dut.send_expect("port start all", "testpmd>")
-        self.pmdout_2.start_testpmd("Default", prefix="test2", ports=[self.sriov_vfs_port[3].pci], param="--eth-peer=0,%s" % self.vf2_mac)
+        self.pmdout_2.start_testpmd(self.cores_vf3, prefix="test2", ports=[self.sriov_vfs_port[3].pci], param="--eth-peer=0,%s" % self.vf2_mac)
         self.session_secondary.send_expect("mac_addr add 0 %s" % self.vf0_mac, "testpmd>")
         self.session_secondary.send_expect("set fwd txonly", "testpmd>")
         self.session_secondary.send_expect("set promisc all off", "testpmd>")
         # start VF2
-        self.pmdout_3.start_testpmd("Default", prefix="test3", ports=[self.sriov_vfs_port[2].pci])
+        self.pmdout_3.start_testpmd(self.cores_vf2, prefix="test3", ports=[self.sriov_vfs_port[2].pci])
         self.session_third.send_expect("mac_addr add 0 %s" % self.vf2_mac, "testpmd>")
         self.session_third.send_expect("set fwd rxonly", "testpmd>")
         self.session_third.send_expect("set promisc all off", "testpmd>")
@@ -575,14 +581,14 @@ class TestFloatingVEBSwitching(TestCase):
         time.sleep(2)
 
         # VF2->VF1
-        self.pmdout_2.start_testpmd("Default", prefix="test2", ports=[self.sriov_vfs_port[1].pci])
+        self.pmdout_2.start_testpmd(self.cores_vf1, prefix="test2", ports=[self.sriov_vfs_port[1].pci])
         self.session_secondary.send_expect("mac_addr add 0 %s" % self.vf1_mac, "testpmd>")
         self.session_secondary.send_expect("set fwd rxonly", "testpmd>")
         self.session_secondary.send_expect("set promisc all off", "testpmd>")
         self.session_secondary.send_expect("start", "testpmd>")
         time.sleep(2)
 
-        self.pmdout_3.start_testpmd("Default", prefix="test3", ports=[self.sriov_vfs_port[2].pci], param="--eth-peer=0,%s" % self.vf1_mac)
+        self.pmdout_3.start_testpmd(self.cores_vf2, prefix="test3", ports=[self.sriov_vfs_port[2].pci], param="--eth-peer=0,%s" % self.vf1_mac)
         self.session_third.send_expect("set fwd txonly", "testpmd>")
         self.session_third.send_expect("set promisc all off", "testpmd>")
         self.session_third.send_expect("start", "testpmd>")
@@ -602,12 +608,12 @@ class TestFloatingVEBSwitching(TestCase):
         time.sleep(2)
 
         # PF link down, VF2->VF1
-        self.pmdout_2.start_testpmd("Default", prefix="test2", ports=[self.sriov_vfs_port[1].pci])
+        self.pmdout_2.start_testpmd(self.cores_vf1, prefix="test2", ports=[self.sriov_vfs_port[1].pci])
         self.session_secondary.send_expect("mac_addr add 0 %s" % self.vf1_mac, "testpmd>")
         self.session_secondary.send_expect("set fwd rxonly", "testpmd>")
         self.session_secondary.send_expect("set promisc all off", "testpmd>")
 
-        self.pmdout_3.start_testpmd("Default", prefix="test3", ports=[self.sriov_vfs_port[2].pci], param="--eth-peer=0,%s" % self.vf1_mac)
+        self.pmdout_3.start_testpmd(self.cores_vf2, prefix="test3", ports=[self.sriov_vfs_port[2].pci], param="--eth-peer=0,%s" % self.vf1_mac)
         self.session_third.send_expect("set fwd txonly", "testpmd>")
         self.session_third.send_expect("set promisc all off", "testpmd>")
         
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:use differents cores between vf to vf
  2020-12-29  1:57 [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use differents cores between vf to vf Xie wei
@ 2020-12-29  1:57 ` Xie wei
  2020-12-29  1:58   ` Xie, WeiX
  2020-12-29  1:58 ` [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use " Xie, WeiX
  2020-12-29  2:13 ` Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: Xie wei @ 2020-12-29  1:57 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

If several testpmd are started at the same time for vfs, the rx_stats scale between vf to vf are quite different.
So different cores should be used.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_veb_switch.py | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/tests/TestSuite_veb_switch.py b/tests/TestSuite_veb_switch.py
index 81894782..00dd76e7 100644
--- a/tests/TestSuite_veb_switch.py
+++ b/tests/TestSuite_veb_switch.py
@@ -182,6 +182,10 @@ class TestVEBSwitching(TestCase):
         self.pf_mac_address = self.dut.get_mac_address(0)
         self.pf_pci = self.dut.ports_info[self.used_dut_port]['pci']
 
+        self.dut.init_reserved_core()
+        self.cores_vf0 = self.dut.get_reserved_core('2C', 0)
+        self.cores_vf1 = self.dut.get_reserved_core('2C', 0)
+
     def set_up(self):
         """
         This is to clear up environment before the case run.
@@ -239,13 +243,10 @@ class TestVEBSwitching(TestCase):
         the packets. Check Inter VF-VF MAC switch.
         """
         self.setup_env(driver='default')
-        self.dut.init_reserved_core()
-        cores_vf1 = self.dut.get_reserved_core('2C',0)
-        self.pmdout.start_testpmd(cores_vf1, prefix="test1", ports=[self.sriov_vfs_port[0].pci], param="--eth-peer=0,%s" % self.vf1_mac)
+        self.pmdout.start_testpmd(self.cores_vf0, prefix="test1", ports=[self.sriov_vfs_port[0].pci], param="--eth-peer=0,%s" % self.vf1_mac)
         self.dut.send_expect("set fwd txonly", "testpmd>")
         self.dut.send_expect("set promisc all off", "testpmd>")
-        cores_vf2 = self.dut.get_reserved_core('2C',0)
-        self.pmdout_2.start_testpmd(cores_vf2, prefix="test2", ports=[self.sriov_vfs_port[1].pci])
+        self.pmdout_2.start_testpmd(self.cores_vf1, prefix="test2", ports=[self.sriov_vfs_port[1].pci])
         self.session_secondary.send_expect("set fwd rxonly", "testpmd>")
         self.session_secondary.send_expect("set promisc all off", "testpmd>")
         self.session_secondary.send_expect("start", "testpmd>", 5)
@@ -458,12 +459,12 @@ class TestVEBSwitching(TestCase):
         self.pmdout.start_testpmd("Default", prefix="test1", ports=[self.pf_pci])
         self.dut.send_expect("set promisc all off", "testpmd>")
 
-        self.pmdout_2.start_testpmd("Default", prefix="test2", ports=[self.sriov_vfs_port[0].pci], param="--eth-peer=0,%s" % self.vf1_mac)
+        self.pmdout_2.start_testpmd(self.cores_vf0, prefix="test2", ports=[self.sriov_vfs_port[0].pci], param="--eth-peer=0,%s" % self.vf1_mac)
         self.session_secondary.send_expect("set fwd txonly", "testpmd>")
         self.session_secondary.send_expect("set promisc all off", "testpmd>")
         time.sleep(2)
 
-        self.pmdout_3.start_testpmd("Default", prefix="test3", ports=[self.sriov_vfs_port[1].pci])
+        self.pmdout_3.start_testpmd(self.cores_vf1, prefix="test3", ports=[self.sriov_vfs_port[1].pci])
         self.session_third.send_expect("mac_addr add 0 %s" % self.vf1_mac, "testpmd>")
         self.session_third.send_expect("set fwd rxonly", "testpmd>")
         self.session_third.send_expect("set promisc all off", "testpmd>")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use differents cores between vf to vf
  2020-12-29  1:57 [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use differents cores between vf to vf Xie wei
  2020-12-29  1:57 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:use " Xie wei
@ 2020-12-29  1:58 ` Xie, WeiX
  2020-12-29  2:13 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Xie, WeiX @ 2020-12-29  1:58 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Tuesday, December 29, 2020 9:57 AM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V1 1/2] tests/TestSuite_floating_veb:use differents
> cores between vf to vf

[-- Attachment #2: TestFloatingVEBSwitching.log --]
[-- Type: application/octet-stream, Size: 33169 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:use differents cores between vf to vf
  2020-12-29  1:57 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:use " Xie wei
@ 2020-12-29  1:58   ` Xie, WeiX
  0 siblings, 0 replies; 5+ messages in thread
From: Xie, WeiX @ 2020-12-29  1:58 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Tuesday, December 29, 2020 9:57 AM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V1 2/2] tests/TestSuite_veb_switch:use differents
> cores between vf to vf

[-- Attachment #2: TestVEBSwitching.log --]
[-- Type: application/octet-stream, Size: 2133708 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use differents cores between vf to vf
  2020-12-29  1:57 [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use differents cores between vf to vf Xie wei
  2020-12-29  1:57 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:use " Xie wei
  2020-12-29  1:58 ` [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use " Xie, WeiX
@ 2020-12-29  2:13 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-12-29  2:13 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

> If several testpmd are started at the same time for vfs, the rx_stats scale
> between vf to vf are quite different.
> So different cores should be used.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>

Applied the series.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-29  2:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29  1:57 [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use differents cores between vf to vf Xie wei
2020-12-29  1:57 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:use " Xie wei
2020-12-29  1:58   ` Xie, WeiX
2020-12-29  1:58 ` [dts] [PATCH V1 1/2] tests/TestSuite_floating_veb:use " Xie, WeiX
2020-12-29  2:13 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git