test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] tests/vhost_user_interrupt:modify execute virtio-user server side testpmd command after client side started
  2021-02-02 14:37 [dts] [PATCH V1] tests/vhost_user_interrupt:modify execute virtio-user server side testpmd command after client side started Ling Wei
@ 2021-02-02  6:46 ` Ling, WeiX
  2021-02-02 13:48   ` Wang, Yinan
  2021-02-03  6:27 ` Tu, Lijuan
  1 sibling, 1 reply; 4+ messages in thread
From: Ling, WeiX @ 2021-02-02  6:46 UTC (permalink / raw)
  To: Ling, WeiX, dts

[-- Attachment #1: Type: text/plain, Size: 3739 bytes --]

Tested-by: Wei Ling <weix.ling@intel.com>

Regards,
Ling Wei

> -----Original Message-----
> From: Ling Wei <weix.ling@intel.com>
> Sent: Tuesday, February 2, 2021 10:37 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V1] tests/vhost_user_interrupt:modify execute virtio-
> user server side testpmd command after client side started
> 
> In DPDK 9af79db20f4cf, when launch virtio-user testpmd as server mode,
> virtio-user server side testpmd expected character will be 'wait for client side
> started...', after client side started, it change to 'testpmd>', so dts need
> modify execute virtio-user server side testpmd command after client side
> started.
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>
> ---
>  tests/TestSuite_vhost_user_interrupt.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_vhost_user_interrupt.py
> b/tests/TestSuite_vhost_user_interrupt.py
> index bc340c4..2a10199 100644
> --- a/tests/TestSuite_vhost_user_interrupt.py
> +++ b/tests/TestSuite_vhost_user_interrupt.py
> @@ -108,8 +108,7 @@ class TestVhostUserInterrupt(TestCase):
>              eal_params += " --single-file-segments"
>          para = " -- -i --rxq=%d --txq=%d --rss-ip" % (self.queues, self.queues)
>          command_line_client =  self.app_testpmd_path + " " + eal_params +
> para
> -        self.virtio_user.send_expect(command_line_client, "testpmd> ", 120)
> -        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
> +        self.virtio_user.send_expect(command_line_client, "waiting for
> + client connection...", 120)
> 
>      def get_cbdma_ports_info_and_bind_to_dpdk(self, cbdma_num):
>          """
> @@ -231,6 +230,7 @@ class TestVhostUserInterrupt(TestCase):
>          self.get_core_list()
>          self.lanuch_virtio_user()
>          self.lanuch_l3fwd_power()
> +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
>          self.send_and_verify()
> 
>      def
> test_wake_up_split_ring_vhost_user_core_with_l3fwd_power_sample_wh
> en_multi_queues_enabled(self):
> @@ -241,6 +241,7 @@ class TestVhostUserInterrupt(TestCase):
>          self.get_core_list()
>          self.lanuch_virtio_user()
>          self.lanuch_l3fwd_power()
> +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
>          self.send_and_verify()
> 
>      def
> test_wake_up_packed_ring_vhost_user_core_with_l3fwd_power_sample(
> self):
> @@ -251,6 +252,7 @@ class TestVhostUserInterrupt(TestCase):
>          self.get_core_list()
>          self.lanuch_virtio_user(packed=True)
>          self.lanuch_l3fwd_power()
> +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
>          self.send_and_verify()
> 
>      def
> test_wake_up_packed_ring_vhost_user_core_with_l3fwd_power_sample_
> when_multi_queues_enabled(self):
> @@ -261,6 +263,7 @@ class TestVhostUserInterrupt(TestCase):
>          self.get_core_list()
>          self.lanuch_virtio_user(packed=True)
>          self.lanuch_l3fwd_power()
> +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
>          self.send_and_verify()
> 
>      def
> test_wake_up_split_ring_vhost_user_core_with_l3fwd_power_sample_wh
> en_multi_queues_enabled_and_cbdma_enabled(self):
> @@ -271,6 +274,7 @@ class TestVhostUserInterrupt(TestCase):
>          self.get_core_list()
>          self.lanuch_virtio_user(cbdma=True)
>          self.lanuch_l3fwd_power(cbdma=True)
> +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
>          self.send_and_verify()
> 
>      def tear_down(self):
> --
> 2.25.1


[-- Attachment #2: TestVhostUserInterrupt.log --]
[-- Type: application/octet-stream, Size: 41729 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vhost_user_interrupt:modify execute virtio-user server side testpmd command after client side started
  2021-02-02  6:46 ` Ling, WeiX
@ 2021-02-02 13:48   ` Wang, Yinan
  0 siblings, 0 replies; 4+ messages in thread
From: Wang, Yinan @ 2021-02-02 13:48 UTC (permalink / raw)
  To: Ling, WeiX, Ling, WeiX, dts

Acked-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling, WeiX
> Sent: 2021?2?2? 14:46
> To: Ling, WeiX <weix.ling@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/vhost_user_interrupt:modify execute
> virtio-user server side testpmd command after client side started
> 
> Tested-by: Wei Ling <weix.ling@intel.com>
> 
> Regards,
> Ling Wei
> 
> > -----Original Message-----
> > From: Ling Wei <weix.ling@intel.com>
> > Sent: Tuesday, February 2, 2021 10:37 PM
> > To: dts@dpdk.org
> > Cc: Ling, WeiX <weix.ling@intel.com>
> > Subject: [dts][PATCH V1] tests/vhost_user_interrupt:modify execute virtio-
> > user server side testpmd command after client side started
> >
> > In DPDK 9af79db20f4cf, when launch virtio-user testpmd as server mode,
> > virtio-user server side testpmd expected character will be 'wait for client
> side
> > started...', after client side started, it change to 'testpmd>', so dts need
> > modify execute virtio-user server side testpmd command after client side
> > started.
> >
> > Signed-off-by: Ling Wei <weix.ling@intel.com>
> > ---
> >  tests/TestSuite_vhost_user_interrupt.py | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/TestSuite_vhost_user_interrupt.py
> > b/tests/TestSuite_vhost_user_interrupt.py
> > index bc340c4..2a10199 100644
> > --- a/tests/TestSuite_vhost_user_interrupt.py
> > +++ b/tests/TestSuite_vhost_user_interrupt.py
> > @@ -108,8 +108,7 @@ class TestVhostUserInterrupt(TestCase):
> >              eal_params += " --single-file-segments"
> >          para = " -- -i --rxq=%d --txq=%d --rss-ip" % (self.queues, self.queues)
> >          command_line_client =  self.app_testpmd_path + " " + eal_params +
> > para
> > -        self.virtio_user.send_expect(command_line_client, "testpmd> ", 120)
> > -        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
> > +        self.virtio_user.send_expect(command_line_client, "waiting for
> > + client connection...", 120)
> >
> >      def get_cbdma_ports_info_and_bind_to_dpdk(self, cbdma_num):
> >          """
> > @@ -231,6 +230,7 @@ class TestVhostUserInterrupt(TestCase):
> >          self.get_core_list()
> >          self.lanuch_virtio_user()
> >          self.lanuch_l3fwd_power()
> > +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
> >          self.send_and_verify()
> >
> >      def
> > test_wake_up_split_ring_vhost_user_core_with_l3fwd_power_sample_wh
> > en_multi_queues_enabled(self):
> > @@ -241,6 +241,7 @@ class TestVhostUserInterrupt(TestCase):
> >          self.get_core_list()
> >          self.lanuch_virtio_user()
> >          self.lanuch_l3fwd_power()
> > +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
> >          self.send_and_verify()
> >
> >      def
> > test_wake_up_packed_ring_vhost_user_core_with_l3fwd_power_sample(
> > self):
> > @@ -251,6 +252,7 @@ class TestVhostUserInterrupt(TestCase):
> >          self.get_core_list()
> >          self.lanuch_virtio_user(packed=True)
> >          self.lanuch_l3fwd_power()
> > +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
> >          self.send_and_verify()
> >
> >      def
> > test_wake_up_packed_ring_vhost_user_core_with_l3fwd_power_sample_
> > when_multi_queues_enabled(self):
> > @@ -261,6 +263,7 @@ class TestVhostUserInterrupt(TestCase):
> >          self.get_core_list()
> >          self.lanuch_virtio_user(packed=True)
> >          self.lanuch_l3fwd_power()
> > +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
> >          self.send_and_verify()
> >
> >      def
> > test_wake_up_split_ring_vhost_user_core_with_l3fwd_power_sample_wh
> > en_multi_queues_enabled_and_cbdma_enabled(self):
> > @@ -271,6 +274,7 @@ class TestVhostUserInterrupt(TestCase):
> >          self.get_core_list()
> >          self.lanuch_virtio_user(cbdma=True)
> >          self.lanuch_l3fwd_power(cbdma=True)
> > +        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
> >          self.send_and_verify()
> >
> >      def tear_down(self):
> > --
> > 2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] tests/vhost_user_interrupt:modify execute virtio-user server side testpmd command after client side started
@ 2021-02-02 14:37 Ling Wei
  2021-02-02  6:46 ` Ling, WeiX
  2021-02-03  6:27 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Ling Wei @ 2021-02-02 14:37 UTC (permalink / raw)
  To: dts; +Cc: Ling Wei

In DPDK 9af79db20f4cf, when launch virtio-user testpmd as server mode,
virtio-user server side testpmd expected character will be
'wait for client side started...', after client side started,
it change to 'testpmd>', so dts need modify execute virtio-user
server side testpmd command after client side started.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_vhost_user_interrupt.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_vhost_user_interrupt.py b/tests/TestSuite_vhost_user_interrupt.py
index bc340c4..2a10199 100644
--- a/tests/TestSuite_vhost_user_interrupt.py
+++ b/tests/TestSuite_vhost_user_interrupt.py
@@ -108,8 +108,7 @@ class TestVhostUserInterrupt(TestCase):
             eal_params += " --single-file-segments"
         para = " -- -i --rxq=%d --txq=%d --rss-ip" % (self.queues, self.queues)
         command_line_client =  self.app_testpmd_path + " " + eal_params + para
-        self.virtio_user.send_expect(command_line_client, "testpmd> ", 120)
-        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
+        self.virtio_user.send_expect(command_line_client, "waiting for client connection...", 120)
 
     def get_cbdma_ports_info_and_bind_to_dpdk(self, cbdma_num):
         """
@@ -231,6 +230,7 @@ class TestVhostUserInterrupt(TestCase):
         self.get_core_list()
         self.lanuch_virtio_user()
         self.lanuch_l3fwd_power()
+        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
         self.send_and_verify()
 
     def test_wake_up_split_ring_vhost_user_core_with_l3fwd_power_sample_when_multi_queues_enabled(self):
@@ -241,6 +241,7 @@ class TestVhostUserInterrupt(TestCase):
         self.get_core_list()
         self.lanuch_virtio_user()
         self.lanuch_l3fwd_power()
+        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
         self.send_and_verify()
 
     def test_wake_up_packed_ring_vhost_user_core_with_l3fwd_power_sample(self):
@@ -251,6 +252,7 @@ class TestVhostUserInterrupt(TestCase):
         self.get_core_list()
         self.lanuch_virtio_user(packed=True)
         self.lanuch_l3fwd_power()
+        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
         self.send_and_verify()
 
     def test_wake_up_packed_ring_vhost_user_core_with_l3fwd_power_sample_when_multi_queues_enabled(self):
@@ -261,6 +263,7 @@ class TestVhostUserInterrupt(TestCase):
         self.get_core_list()
         self.lanuch_virtio_user(packed=True)
         self.lanuch_l3fwd_power()
+        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
         self.send_and_verify()
 
     def test_wake_up_split_ring_vhost_user_core_with_l3fwd_power_sample_when_multi_queues_enabled_and_cbdma_enabled(self):
@@ -271,6 +274,7 @@ class TestVhostUserInterrupt(TestCase):
         self.get_core_list()
         self.lanuch_virtio_user(cbdma=True)
         self.lanuch_l3fwd_power(cbdma=True)
+        self.virtio_user.send_expect("set fwd txonly", "testpmd> ", 20)
         self.send_and_verify()
 
     def tear_down(self):
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] tests/vhost_user_interrupt:modify execute virtio-user server side testpmd command after client side started
  2021-02-02 14:37 [dts] [PATCH V1] tests/vhost_user_interrupt:modify execute virtio-user server side testpmd command after client side started Ling Wei
  2021-02-02  6:46 ` Ling, WeiX
@ 2021-02-03  6:27 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-02-03  6:27 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX

> In DPDK 9af79db20f4cf, when launch virtio-user testpmd as server mode, virtio-
> user server side testpmd expected character will be 'wait for client side
> started...', after client side started, it change to 'testpmd>', so dts need modify
> execute virtio-user server side testpmd command after client side started.
> 
> Signed-off-by: Ling Wei <weix.ling@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-03  6:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 14:37 [dts] [PATCH V1] tests/vhost_user_interrupt:modify execute virtio-user server side testpmd command after client side started Ling Wei
2021-02-02  6:46 ` Ling, WeiX
2021-02-02 13:48   ` Wang, Yinan
2021-02-03  6:27 ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git