RE: [dts] [PATCH V3 2/2] test_plans/multiprocess: add 1 case

RE: [dts] [PATCH V3 2/2] test_plans/multiprocess: add 1 case

[Ling, Jin]

> -----Original Message-----
> From: Jiale, SongX <songx.jiale@intel.com>
> Sent: 2022年12月31日 2:28
> To: dts@dpdk.org
> Cc: Jiale, SongX <songx.jiale@intel.com>; Ling, Jin <jin.ling@intel.com>
> Subject: [dts] [PATCH V3 2/2] test_plans/multiprocess: add 1 case
> 
> add a case to test the testpmd secondary process crash of the pf port.
> 
> Signed-off-by: Jin Ling <jin.ling@intel.com>
> Signed-off-by: Song Jiale <songx.jiale@intel.com>
> ---
> 
> v3:
> -redesign testplan
> 
>  test_plans/multiprocess_test_plan.rst | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
Acked-by: Jin Ling <jin.ling@intel.com>

[dts] [PATCH V3 1/2] tests/multiprocess: add new case according to testplan

[Song Jiale]

add 1 case according to testplan.

Signed-off-by: Song Jiale <songx.jiale@intel.com>
---

v3:
-rework the test case according to the new testplan

 tests/TestSuite_multiprocess.py | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_multiprocess.py b/tests/TestSuite_multiprocess.py
index 4fdc8c27..099ce6e7 100644
--- a/tests/TestSuite_multiprocess.py
+++ b/tests/TestSuite_multiprocess.py
@@ -1691,6 +1691,29 @@ class TestMultiprocess(TestCase):
         }
         self.rte_flow(mac_ipv4_symmetric, self.multiprocess_rss_data, **pmd_param)
 
+    def test_multiprocess_negative_action(self):
+        """
+        Test Case: test_multiprocess_negative_action
+
+        """
+        # start testpmd multi-process
+        self.launch_multi_testpmd(
+            proc_type="auto",
+            queue_num=4,
+            process_num=2,
+        )
+        for pmd_output in self.pmd_output_list:
+            pmd_output.execute_cmd("stop")
+        # set secondary process port stop
+        try:
+            self.pmd_output_list[1].execute_cmd("port stop 0")
+            self.pmd_output_list[1].execute_cmd("port reset 0")
+        except Exception as ex:
+            out = self.pmd_output_list[1].get_output()
+            self.verify(
+                "core dump" not in out, "Core dump occurred in the secondary process!!!"
+            )
+
     def test_perf_multiprocess_performance(self):
         """
         Benchmark Multiprocess performance.
@@ -1926,4 +1949,3 @@ class TestMultiprocess(TestCase):
         Run after each test suite.
         """
         self.dut.kill_all()
-        pass
-- 
2.25.1

[dts] [PATCH V3 2/2] test_plans/multiprocess: add 1 case

[Song Jiale]

add a case to test the testpmd secondary process crash of the pf port.

Signed-off-by: Jin Ling <jin.ling@intel.com>
Signed-off-by: Song Jiale <songx.jiale@intel.com>
---

v3:
-redesign testplan

 test_plans/multiprocess_test_plan.rst | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/test_plans/multiprocess_test_plan.rst b/test_plans/multiprocess_test_plan.rst
index bfef1ca9..d3e60d9e 100644
--- a/test_plans/multiprocess_test_plan.rst
+++ b/test_plans/multiprocess_test_plan.rst
@@ -969,3 +969,26 @@ Test Case: test_multiprocess_negative_exceed_process_num
     the first and second processes should be launched successfully
     the third process should be launched failed and output should contain the following string:
     'multi-process option proc-id(2) should be less than num-procs(2)'
+
+Test Case: test_multiprocess_negative_action
+============================================
+Subcase 1: test_secondary_process_port_reset
+--------------------------------------------
+test steps
+~~~~~~~~~~
+
+1. Launch the app ``testpmd``, start primary process and secondary process with the following arguments::
+
+   ./dpdk-testpmd -l 1,2 --proc-type=auto -a 0000:17:00.0  --log-level=ice,7 -- -i  --rxq=4 --txq=4 --num-procs=2 --proc-id=0
+   ./dpdk-testpmd -l 3,4 --proc-type=auto -a 0000:17:00.0  --log-level=ice,7 -- -i  --rxq=4 --txq=4 --num-procs=2 --proc-id=1
+
+2. reset port in secondary process::
+
+    secondary process:
+      testpmd> port stop 0
+      testpmd> port reset 0
+
+expected result
+~~~~~~~~~~
+
+   Check that there are no ``core dump`` messages in the output.
\ No newline at end of file
-- 
2.25.1

[dts] [PATCH V3 2/2] test_plans/multiprocess: add 1 case

[lijuan.tu]

On Fri, 30 Dec 2022 18:28:10 +0000, Song Jiale <songx.jiale@intel.com> wrote:
> add a case to test the testpmd secondary process crash of the pf port.
> 
> Signed-off-by: Jin Ling <jin.ling@intel.com>
> Signed-off-by: Song Jiale <songx.jiale@intel.com>

Acked-by: Lijuan Tu <lijuan.tu@intel.com>
Series applied, thanks

[dts] [PATCH V3 2/2] test_plans/multiprocess: add 1 case

[Song Jiale]

add a case to test the testpmd secondary process crash of the pf port.

Signed-off-by: Jin Ling <jin.ling@intel.com>
Signed-off-by: Song Jiale <songx.jiale@intel.com>
---

v3:
-redesign testplan

 tests/TestSuite_multiprocess_iavf.py | 46 +++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_multiprocess_iavf.py b/tests/TestSuite_multiprocess_iavf.py
index bb8e0c98..c52bfa9c 100644
--- a/tests/TestSuite_multiprocess_iavf.py
+++ b/tests/TestSuite_multiprocess_iavf.py
@@ -476,7 +476,7 @@ class TestMultiprocessIavf(TestCase):
         )
         pkt_num = kwargs.get("pkt_num")
         res = self.get_pkt_statistic(out, **kwargs)
-        res_num = res["rx-total"]
+        res_num = res["rx-packets"]
         self.verify(
             res_num == pkt_num,
             "fail: got wrong number of packets, expect pakcet number {}, got {}".format(
@@ -1068,6 +1068,7 @@ class TestMultiprocessIavf(TestCase):
             r"Port \d+\s+-\s+rx:\s+(?P<rx>\d+)\s+tx:.*PORTS", out, re.DOTALL
         )
         rx_num = re.findall(r"Client\s+\d\s+-\s+rx:\s+(\d+)", res.group(0))
+        rx_num.sort(reverse=True)
         for i in range(proc_num):
             self.verify(
                 int(rx_num[i]) > 0,
@@ -1677,6 +1678,49 @@ class TestMultiprocessIavf(TestCase):
         }
         self.rte_flow(mac_ipv4_symmetric, self.multiprocess_rss_data, **pmd_param)
 
+    def test_multiprocess_negative_action(self):
+        """
+        Test Case: test_multiprocess_negative_action
+
+        """
+        # start testpmd multi-process
+        self.launch_multi_testpmd(
+            proc_type="auto",
+            queue_num=4,
+            process_num=2,
+        )
+        for pmd_output in self.pmd_output_list:
+            pmd_output.execute_cmd("stop")
+        # set primary process port stop
+        try:
+            self.pmd_output_list[0].execute_cmd("port stop 0")
+        except Exception as ex:
+            out = ex.output
+            self.logger.error(out)
+            self.verify(
+                "core dump" not in out, "Core dump occurred in the primary process!!!"
+            )
+        for pmd_output in self.pmd_output_list:
+            pmd_output.quit()
+        # start testpmd multi-process
+        self.launch_multi_testpmd(
+            proc_type="auto",
+            queue_num=4,
+            process_num=2,
+        )
+        for pmd_output in self.pmd_output_list:
+            pmd_output.execute_cmd("stop")
+        # reset port in secondary process
+        try:
+            self.pmd_output_list[1].execute_cmd("port stop 0")
+            self.pmd_output_list[1].execute_cmd("port reset 0")
+        except Exception as ex:
+            out = ex.output
+            self.logger.error(out)
+            self.verify(
+                "core dump" not in out, "Core dump occurred in the second process!!!"
+            )
+
     def set_fields(self):
         """set ip protocol field behavior"""
         fields_config = {
-- 
2.25.1