From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Peng, Yuan" <yuan.peng@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dts] [PATCH] tests: Correct some format errors
Date: Tue, 15 Jan 2019 06:10:36 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BA02A07@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1547195681-27164-1-git-send-email-yuan.peng@intel.com>
Applied, thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Yuan
> Sent: Friday, January 11, 2019 4:35 PM
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>
> Subject: [dts] [PATCH] tests: Correct some format errors
>
> Correct some format errors for TestSuite_jumboframes.py
>
> Signed-off-by: Peng Yuan <yuan.peng@intel.com>
>
> diff --git a/tests/TestSuite_jumboframes.py b/tests/TestSuite_jumboframes.py
> index b3d53d8..cbb284d 100644
> --- a/tests/TestSuite_jumboframes.py
> +++ b/tests/TestSuite_jumboframes.py
> @@ -84,7 +84,6 @@ class TestJumboframes(TestCase):
> sleep(5)
>
> tx_pkts, _, tx_bytes = [int(_) for _ in self.jumboframes_get_stat(self.rx_port,
> "tx")]
> - # p0tx_pkts, p0tx_err, p0tx_bytes
> rx_pkts, rx_err, rx_bytes = [int(_) for _ in
> self.jumboframes_get_stat(self.tx_port, "rx")]
>
> tx_pkts -= tx_pkts_ori
> @@ -99,7 +98,6 @@ class TestJumboframes(TestCase):
> and ((rx_bytes + 4) == pktsize),
> "packet pass assert error")
> else:
> - #self.verify(p0tx_pkts == p1rx_pkts and (p1rx_err == 1 or p1rx_pkts == 0),
> self.verify(rx_err == 1 or tx_pkts == 0, "packet drop assert error")
> return out
>
> @@ -129,7 +127,6 @@ class TestJumboframes(TestCase):
> netobj.enable_jumbo(framesize = ETHER_JUMBO_FRAME_MTU)
>
> self.tester.send_expect("ifconfig %s mtu %s" %
> (self.tester.get_interface(self.tester.get_local_port(self.rx_port)),
> ETHER_JUMBO_FRAME_MTU + 200), "# ")
> -# self.tester.send_expect("ifconfig %s mtu %s" %
> (self.tester.get_interface(self.tester.get_local_port(self.tx_port)),
> ETHER_JUMBO_FRAME_MTU + 200), "# ")
>
> self.pmdout = PmdOutput(self.dut)
>
> @@ -181,8 +178,8 @@ class TestJumboframes(TestCase):
> self.dut.send_expect("set fwd mac", "testpmd> ")
> self.dut.send_expect("start", "testpmd> ")
>
> - self.jumboframes_send_packet(1517)
> - self.jumboframes_send_packet(1518)
> + self.jumboframes_send_packet(ETHER_STANDARD_MTU - 1)
> + self.jumboframes_send_packet(ETHER_STANDARD_MTU)
>
> self.dut.send_expect("stop", "testpmd> ")
> self.dut.send_expect("quit", "# ", 30) @@ -234,4 +231,3 @@ class
> TestJumboframes(TestCase):
> clear up.
> """
> self.tester.send_expect("ifconfig %s mtu %s" %
> (self.tester.get_interface(self.tester.get_local_port(self.rx_port)),
> ETHER_STANDARD_MTU), "# ")
> - self.tester.send_expect("ifconfig %s mtu %s" %
> (self.tester.get_interface(self.tester.get_local_port(self.tx_port)),
> ETHER_STANDARD_MTU), "# ")
> --
> 2.5.0
prev parent reply other threads:[~2019-01-15 6:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:34 Peng Yuan
2019-01-15 6:10 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BA02A07@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).