test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/unit_test_loopback: add '-j' option to 'make'
@ 2019-07-01 16:29 Wenjie Li
  2019-07-03  5:52 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Wenjie Li @ 2019-07-01 16:29 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

"make" takes more time, sometimes it is over 120 seconds.
Using "make -j" could save time.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_unit_tests_loopback.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_unit_tests_loopback.py b/tests/TestSuite_unit_tests_loopback.py
index ad49e8a..50533a6 100644
--- a/tests/TestSuite_unit_tests_loopback.py
+++ b/tests/TestSuite_unit_tests_loopback.py
@@ -92,7 +92,7 @@ class TestUnitTestsLoopback(TestCase):
         """
         self.dut.send_expect("sed -i -e 's/lpbk_mode = 0/lpbk_mode = 1/' app/test/test_pmd_perf.c", "# ", 30)
         self.dut.send_expect("cd app/test", "# ")
-        self.dut.send_expect("make", "# ", 120)
+        self.dut.send_expect("make -j", "# ", 120)
         self.dut.send_expect("cd /root/dpdk", "# ")
 
         self.tester.send_expect("rm -rf ./getPackageByTcpdump.cap", "#")
@@ -113,7 +113,7 @@ class TestUnitTestsLoopback(TestCase):
         """
         self.dut.send_expect("sed -i -e 's/lpbk_mode = 1/lpbk_mode = 0/' app/test/test_pmd_perf.c", "# ", 30)
         self.dut.send_expect("cd app/test", "# ")
-        self.dut.send_expect("make", "# ", 120)
+        self.dut.send_expect("make -j", "# ", 120)
         self.dut.send_expect("cd /root/dpdk", "# ")
 
         self.tester.send_expect("rm -rf ./getPackageByTcpdump.cap", "#")
@@ -140,6 +140,6 @@ class TestUnitTestsLoopback(TestCase):
         self.dut.send_expect("sed -i -e 's/lpbk_mode = 0/lpbk_mode = 1/' app/test/test_pmd_perf.c", "# ", 30)
         self.dut.send_expect("sed -i -e 's/#define MAX_TRAFFIC_BURST              32/#define MAX_TRAFFIC_BURST              %s/' app/test/test_pmd_perf.c" % self.max_traffic_burst, "# ", 30)
         self.dut.send_expect("cd app/test", "# ")
-        self.dut.send_expect("make", "# ", 120)
+        self.dut.send_expect("make -j", "# ", 120)
         self.dut.send_expect("cd /root/dpdk", "# ")
         self.dut.kill_all()
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/unit_test_loopback: add '-j' option to 'make'
  2019-07-01 16:29 [dts] [PATCH V1] tests/unit_test_loopback: add '-j' option to 'make' Wenjie Li
@ 2019-07-03  5:52 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-07-03  5:52 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Tuesday, July 2, 2019 12:30 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/unit_test_loopback: add '-j' option to 'make'
> 
> "make" takes more time, sometimes it is over 120 seconds.
> Using "make -j" could save time.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_unit_tests_loopback.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_unit_tests_loopback.py
> b/tests/TestSuite_unit_tests_loopback.py
> index ad49e8a..50533a6 100644
> --- a/tests/TestSuite_unit_tests_loopback.py
> +++ b/tests/TestSuite_unit_tests_loopback.py
> @@ -92,7 +92,7 @@ class TestUnitTestsLoopback(TestCase):
>          """
>          self.dut.send_expect("sed -i -e 's/lpbk_mode = 0/lpbk_mode = 1/'
> app/test/test_pmd_perf.c", "# ", 30)
>          self.dut.send_expect("cd app/test", "# ")
> -        self.dut.send_expect("make", "# ", 120)
> +        self.dut.send_expect("make -j", "# ", 120)
>          self.dut.send_expect("cd /root/dpdk", "# ")
> 
>          self.tester.send_expect("rm -rf ./getPackageByTcpdump.cap", "#") @@ -
> 113,7 +113,7 @@ class TestUnitTestsLoopback(TestCase):
>          """
>          self.dut.send_expect("sed -i -e 's/lpbk_mode = 1/lpbk_mode = 0/'
> app/test/test_pmd_perf.c", "# ", 30)
>          self.dut.send_expect("cd app/test", "# ")
> -        self.dut.send_expect("make", "# ", 120)
> +        self.dut.send_expect("make -j", "# ", 120)
>          self.dut.send_expect("cd /root/dpdk", "# ")
> 
>          self.tester.send_expect("rm -rf ./getPackageByTcpdump.cap", "#") @@ -
> 140,6 +140,6 @@ class TestUnitTestsLoopback(TestCase):
>          self.dut.send_expect("sed -i -e 's/lpbk_mode = 0/lpbk_mode = 1/'
> app/test/test_pmd_perf.c", "# ", 30)
>          self.dut.send_expect("sed -i -e 's/#define MAX_TRAFFIC_BURST
> 32/#define MAX_TRAFFIC_BURST              %s/' app/test/test_pmd_perf.c" %
> self.max_traffic_burst, "# ", 30)
>          self.dut.send_expect("cd app/test", "# ")
> -        self.dut.send_expect("make", "# ", 120)
> +        self.dut.send_expect("make -j", "# ", 120)
>          self.dut.send_expect("cd /root/dpdk", "# ")
>          self.dut.kill_all()
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-03  5:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01 16:29 [dts] [PATCH V1] tests/unit_test_loopback: add '-j' option to 'make' Wenjie Li
2019-07-03  5:52 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).