test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in the verification condition.
  2019-06-27  7:14 [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in the verification condition zhu,shuai
@ 2019-06-27  7:10 ` Zhu, WenhuiX
  2019-07-03  6:15 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-06-27  7:10 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
Sent: Thursday, June 27, 2019 3:14 PM
To: dts@dpdk.org
Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
Subject: [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in the verification condition.

Since the current number of packets is 4, the verification conditions are not met, and the number of packets in the verification condition is modified.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_mac_filter.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py index 9b896b4..a28bf9a 100644
--- a/tests/TestSuite_mac_filter.py
+++ b/tests/TestSuite_mac_filter.py
@@ -109,7 +109,7 @@ class TestMacFilter(TestCase):
         out = self.dut.get_session_output()
         cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets")
         # check the packet increase
-        self.verify(int(cur_rxpkt) == self.frames_to_send,
+        self.verify(int(cur_rxpkt)*self.frames_to_send == 
+ self.frames_to_send,
                     "Packet has not been received on default address")
 
         # send one packet to a different MAC address @@ -127,7 +127,7 @@ class TestMacFilter(TestCase):
         out = self.dut.get_session_output()
         cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets")
         # check the packet increase
-        self.verify(int(cur_rxpkt) == self.frames_to_send,
+        self.verify(int(cur_rxpkt)*self.frames_to_send == 
+ self.frames_to_send,
                     "Packet has not been received on a new MAC address that has been added to the port")
 
         # remove the fake MAC address
--
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in the verification condition.
@ 2019-06-27  7:14 zhu,shuai
  2019-06-27  7:10 ` Zhu, WenhuiX
  2019-07-03  6:15 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: zhu,shuai @ 2019-06-27  7:14 UTC (permalink / raw)
  To: dts; +Cc: zhu,shuai

Since the current number of packets is 4, the verification conditions are not met, and the number of packets in the verification condition is modified.

Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
---
 tests/TestSuite_mac_filter.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py
index 9b896b4..a28bf9a 100644
--- a/tests/TestSuite_mac_filter.py
+++ b/tests/TestSuite_mac_filter.py
@@ -109,7 +109,7 @@ class TestMacFilter(TestCase):
         out = self.dut.get_session_output()
         cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets")
         # check the packet increase
-        self.verify(int(cur_rxpkt) == self.frames_to_send,
+        self.verify(int(cur_rxpkt)*self.frames_to_send == self.frames_to_send,
                     "Packet has not been received on default address")
 
         # send one packet to a different MAC address
@@ -127,7 +127,7 @@ class TestMacFilter(TestCase):
         out = self.dut.get_session_output()
         cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets")
         # check the packet increase
-        self.verify(int(cur_rxpkt) == self.frames_to_send,
+        self.verify(int(cur_rxpkt)*self.frames_to_send == self.frames_to_send,
                     "Packet has not been received on a new MAC address that has been added to the port")
 
         # remove the fake MAC address
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in the verification condition.
  2019-06-27  7:14 [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in the verification condition zhu,shuai
  2019-06-27  7:10 ` Zhu, WenhuiX
@ 2019-07-03  6:15 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-07-03  6:15 UTC (permalink / raw)
  To: Zhu, ShuaiX, dts; +Cc: Zhu, ShuaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Thursday, June 27, 2019 3:14 PM
> To: dts@dpdk.org
> Cc: Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in
> the verification condition.
> 
> Since the current number of packets is 4, the verification conditions are not
> met, and the number of packets in the verification condition is modified.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_mac_filter.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_mac_filter.py b/tests/TestSuite_mac_filter.py
> index 9b896b4..a28bf9a 100644
> --- a/tests/TestSuite_mac_filter.py
> +++ b/tests/TestSuite_mac_filter.py
> @@ -109,7 +109,7 @@ class TestMacFilter(TestCase):
>          out = self.dut.get_session_output()
>          cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets")
>          # check the packet increase
> -        self.verify(int(cur_rxpkt) == self.frames_to_send,
> +        self.verify(int(cur_rxpkt)*self.frames_to_send ==
> + self.frames_to_send,
>                      "Packet has not been received on default address")
> 
>          # send one packet to a different MAC address @@ -127,7 +127,7 @@
> class TestMacFilter(TestCase):
>          out = self.dut.get_session_output()
>          cur_rxpkt = utils.regexp(out, "received ([0-9]+) packets")
>          # check the packet increase
> -        self.verify(int(cur_rxpkt) == self.frames_to_send,
> +        self.verify(int(cur_rxpkt)*self.frames_to_send ==
> + self.frames_to_send,
>                      "Packet has not been received on a new MAC address that has
> been added to the port")
> 
>          # remove the fake MAC address
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-03  6:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27  7:14 [dts] [PATCH V1] tests/mac_filter:Modify the number of packages in the verification condition zhu,shuai
2019-06-27  7:10 ` Zhu, WenhuiX
2019-07-03  6:15 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).