test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH 1/2] test_plans/generic_flow_api: correct i40e could support 0x88cc ether type packet
@ 2019-08-05 10:03 Lin Xueqin
  2019-08-06  8:51 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Lin Xueqin @ 2019-08-05 10:03 UTC (permalink / raw)
  To: dts; +Cc: Xueqin Lin

From: Xueqin Lin <xueqin.lin@intel.com>

Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>

---
 test_plans/generic_flow_api_test_plan.rst | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/test_plans/generic_flow_api_test_plan.rst b/test_plans/generic_flow_api_test_plan.rst
index f53e7c7..380d9e8 100644
--- a/test_plans/generic_flow_api_test_plan.rst
+++ b/test_plans/generic_flow_api_test_plan.rst
@@ -70,26 +70,24 @@ Test case: Fortville ethertype
     testpmd> flow validate 0 ingress pattern eth type is 0x88cc / end actions queue index 5 / end
     testpmd> flow create 0 ingress pattern eth type is 0x88cc / end actions queue index 6 / end
 
-   the i40e don't support the 0x88cc eth type packet. so the last two commands
-   failed.
-
 3. send packets::
 
     pkt1 = Ether(dst="ff:ff:ff:ff:ff:ff")/ARP(pdst="192.168.1.1")
     pkt2 = Ether(dst="00:11:22:33:44:55", type=0x88BB)/Raw('x' * 20)
     pkt3 = Ether(dst="00:11:22:33:44:55", type=0x88e5)/Raw('x' * 20)
     pkt4 = Ether(dst="00:11:22:33:44:55", type=0x8864)/Raw('x' * 20)
+    pkt5 = Ether(dst="00:11:22:33:44:55", type=0x88cc)/Raw('x' * 20)
 
-   verify pkt1 to queue 2, and pkt2 to queue 3, pkt3 to queue 4, pkt4 dropped.
+   verify pkt1 to queue 2, and pkt2 to queue 3, pkt3 to queue 4, pkt4 dropped, pkt5 to queue 6.
 
 4. verify rules can be listed and destroyed::
 
     testpmd> flow list 0
     testpmd> flow destroy 0 rule 0
-    verify pkt1 to queue 0, and pkt2 to queue 3, pkt3 to queue 4,
+    verify pkt1 to queue 0, and pkt2 to queue 3, pkt3 to queue 4, pkt4 dropped, pkt5 to queue 6.
     testpmd> flow list 0
     testpmd> flow flush 0
-    verify pkt1 to queue 0, and pkt2 to queue 0, pkt3 to queue 0, pkt4 to queue 0.
+    verify pkt1 to queue 0, and pkt2 to queue 0, pkt3 to queue 0, pkt4 to queue 0, pkt5 to queue 0.
     testpmd> flow list 0
 
 
-- 
2.7.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH 1/2] test_plans/generic_flow_api: correct i40e could support 0x88cc ether type packet
  2019-08-05 10:03 [dts] [PATCH 1/2] test_plans/generic_flow_api: correct i40e could support 0x88cc ether type packet Lin Xueqin
@ 2019-08-06  8:51 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2019-08-06  8:51 UTC (permalink / raw)
  To: Lin, Xueqin, dts; +Cc: Lin, Xueqin

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lin Xueqin
> Sent: Monday, August 5, 2019 6:04 PM
> To: dts@dpdk.org
> Cc: Lin, Xueqin <xueqin.lin@intel.com>
> Subject: [dts] [PATCH 1/2] test_plans/generic_flow_api: correct i40e could
> support 0x88cc ether type packet
> 
> From: Xueqin Lin <xueqin.lin@intel.com>
> 
> Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>
> 
> ---
>  test_plans/generic_flow_api_test_plan.rst | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/test_plans/generic_flow_api_test_plan.rst
> b/test_plans/generic_flow_api_test_plan.rst
> index f53e7c7..380d9e8 100644
> --- a/test_plans/generic_flow_api_test_plan.rst
> +++ b/test_plans/generic_flow_api_test_plan.rst
> @@ -70,26 +70,24 @@ Test case: Fortville ethertype
>      testpmd> flow validate 0 ingress pattern eth type is 0x88cc / end actions
> queue index 5 / end
>      testpmd> flow create 0 ingress pattern eth type is 0x88cc / end actions
> queue index 6 / end
> 
> -   the i40e don't support the 0x88cc eth type packet. so the last two
> commands
> -   failed.
> -
>  3. send packets::
> 
>      pkt1 = Ether(dst="ff:ff:ff:ff:ff:ff")/ARP(pdst="192.168.1.1")
>      pkt2 = Ether(dst="00:11:22:33:44:55", type=0x88BB)/Raw('x' * 20)
>      pkt3 = Ether(dst="00:11:22:33:44:55", type=0x88e5)/Raw('x' * 20)
>      pkt4 = Ether(dst="00:11:22:33:44:55", type=0x8864)/Raw('x' * 20)
> +    pkt5 = Ether(dst="00:11:22:33:44:55", type=0x88cc)/Raw('x' * 20)
> 
> -   verify pkt1 to queue 2, and pkt2 to queue 3, pkt3 to queue 4, pkt4
> dropped.
> +   verify pkt1 to queue 2, and pkt2 to queue 3, pkt3 to queue 4, pkt4
> dropped, pkt5 to queue 6.
> 
>  4. verify rules can be listed and destroyed::
> 
>      testpmd> flow list 0
>      testpmd> flow destroy 0 rule 0
> -    verify pkt1 to queue 0, and pkt2 to queue 3, pkt3 to queue 4,
> +    verify pkt1 to queue 0, and pkt2 to queue 3, pkt3 to queue 4, pkt4
> dropped, pkt5 to queue 6.
>      testpmd> flow list 0
>      testpmd> flow flush 0
> -    verify pkt1 to queue 0, and pkt2 to queue 0, pkt3 to queue 0, pkt4 to
> queue 0.
> +    verify pkt1 to queue 0, and pkt2 to queue 0, pkt3 to queue 0, pkt4 to
> queue 0, pkt5 to queue 0.
>      testpmd> flow list 0
> 
> 
> --
> 2.7.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-05 10:03 [dts] [PATCH 1/2] test_plans/generic_flow_api: correct i40e could support 0x88cc ether type packet Lin Xueqin
2019-08-06  8:51 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox