test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "nareddy@marvell.com" <nareddy@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "fmasood@marvell.com" <fmasood@marvell.com>,
	"avijay@marvell.com" <avijay@marvell.com>
Subject: Re: [dts] [PATCH] TestSuite_shutdown_api.py: disable-crc-strip is not	supported for cavium_a063 and cavium_a064
Date: Mon, 12 Aug 2019 07:02:20 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BB01917@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1565580433-29476-1-git-send-email-nareddy@marvell.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> nareddy@marvell.com
> Sent: Monday, August 12, 2019 11:27 AM
> To: dts@dpdk.org
> Cc: fmasood@marvell.com; avijay@marvell.com; Praneeth Reddy
> <nareddy@marvell.com>
> Subject: [dts] [PATCH] TestSuite_shutdown_api.py: disable-crc-strip is not
> supported for cavium_a063 and cavium_a064
> 
> From: Praneeth Reddy <nareddy@marvell.com>
> 
> Removed disable-crc-strip parameter for cavium_a063 and cavium_a064
> 
> Signed-off-by: Praneeth Reddy <nareddy@marvell.com>
> ---
>  tests/TestSuite_shutdown_api.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index d31392d..f889e1c 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -265,7 +265,10 @@ class TestShutdownApi(TestCase):
>          """
>          RX_OFFLOAD_KEEP_CRC = 0x10000
> 
> -        self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop --disable-crc-strip" % utils.create_mask(self.ports),
> socket=self.ports_socket)
> +        if (self.nic in ["cavium_a063", "cavium_a064"]):
> +            self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
> +        else:
> +            self.pmdout.start_testpmd("Default", "--portmask=%s
> + --port-topology=loop --disable-crc-strip" %
> + utils.create_mask(self.ports), socket=self.ports_socket)
>          out = self.dut.send_expect("show config rxtx", "testpmd> ")
>          Rx_offloads = re.compile('Rx offloads=(.*?)\s+?').findall(out, re.S)
>          crc_keep_temp = []
> --
> 1.8.3.1


      reply	other threads:[~2019-08-12  7:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12  3:27 nareddy
2019-08-12  7:02 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BB01917@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=avijay@marvell.com \
    --cc=dts@dpdk.org \
    --cc=fmasood@marvell.com \
    --cc=nareddy@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).