test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] framework/delete specify compiler gcc48
@ 2019-09-16  2:37 changqingxwu
  2019-09-16  9:49 ` Chen, BoX C
  2019-09-18 10:50 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: changqingxwu @ 2019-09-16  2:37 UTC (permalink / raw)
  To: dts; +Cc: box.c.chen, changqingxwu

do not need specify the gcc48 when compiling dpdk or app with clang
on freebsd, otherwise will get compile error

Signed-off-by: changqingxwu <changqingx.wu@intel.com>
---
 framework/project_dpdk.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
index f75a4b9..ddad526 100644
--- a/framework/project_dpdk.py
+++ b/framework/project_dpdk.py
@@ -243,15 +243,15 @@ class DPDKdut(Dut):
         self.send_expect("rm -rf %s" % r'./app/test/test_resource_c.res.o' , "#")
         self.send_expect("rm -rf %s" % r'./app/test/test_resource_tar.res.o' , "#")
         self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
-        build_time = 120
+        build_time = 180
         # compile
-        out = self.send_expect("make -j %d install T=%s CC=gcc48" % (self.number_of_cores,
+        out = self.send_expect("make -j %d install T=%s" % (self.number_of_cores,
                                                                      target),
                                "#", build_time)
         if("Error" in out or "No rule to make" in out):
             self.logger.error("ERROR - try without '-j'")
             # if Error try to execute make without -j option
-            out = self.send_expect("make install T=%s CC=gcc48" % target,
+            out = self.send_expect("make install T=%s" % target,
                                    "#", build_time)
 
         assert ("Error" not in out), "Compilation error..."
@@ -386,7 +386,7 @@ class DPDKdut(Dut):
         self.send_expect("rm -rf %s" % r'./app/test/test_resource_c.res.o' , "#")
         self.send_expect("rm -rf %s" % r'./app/test/test_resource_tar.res.o' , "#")
         self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
-        return self.send_expect("make -j %d -C %s %s CC=gcc48" % (self.number_of_cores,
+        return self.send_expect("make -j %d -C %s %s" % (self.number_of_cores,
                                                                   folder, extra_options),
                                 "# ", 180)
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] framework/delete specify compiler gcc48
  2019-09-16  2:37 [dts] [PATCH V1] framework/delete specify compiler gcc48 changqingxwu
@ 2019-09-16  9:49 ` Chen, BoX C
  2019-09-18 10:50 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Chen, BoX C @ 2019-09-16  9:49 UTC (permalink / raw)
  To: Wu, ChangqingX, dts

Tested-by:  Chen, BoX C <box.c.chen@intel.com>


> -----Original Message-----
> From: Wu, ChangqingX
> Sent: September 16, 2019 10:37
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>; Wu, ChangqingX
> <changqingx.wu@intel.com>
> Subject: [dts][PATCH V1] framework/delete specify compiler gcc48
> 
> do not need specify the gcc48 when compiling dpdk or app with clang on
> freebsd, otherwise will get compile error
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  framework/project_dpdk.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> index f75a4b9..ddad526 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -243,15 +243,15 @@ class DPDKdut(Dut):
>          self.send_expect("rm -rf %s" % r'./app/test/test_resource_c.res.o' , "#")
>          self.send_expect("rm -rf %s" % r'./app/test/test_resource_tar.res.o' ,
> "#")
>          self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
> -        build_time = 120
> +        build_time = 180
>          # compile
> -        out = self.send_expect("make -j %d install T=%s CC=gcc48" %
> (self.number_of_cores,
> +        out = self.send_expect("make -j %d install T=%s" %
> + (self.number_of_cores,
>                                                                       target),
>                                 "#", build_time)
>          if("Error" in out or "No rule to make" in out):
>              self.logger.error("ERROR - try without '-j'")
>              # if Error try to execute make without -j option
> -            out = self.send_expect("make install T=%s CC=gcc48" % target,
> +            out = self.send_expect("make install T=%s" % target,
>                                     "#", build_time)
> 
>          assert ("Error" not in out), "Compilation error..."
> @@ -386,7 +386,7 @@ class DPDKdut(Dut):
>          self.send_expect("rm -rf %s" % r'./app/test/test_resource_c.res.o' , "#")
>          self.send_expect("rm -rf %s" % r'./app/test/test_resource_tar.res.o' ,
> "#")
>          self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
> -        return self.send_expect("make -j %d -C %s %s CC=gcc48" %
> (self.number_of_cores,
> +        return self.send_expect("make -j %d -C %s %s" %
> + (self.number_of_cores,
>                                                                    folder, extra_options),
>                                  "# ", 180)
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] framework/delete specify compiler gcc48
  2019-09-16  2:37 [dts] [PATCH V1] framework/delete specify compiler gcc48 changqingxwu
  2019-09-16  9:49 ` Chen, BoX C
@ 2019-09-18 10:50 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-09-18 10:50 UTC (permalink / raw)
  To: Wu, ChangqingX, dts; +Cc: Chen, BoX C, Wu, ChangqingX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of changqingxwu
> Sent: Monday, September 16, 2019 10:37 AM
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>; Wu, ChangqingX
> <changqingx.wu@intel.com>
> Subject: [dts] [PATCH V1] framework/delete specify compiler gcc48
> 
> do not need specify the gcc48 when compiling dpdk or app with clang on
> freebsd, otherwise will get compile error
> 
> Signed-off-by: changqingxwu <changqingx.wu@intel.com>
> ---
>  framework/project_dpdk.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index
> f75a4b9..ddad526 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -243,15 +243,15 @@ class DPDKdut(Dut):
>          self.send_expect("rm -rf %s" % r'./app/test/test_resource_c.res.o' , "#")
>          self.send_expect("rm -rf %s" % r'./app/test/test_resource_tar.res.o' ,
> "#")
>          self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
> -        build_time = 120
> +        build_time = 180
>          # compile
> -        out = self.send_expect("make -j %d install T=%s CC=gcc48" %
> (self.number_of_cores,
> +        out = self.send_expect("make -j %d install T=%s" %
> + (self.number_of_cores,
>                                                                       target),
>                                 "#", build_time)
>          if("Error" in out or "No rule to make" in out):
>              self.logger.error("ERROR - try without '-j'")
>              # if Error try to execute make without -j option
> -            out = self.send_expect("make install T=%s CC=gcc48" % target,
> +            out = self.send_expect("make install T=%s" % target,
>                                     "#", build_time)
> 
>          assert ("Error" not in out), "Compilation error..."
> @@ -386,7 +386,7 @@ class DPDKdut(Dut):
>          self.send_expect("rm -rf %s" % r'./app/test/test_resource_c.res.o' , "#")
>          self.send_expect("rm -rf %s" % r'./app/test/test_resource_tar.res.o' ,
> "#")
>          self.send_expect("rm -rf %s" % r'./app/test/test_pci_sysfs.res.o' , "#")
> -        return self.send_expect("make -j %d -C %s %s CC=gcc48" %
> (self.number_of_cores,
> +        return self.send_expect("make -j %d -C %s %s" %
> + (self.number_of_cores,
>                                                                    folder, extra_options),
>                                  "# ", 180)
> 
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-16  2:37 [dts] [PATCH V1] framework/delete specify compiler gcc48 changqingxwu
2019-09-16  9:49 ` Chen, BoX C
2019-09-18 10:50 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox