test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path
@ 2019-10-17  7:29 Xiao Qimai
  2019-10-17  8:08 ` Zhu, ShuaiX
  2019-10-22  9:11 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2019-10-17  7:29 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

fix save pcapfile method to new api

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/bonding.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/bonding.py b/tests/bonding.py
index fb2a69e..6c136a3 100644
--- a/tests/bonding.py
+++ b/tests/bonding.py
@@ -36,7 +36,7 @@ import struct
 import socket
 from socket import htonl
 
-from packet import Packet
+from packet import Packet, TMP_PATH
 from scapy.sendrecv import sendp
 from scapy.utils import wrpcap
 
@@ -181,14 +181,14 @@ class PmdBonding(object):
         # create packet
         streams = []
         # keep a copy of pcap for debug
-        savePath = os.sep.join([self.target_source,
+        savePath = os.sep.join([TMP_PATH,
                                 "pkt_{0}.pcap".format(pkt_name)])
         pkt_type = pkt_config.get('type')
         pkt_layers = pkt_config.get('pkt_layers')
         pkt = Packet(pkt_type=pkt_type.upper())
         for layer in pkt_layers.keys():
             pkt.config_layer(layer, pkt_layers[layer])
-        pkt.pktgen.write_pcap(savePath)
+        pkt.save_pcapfile(filename=savePath)
         streams.append(pkt.pktgen.pkt)
 
         return streams
@@ -228,14 +228,14 @@ class PmdBonding(object):
         streams = []
         for values in pkt_configs:
             # keep a copy of pcap for debug
-            savePath = os.sep.join([self.target_source,
+            savePath = os.sep.join([TMP_PATH,
                                     "pkt_{0}.pcap".format(stm_name)])
             pkt_type = values.get('type')
             pkt_layers = values.get('pkt_layers')
             pkt = Packet(pkt_type=pkt_type.upper())
             for layer in pkt_layers.keys():
                 pkt.config_layer(layer, pkt_layers[layer])
-            pkt.pktgen.write_pcap(savePath)
+            pkt.save_pcapfile(filename=savePath)
             streams.append(pkt.pktgen.pkt)
 
         return streams
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path
  2019-10-17  7:29 [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path Xiao Qimai
@ 2019-10-17  8:08 ` Zhu, ShuaiX
  2019-10-22  9:11 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, ShuaiX @ 2019-10-17  8:08 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX, Zhu, ShuaiX

[-- Attachment #1: Type: text/plain, Size: 2452 bytes --]

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, October 17, 2019 3:30 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path
> 
> fix save pcapfile method to new api
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/bonding.py | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/bonding.py b/tests/bonding.py index fb2a69e..6c136a3 100644
> --- a/tests/bonding.py
> +++ b/tests/bonding.py
> @@ -36,7 +36,7 @@ import struct
>  import socket
>  from socket import htonl
> 
> -from packet import Packet
> +from packet import Packet, TMP_PATH
>  from scapy.sendrecv import sendp
>  from scapy.utils import wrpcap
> 
> @@ -181,14 +181,14 @@ class PmdBonding(object):
>          # create packet
>          streams = []
>          # keep a copy of pcap for debug
> -        savePath = os.sep.join([self.target_source,
> +        savePath = os.sep.join([TMP_PATH,
>                                  "pkt_{0}.pcap".format(pkt_name)])
>          pkt_type = pkt_config.get('type')
>          pkt_layers = pkt_config.get('pkt_layers')
>          pkt = Packet(pkt_type=pkt_type.upper())
>          for layer in pkt_layers.keys():
>              pkt.config_layer(layer, pkt_layers[layer])
> -        pkt.pktgen.write_pcap(savePath)
> +        pkt.save_pcapfile(filename=savePath)
>          streams.append(pkt.pktgen.pkt)
> 
>          return streams
> @@ -228,14 +228,14 @@ class PmdBonding(object):
>          streams = []
>          for values in pkt_configs:
>              # keep a copy of pcap for debug
> -            savePath = os.sep.join([self.target_source,
> +            savePath = os.sep.join([TMP_PATH,
>                                      "pkt_{0}.pcap".format(stm_name)])
>              pkt_type = values.get('type')
>              pkt_layers = values.get('pkt_layers')
>              pkt = Packet(pkt_type=pkt_type.upper())
>              for layer in pkt_layers.keys():
>                  pkt.config_layer(layer, pkt_layers[layer])
> -            pkt.pktgen.write_pcap(savePath)
> +            pkt.save_pcapfile(filename=savePath)
>              streams.append(pkt.pktgen.pkt)
> 
>          return streams
> --
> 1.8.3.1


[-- Attachment #2: TestBondingStacked.log --]
[-- Type: application/octet-stream, Size: 422402 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path
  2019-10-17  7:29 [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path Xiao Qimai
  2019-10-17  8:08 ` Zhu, ShuaiX
@ 2019-10-22  9:11 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-10-22  9:11 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied,thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, October 17, 2019 3:30 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path
> 
> fix save pcapfile method to new api
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/bonding.py | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/bonding.py b/tests/bonding.py index fb2a69e..6c136a3
> 100644
> --- a/tests/bonding.py
> +++ b/tests/bonding.py
> @@ -36,7 +36,7 @@ import struct
>  import socket
>  from socket import htonl
> 
> -from packet import Packet
> +from packet import Packet, TMP_PATH
>  from scapy.sendrecv import sendp
>  from scapy.utils import wrpcap
> 
> @@ -181,14 +181,14 @@ class PmdBonding(object):
>          # create packet
>          streams = []
>          # keep a copy of pcap for debug
> -        savePath = os.sep.join([self.target_source,
> +        savePath = os.sep.join([TMP_PATH,
>                                  "pkt_{0}.pcap".format(pkt_name)])
>          pkt_type = pkt_config.get('type')
>          pkt_layers = pkt_config.get('pkt_layers')
>          pkt = Packet(pkt_type=pkt_type.upper())
>          for layer in pkt_layers.keys():
>              pkt.config_layer(layer, pkt_layers[layer])
> -        pkt.pktgen.write_pcap(savePath)
> +        pkt.save_pcapfile(filename=savePath)
>          streams.append(pkt.pktgen.pkt)
> 
>          return streams
> @@ -228,14 +228,14 @@ class PmdBonding(object):
>          streams = []
>          for values in pkt_configs:
>              # keep a copy of pcap for debug
> -            savePath = os.sep.join([self.target_source,
> +            savePath = os.sep.join([TMP_PATH,
>                                      "pkt_{0}.pcap".format(stm_name)])
>              pkt_type = values.get('type')
>              pkt_layers = values.get('pkt_layers')
>              pkt = Packet(pkt_type=pkt_type.upper())
>              for layer in pkt_layers.keys():
>                  pkt.config_layer(layer, pkt_layers[layer])
> -            pkt.pktgen.write_pcap(savePath)
> +            pkt.save_pcapfile(filename=savePath)
>              streams.append(pkt.pktgen.pkt)
> 
>          return streams
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17  7:29 [dts] [PATCH V2] tests/bonding: fix save pcapfile method and path Xiao Qimai
2019-10-17  8:08 ` Zhu, ShuaiX
2019-10-22  9:11 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox