test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet should has flags S
@ 2019-10-18  5:37 Xiao Qimai
  2019-10-18  5:47 ` Zhu, WenhuiX
  2019-10-23  9:40 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2019-10-18  5:37 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

add flags S to SYN tcp packet and remove Raw from it

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_queue_region.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_queue_region.py b/tests/TestSuite_queue_region.py
index eea873e..7d01dfb 100644
--- a/tests/TestSuite_queue_region.py
+++ b/tests/TestSuite_queue_region.py
@@ -122,6 +122,8 @@ class TestQueue_region(TestCase):
             pkt = Packet(pkt_type='TCP')
             pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
             pkt.config_layer('tcp', {'flags': flags})
+            if flags == 'S':
+                pkt.pktgen.pkt.__delitem__('Raw')
         elif (pkt_type == "sctp"):
             pkt = Packet(pkt_type='SCTP')
             pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
@@ -135,6 +137,9 @@ class TestQueue_region(TestCase):
             pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
         elif (pkt_type == "ipv6_tcp"):
             pkt = Packet(pkt_type='IPv6_TCP')
+            pkt.config_layer('tcp',{'flags':flags})
+            if flags == 'S':
+                pkt.pktgen.pkt.__delitem__('Raw')
             pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
         elif (pkt_type == "ipv6_sctp"):
             pkt = Packet(pkt_type='IPv6_SCTP')
@@ -262,7 +267,7 @@ class TestQueue_region(TestCase):
         # not assign ipv4-tcp SYN packet to any queue region, the packet to queue region 0.
         if(self.nic in ["fortpark_TLV"]):
             queue_region = ["1"]
-            queue_ipv6tcp = self.send_and_check(queue_region, mac=self.pf_mac, pkt_type="ipv6_tcp")
+            queue_ipv6tcp = self.send_and_check(queue_region, mac=self.pf_mac, pkt_type="ipv6_tcp", flags="S")
         else:
             queue_region = ["8", "9"]
             queue_ipv6tcp = self.send_and_check(queue_region, mac=self.pf_mac, pkt_type="ipv6_tcp")
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet should has flags S
  2019-10-18  5:37 [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet should has flags S Xiao Qimai
@ 2019-10-18  5:47 ` Zhu, WenhuiX
  2019-10-23  9:40 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-10-18  5:47 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

[-- Attachment #1: Type: text/plain, Size: 2354 bytes --]


Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>
-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
Sent: Friday, October 18, 2019 1:37 PM
To: dts@dpdk.org
Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet should has flags S

add flags S to SYN tcp packet and remove Raw from it

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_queue_region.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_queue_region.py b/tests/TestSuite_queue_region.py index eea873e..7d01dfb 100644
--- a/tests/TestSuite_queue_region.py
+++ b/tests/TestSuite_queue_region.py
@@ -122,6 +122,8 @@ class TestQueue_region(TestCase):
             pkt = Packet(pkt_type='TCP')
             pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
             pkt.config_layer('tcp', {'flags': flags})
+            if flags == 'S':
+                pkt.pktgen.pkt.__delitem__('Raw')
         elif (pkt_type == "sctp"):
             pkt = Packet(pkt_type='SCTP')
             pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac}) @@ -135,6 +137,9 @@ class TestQueue_region(TestCase):
             pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
         elif (pkt_type == "ipv6_tcp"):
             pkt = Packet(pkt_type='IPv6_TCP')
+            pkt.config_layer('tcp',{'flags':flags})
+            if flags == 'S':
+                pkt.pktgen.pkt.__delitem__('Raw')
             pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
         elif (pkt_type == "ipv6_sctp"):
             pkt = Packet(pkt_type='IPv6_SCTP') @@ -262,7 +267,7 @@ class TestQueue_region(TestCase):
         # not assign ipv4-tcp SYN packet to any queue region, the packet to queue region 0.
         if(self.nic in ["fortpark_TLV"]):
             queue_region = ["1"]
-            queue_ipv6tcp = self.send_and_check(queue_region, mac=self.pf_mac, pkt_type="ipv6_tcp")
+            queue_ipv6tcp = self.send_and_check(queue_region, 
+ mac=self.pf_mac, pkt_type="ipv6_tcp", flags="S")
         else:
             queue_region = ["8", "9"]
             queue_ipv6tcp = self.send_and_check(queue_region, mac=self.pf_mac, pkt_type="ipv6_tcp")
--
1.8.3.1


[-- Attachment #2: TestQueue_region.log --]
[-- Type: application/octet-stream, Size: 167918 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet should has flags S
  2019-10-18  5:37 [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet should has flags S Xiao Qimai
  2019-10-18  5:47 ` Zhu, WenhuiX
@ 2019-10-23  9:40 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-10-23  9:40 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Friday, October 18, 2019 1:37 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet
> should has flags S
> 
> add flags S to SYN tcp packet and remove Raw from it
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_queue_region.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_queue_region.py
> b/tests/TestSuite_queue_region.py index eea873e..7d01dfb 100644
> --- a/tests/TestSuite_queue_region.py
> +++ b/tests/TestSuite_queue_region.py
> @@ -122,6 +122,8 @@ class TestQueue_region(TestCase):
>              pkt = Packet(pkt_type='TCP')
>              pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
>              pkt.config_layer('tcp', {'flags': flags})
> +            if flags == 'S':
> +                pkt.pktgen.pkt.__delitem__('Raw')
>          elif (pkt_type == "sctp"):
>              pkt = Packet(pkt_type='SCTP')
>              pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac}) @@ -135,6
> +137,9 @@ class TestQueue_region(TestCase):
>              pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
>          elif (pkt_type == "ipv6_tcp"):
>              pkt = Packet(pkt_type='IPv6_TCP')
> +            pkt.config_layer('tcp',{'flags':flags})
> +            if flags == 'S':
> +                pkt.pktgen.pkt.__delitem__('Raw')
>              pkt.config_layer('ether', {'dst': mac, 'src': self.tester_mac})
>          elif (pkt_type == "ipv6_sctp"):
>              pkt = Packet(pkt_type='IPv6_SCTP') @@ -262,7 +267,7 @@ class
> TestQueue_region(TestCase):
>          # not assign ipv4-tcp SYN packet to any queue region, the packet to
> queue region 0.
>          if(self.nic in ["fortpark_TLV"]):
>              queue_region = ["1"]
> -            queue_ipv6tcp = self.send_and_check(queue_region,
> mac=self.pf_mac, pkt_type="ipv6_tcp")
> +            queue_ipv6tcp = self.send_and_check(queue_region,
> + mac=self.pf_mac, pkt_type="ipv6_tcp", flags="S")
>          else:
>              queue_region = ["8", "9"]
>              queue_ipv6tcp = self.send_and_check(queue_region,
> mac=self.pf_mac, pkt_type="ipv6_tcp")
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18  5:37 [dts] [PATCH V1] tests/TestSuite_queue_region: SYN tcp packet should has flags S Xiao Qimai
2019-10-18  5:47 ` Zhu, WenhuiX
2019-10-23  9:40 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox