test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/userspace_ethtool: cannot change CVL link status by the peer port
  2019-10-31 14:07 [dts] [PATCH V1] tests/userspace_ethtool: cannot change CVL link status by the peer port Wenjie Li
@ 2019-10-31  5:22 ` Zhu, WenhuiX
  2019-11-22  2:55 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2019-10-31  5:22 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]

Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Thursday, October 31, 2019 10:07 PM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/userspace_ethtool: cannot change CVL link status by the peer port

In case dump_driver_info, like fortville, CVL link status cannot be changed by the peer ports.
After change the peer port status by running "ip link set dev PORT
down|up", CVL link status will not change. So skip this step.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 116fd3a..8d18b0c 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         # only detect physical link disconnect status
         verify_pass = True
         verify_msg = ''
-        if self.nic.startswith("fortville") == False:  
+        if self.nic.startswith("fortville") == False and self.nic.startswith("columbiaville") == False:
             # check link status dump function
             for port in self.ports:
                 tester_port = self.tester.get_local_port(port)
-- 
2.17.1


[-- Attachment #2: TestUserspaceEthtool.log --]
[-- Type: application/octet-stream, Size: 12091 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/userspace_ethtool: cannot change CVL link status by the peer port
@ 2019-10-31 14:07 Wenjie Li
  2019-10-31  5:22 ` Zhu, WenhuiX
  2019-11-22  2:55 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-10-31 14:07 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

In case dump_driver_info, like fortville, CVL link status cannot be changed by the peer ports.
After change the peer port status by running "ip link set dev PORT
down|up", CVL link status will not change. So skip this step.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_userspace_ethtool.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py
index 116fd3a..8d18b0c 100644
--- a/tests/TestSuite_userspace_ethtool.py
+++ b/tests/TestSuite_userspace_ethtool.py
@@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase, IxiaPacketGenerator):
         # only detect physical link disconnect status
         verify_pass = True
         verify_msg = ''
-        if self.nic.startswith("fortville") == False:  
+        if self.nic.startswith("fortville") == False and self.nic.startswith("columbiaville") == False:
             # check link status dump function
             for port in self.ports:
                 tester_port = self.tester.get_local_port(port)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/userspace_ethtool: cannot change CVL link status by the peer port
  2019-10-31 14:07 [dts] [PATCH V1] tests/userspace_ethtool: cannot change CVL link status by the peer port Wenjie Li
  2019-10-31  5:22 ` Zhu, WenhuiX
@ 2019-11-22  2:55 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2019-11-22  2:55 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

Applied failed, please rework your patch

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Thursday, October 31, 2019 10:07 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/userspace_ethtool: cannot change CVL link
> status by the peer port
> 
> In case dump_driver_info, like fortville, CVL link status cannot be changed by
> the peer ports.
> After change the peer port status by running "ip link set dev PORT
> down|up", CVL link status will not change. So skip this step.
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 116fd3a..8d18b0c 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -259,7 +259,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          # only detect physical link disconnect status
>          verify_pass = True
>          verify_msg = ''
> -        if self.nic.startswith("fortville") == False:
> +        if self.nic.startswith("fortville") == False and
> self.nic.startswith("columbiaville") == False:
>              # check link status dump function
>              for port in self.ports:
>                  tester_port = self.tester.get_local_port(port)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 14:07 [dts] [PATCH V1] tests/userspace_ethtool: cannot change CVL link status by the peer port Wenjie Li
2019-10-31  5:22 ` Zhu, WenhuiX
2019-11-22  2:55 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox