test suite reviews and discussions
 help / color / Atom feed
* [dts]  [PATCH V2] tests/port_control:add if else to suit cvl
@ 2020-01-09  2:48 Zeng Xiaoxiao
  2020-01-09  3:05 ` Zhu, WenhuiX
  2020-01-09  8:34 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Zeng Xiaoxiao @ 2020-01-09  2:48 UTC (permalink / raw)
  To: dts; +Cc: Zeng Xiaoxiao

Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_port_control.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
index a458add..f006ddb 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -166,12 +166,18 @@ class TestPortControl(TestCase):
         terminal.execute_cmd("stop")
         terminal.execute_cmd("port stop all")
         ret = terminal.get_port_link_status(self.port_id_0)
-        self.verify(ret == "down", "port not down!")
+        if self.nic.startswith('columbiaville'):
+            self.verify(ret != "", "port status error!")
+        else:
+            self.verify(ret == "down", "port not down!")
 
     def reset_pmd_port(self, terminal):
         terminal.execute_cmd("port reset all")
         ret = terminal.get_port_link_status(self.port_id_0)
-        self.verify(ret == "down", "port reset fail!")
+        if self.nic.startswith('columbiaville'):
+            self.verify(ret != "", "port status error!")
+        else:
+            self.verify(ret == "down", "port not down!")
 
     def close_pmd_port(self, terminal):
         terminal.execute_cmd("port close all")
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/port_control:add if else to suit cvl
  2020-01-09  2:48 [dts] [PATCH V2] tests/port_control:add if else to suit cvl Zeng Xiaoxiao
@ 2020-01-09  3:05 ` Zhu, WenhuiX
  2020-01-09  8:34 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zhu, WenhuiX @ 2020-01-09  3:05 UTC (permalink / raw)
  To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX

[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]

Tested-by: Zhu, WenhuiX <wenhuix.zhu@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zeng Xiaoxiao
Sent: Thursday, January 9, 2020 10:49 AM
To: dts@dpdk.org
Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
Subject: [dts] [PATCH V2] tests/port_control:add if else to suit cvl

Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_port_control.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py index a458add..f006ddb 100644
--- a/tests/TestSuite_port_control.py
+++ b/tests/TestSuite_port_control.py
@@ -166,12 +166,18 @@ class TestPortControl(TestCase):
         terminal.execute_cmd("stop")
         terminal.execute_cmd("port stop all")
         ret = terminal.get_port_link_status(self.port_id_0)
-        self.verify(ret == "down", "port not down!")
+        if self.nic.startswith('columbiaville'):
+            self.verify(ret != "", "port status error!")
+        else:
+            self.verify(ret == "down", "port not down!")
 
     def reset_pmd_port(self, terminal):
         terminal.execute_cmd("port reset all")
         ret = terminal.get_port_link_status(self.port_id_0)
-        self.verify(ret == "down", "port reset fail!")
+        if self.nic.startswith('columbiaville'):
+            self.verify(ret != "", "port status error!")
+        else:
+            self.verify(ret == "down", "port not down!")
 
     def close_pmd_port(self, terminal):
         terminal.execute_cmd("port close all")
--
1.8.3.1


[-- Attachment #2: TestPortControl.log --]
[-- Type: application/octet-stream, Size: 33698 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/port_control:add if else to suit cvl
  2020-01-09  2:48 [dts] [PATCH V2] tests/port_control:add if else to suit cvl Zeng Xiaoxiao
  2020-01-09  3:05 ` Zhu, WenhuiX
@ 2020-01-09  8:34 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-01-09  8:34 UTC (permalink / raw)
  To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX

Applied

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zeng Xiaoxiao
> Sent: Thursday, January 9, 2020 10:49 AM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V2] tests/port_control:add if else to suit cvl
> 
> Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_port_control.py | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
> index a458add..f006ddb 100644
> --- a/tests/TestSuite_port_control.py
> +++ b/tests/TestSuite_port_control.py
> @@ -166,12 +166,18 @@ class TestPortControl(TestCase):
>          terminal.execute_cmd("stop")
>          terminal.execute_cmd("port stop all")
>          ret = terminal.get_port_link_status(self.port_id_0)
> -        self.verify(ret == "down", "port not down!")
> +        if self.nic.startswith('columbiaville'):
> +            self.verify(ret != "", "port status error!")
> +        else:
> +            self.verify(ret == "down", "port not down!")
> 
>      def reset_pmd_port(self, terminal):
>          terminal.execute_cmd("port reset all")
>          ret = terminal.get_port_link_status(self.port_id_0)
> -        self.verify(ret == "down", "port reset fail!")
> +        if self.nic.startswith('columbiaville'):
> +            self.verify(ret != "", "port status error!")
> +        else:
> +            self.verify(ret == "down", "port not down!")
> 
>      def close_pmd_port(self, terminal):
>          terminal.execute_cmd("port close all")
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-09  2:48 [dts] [PATCH V2] tests/port_control:add if else to suit cvl Zeng Xiaoxiao
2020-01-09  3:05 ` Zhu, WenhuiX
2020-01-09  8:34 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox