test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V2]tests/ethtool_stats: add file-prefx to launch procinfo
@ 2020-01-16 11:05 Xiao Qimai
  2020-01-16 11:31 ` Xiao, QimaiX
  2020-01-17  5:34 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Xiao Qimai @ 2020-01-16 11:05 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

add file-prefix to launch dpdk-procinfo

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 tests/TestSuite_ethtool_stats.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_ethtool_stats.py b/tests/TestSuite_ethtool_stats.py
index 4f56885..f3152d9 100644
--- a/tests/TestSuite_ethtool_stats.py
+++ b/tests/TestSuite_ethtool_stats.py
@@ -159,7 +159,7 @@ class TestEthtoolStats(TestCase):
         ports_mask = reduce(lambda x, y: x | y,
                             [0x1 << x for x in range(ports_count)])
         self.query_tool = os.path.join(
-            self.target_dir, self.target, 'app', 'dpdk-procinfo')
+            self.target_dir, self.target, 'app', 'dpdk-procinfo --file-prefix=%s' % self.prefix)
         self.dpdk_proc_info = "%s -v -- -p %s" % (self.query_tool, ports_mask)
 
     def parse_proc_info_xstat_output(self, msg):
@@ -471,6 +471,7 @@ class TestEthtoolStats(TestCase):
     def set_up_all(self):
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, 'Insufficient ports')
+        self.prefix = "dpdk_" + self.dut.prefix_subfix
         self.preset_test_environment()
 
     def set_up(self):
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2]tests/ethtool_stats: add file-prefx to launch procinfo
  2020-01-16 11:05 [dts] [PATCH V2]tests/ethtool_stats: add file-prefx to launch procinfo Xiao Qimai
@ 2020-01-16 11:31 ` Xiao, QimaiX
  2020-01-17  5:34 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Xiao, QimaiX @ 2020-01-16 11:31 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 1617 bytes --]

Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>

> -----Original Message-----
> From: Xiao, QimaiX
> Sent: Thursday, January 16, 2020 7:05 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts][PATCH V2]tests/ethtool_stats: add file-prefx to launch
> procinfo
> 
> add file-prefix to launch dpdk-procinfo
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_ethtool_stats.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_ethtool_stats.py
> b/tests/TestSuite_ethtool_stats.py
> index 4f56885..f3152d9 100644
> --- a/tests/TestSuite_ethtool_stats.py
> +++ b/tests/TestSuite_ethtool_stats.py
> @@ -159,7 +159,7 @@ class TestEthtoolStats(TestCase):
>          ports_mask = reduce(lambda x, y: x | y,
>                              [0x1 << x for x in range(ports_count)])
>          self.query_tool = os.path.join(
> -            self.target_dir, self.target, 'app', 'dpdk-procinfo')
> +            self.target_dir, self.target, 'app', 'dpdk-procinfo --file-prefix=%s' %
> self.prefix)
>          self.dpdk_proc_info = "%s -v -- -p %s" % (self.query_tool, ports_mask)
> 
>      def parse_proc_info_xstat_output(self, msg):
> @@ -471,6 +471,7 @@ class TestEthtoolStats(TestCase):
>      def set_up_all(self):
>          self.dut_ports = self.dut.get_ports(self.nic)
>          self.verify(len(self.dut_ports) >= 1, 'Insufficient ports')
> +        self.prefix = "dpdk_" + self.dut.prefix_subfix
>          self.preset_test_environment()
> 
>      def set_up(self):
> --
> 2.17.1


[-- Attachment #2: TestEthtoolStats2.log --]
[-- Type: application/octet-stream, Size: 886489 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2]tests/ethtool_stats: add file-prefx to launch procinfo
  2020-01-16 11:05 [dts] [PATCH V2]tests/ethtool_stats: add file-prefx to launch procinfo Xiao Qimai
  2020-01-16 11:31 ` Xiao, QimaiX
@ 2020-01-17  5:34 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-01-17  5:34 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

Applied

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, January 16, 2020 7:05 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V2]tests/ethtool_stats: add file-prefx to launch
> procinfo
> 
> add file-prefix to launch dpdk-procinfo
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_ethtool_stats.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_ethtool_stats.py
> b/tests/TestSuite_ethtool_stats.py
> index 4f56885..f3152d9 100644
> --- a/tests/TestSuite_ethtool_stats.py
> +++ b/tests/TestSuite_ethtool_stats.py
> @@ -159,7 +159,7 @@ class TestEthtoolStats(TestCase):
>          ports_mask = reduce(lambda x, y: x | y,
>                              [0x1 << x for x in range(ports_count)])
>          self.query_tool = os.path.join(
> -            self.target_dir, self.target, 'app', 'dpdk-procinfo')
> +            self.target_dir, self.target, 'app', 'dpdk-procinfo --file-prefix=%s' %
> self.prefix)
>          self.dpdk_proc_info = "%s -v -- -p %s" % (self.query_tool, ports_mask)
> 
>      def parse_proc_info_xstat_output(self, msg):
> @@ -471,6 +471,7 @@ class TestEthtoolStats(TestCase):
>      def set_up_all(self):
>          self.dut_ports = self.dut.get_ports(self.nic)
>          self.verify(len(self.dut_ports) >= 1, 'Insufficient ports')
> +        self.prefix = "dpdk_" + self.dut.prefix_subfix
>          self.preset_test_environment()
> 
>      def set_up(self):
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 11:05 [dts] [PATCH V2]tests/ethtool_stats: add file-prefx to launch procinfo Xiao Qimai
2020-01-16 11:31 ` Xiao, QimaiX
2020-01-17  5:34 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox