test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/vf_l3fwd:string join func not support py3
@ 2020-01-19  8:52 Xie Wei
  2020-01-20  5:45 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Xie Wei @ 2020-01-19  8:52 UTC (permalink / raw)
  To: dts; +Cc: Xie Wei

Signed-off-by: Xie Wei <weix.xie@intel.com>
---
 tests/TestSuite_vf_l3fwd.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vf_l3fwd.py b/tests/TestSuite_vf_l3fwd.py
index 78b24c9..760b920 100644
--- a/tests/TestSuite_vf_l3fwd.py
+++ b/tests/TestSuite_vf_l3fwd.py
@@ -192,7 +192,7 @@ class TestVfL3fwd(TestCase):
             for layer in self.flows()[_port * 2:(_port + 1) * 2]:
                 flow = ['Ether(dst="%s", src="%s")/%s/("X"*%d)' % (dmac[index], smac[index], layer, payload_size)]
                 pcap = os.sep.join([self.output_path, "dst{0}_{1}.pcap".format(index, cnt)])
-                self.tester.scapy_append('wrpcap("%s", [%s])' % (pcap, string.join(flow, ',')))
+                self.tester.scapy_append('wrpcap("%s", [%s])' % (pcap, ','.join(flow)))
                 self.tester.scapy_execute()
                 if index not in pcaps:
                     pcaps[index] = []
-- 
2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/vf_l3fwd:string join func not support py3
  2020-01-19  8:52 [dts] [PATCH V1] tests/vf_l3fwd:string join func not support py3 Xie Wei
@ 2020-01-20  5:45 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-01-20  5:45 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

Applied

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xie Wei
> Sent: Sunday, January 19, 2020 4:53 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/vf_l3fwd:string join func not support py3
> 
> Signed-off-by: Xie Wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_vf_l3fwd.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vf_l3fwd.py b/tests/TestSuite_vf_l3fwd.py index
> 78b24c9..760b920 100644
> --- a/tests/TestSuite_vf_l3fwd.py
> +++ b/tests/TestSuite_vf_l3fwd.py
> @@ -192,7 +192,7 @@ class TestVfL3fwd(TestCase):
>              for layer in self.flows()[_port * 2:(_port + 1) * 2]:
>                  flow = ['Ether(dst="%s", src="%s")/%s/("X"*%d)' % (dmac[index],
> smac[index], layer, payload_size)]
>                  pcap = os.sep.join([self.output_path,
> "dst{0}_{1}.pcap".format(index, cnt)])
> -                self.tester.scapy_append('wrpcap("%s", [%s])' % (pcap,
> string.join(flow, ',')))
> +                self.tester.scapy_append('wrpcap("%s", [%s])' % (pcap,
> + ','.join(flow)))
>                  self.tester.scapy_execute()
>                  if index not in pcaps:
>                      pcaps[index] = []
> --
> 2.17.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-19  8:52 [dts] [PATCH V1] tests/vf_l3fwd:string join func not support py3 Xie Wei
2020-01-20  5:45 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox