test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>
Subject: Re: [dts] [PATCH V1]tests/shutdown_api: fix can't create vf
Date: Fri, 20 Mar 2020 07:56:45 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBEFA13@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1584520109-130808-1-git-send-email-xiaoxiaox.zeng@intel.com>

Hi xiaoxiao,

Framework has provide API " setup_modules_linux " to implement what you want, so you can call it directly:

self.dut.setup_modules_linux(self.target, 'igb_uio', '')

thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zeng Xiaoxiao
> Sent: Wednesday, March 18, 2020 4:28 PM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1]tests/shutdown_api: fix can't create vf
> 
> *.need insmod igb_uio when drivername is vfio-pci.
> *.destroy vm after vf case finish.
> 
> Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 11d451b..ffee0f2 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -260,6 +260,8 @@ class TestShutdownApi(TestCase):
>              self.vf_assign_method = 'vfio-pci'
>              self.dut.send_expect('modprobe vfio-pci', '#')
> 
> +        self.dut.send_expect('modprobe uio', '#')
> +        self.dut.send_expect("insmod ./" + self.target +
> + "/kmod/igb_uio.ko", "#", 60)
>          self.bind_nic_driver(self.dut_ports[:1], driver="igb_uio")
>          self.used_dut_port = self.dut_ports[0]
>          tester_port = self.tester.get_local_port(self.used_dut_port)
> @@ -296,6 +298,7 @@ class TestShutdownApi(TestCase):
> 
>          self.vm_env_done = True
>          self.dut_testpmd.quit()
> +        self.bind_nic_driver(self.dut_ports[:1], driver=self.vf_driver)
> 
>      def destroy_vm_env(self):
>          if not self.vm_env_done:
> @@ -539,6 +542,7 @@ class TestShutdownApi(TestCase):
>          self.dut_testpmd.quit()
>          time.sleep(3)
>          self.vm0_dut.kill_all()
> +        self.destroy_vm_env()
> 
>      def test_enable_disablejumbo(self):
>          """
> @@ -764,5 +768,6 @@ class TestShutdownApi(TestCase):
>          """
>          Run after each test suite.
>          """
> +        if self.vm_env_done:
> +            self.destroy_vm_env()
>          self.dut.kill_all()
> -        self.destroy_vm_env()
> --
> 1.8.3.1


      parent reply	other threads:[~2020-03-20  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18  8:28 Zeng Xiaoxiao
2020-03-18  8:31 ` Zeng, XiaoxiaoX
2020-03-20  7:56 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBEFA13@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xiaoxiaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).