test suite reviews and discussions
 help / color / Atom feed
* [dts]  [PATCH V1]tests/shutdown_api: fix can't create vf
@ 2020-03-18  8:28 Zeng Xiaoxiao
  2020-03-18  8:31 ` Zeng, XiaoxiaoX
  2020-03-20  7:56 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Zeng Xiaoxiao @ 2020-03-18  8:28 UTC (permalink / raw)
  To: dts; +Cc: Zeng Xiaoxiao

*.need insmod igb_uio when drivername is vfio-pci.
*.destroy vm after vf case finish.

Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_shutdown_api.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 11d451b..ffee0f2 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -260,6 +260,8 @@ class TestShutdownApi(TestCase):
             self.vf_assign_method = 'vfio-pci'
             self.dut.send_expect('modprobe vfio-pci', '#')
 
+        self.dut.send_expect('modprobe uio', '#')
+        self.dut.send_expect("insmod ./" + self.target + "/kmod/igb_uio.ko", "#", 60)
         self.bind_nic_driver(self.dut_ports[:1], driver="igb_uio")
         self.used_dut_port = self.dut_ports[0]
         tester_port = self.tester.get_local_port(self.used_dut_port)
@@ -296,6 +298,7 @@ class TestShutdownApi(TestCase):
 
         self.vm_env_done = True
         self.dut_testpmd.quit()
+        self.bind_nic_driver(self.dut_ports[:1], driver=self.vf_driver)
 
     def destroy_vm_env(self):
         if not self.vm_env_done:
@@ -539,6 +542,7 @@ class TestShutdownApi(TestCase):
         self.dut_testpmd.quit()
         time.sleep(3)
         self.vm0_dut.kill_all()
+        self.destroy_vm_env()
 
     def test_enable_disablejumbo(self):
         """
@@ -764,5 +768,6 @@ class TestShutdownApi(TestCase):
         """
         Run after each test suite.
         """
+        if self.vm_env_done:
+            self.destroy_vm_env()
         self.dut.kill_all()
-        self.destroy_vm_env()
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]tests/shutdown_api: fix can't create vf
  2020-03-18  8:28 [dts] [PATCH V1]tests/shutdown_api: fix can't create vf Zeng Xiaoxiao
@ 2020-03-18  8:31 ` Zeng, XiaoxiaoX
  2020-03-20  7:56 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Zeng, XiaoxiaoX @ 2020-03-18  8:31 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 2132 bytes --]


Tested_by:Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>


Best regards,
Zeng,xiaoxiao


> -----Original Message-----
> From: Zeng, XiaoxiaoX
> Sent: Wednesday, March 18, 2020 4:28 PM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1]tests/shutdown_api: fix can't create vf
> 
> *.need insmod igb_uio when drivername is vfio-pci.
> *.destroy vm after vf case finish.
> 
> Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 11d451b..ffee0f2 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -260,6 +260,8 @@ class TestShutdownApi(TestCase):
>              self.vf_assign_method = 'vfio-pci'
>              self.dut.send_expect('modprobe vfio-pci', '#')
> 
> +        self.dut.send_expect('modprobe uio', '#')
> +        self.dut.send_expect("insmod ./" + self.target +
> + "/kmod/igb_uio.ko", "#", 60)
>          self.bind_nic_driver(self.dut_ports[:1], driver="igb_uio")
>          self.used_dut_port = self.dut_ports[0]
>          tester_port = self.tester.get_local_port(self.used_dut_port)
> @@ -296,6 +298,7 @@ class TestShutdownApi(TestCase):
> 
>          self.vm_env_done = True
>          self.dut_testpmd.quit()
> +        self.bind_nic_driver(self.dut_ports[:1], driver=self.vf_driver)
> 
>      def destroy_vm_env(self):
>          if not self.vm_env_done:
> @@ -539,6 +542,7 @@ class TestShutdownApi(TestCase):
>          self.dut_testpmd.quit()
>          time.sleep(3)
>          self.vm0_dut.kill_all()
> +        self.destroy_vm_env()
> 
>      def test_enable_disablejumbo(self):
>          """
> @@ -764,5 +768,6 @@ class TestShutdownApi(TestCase):
>          """
>          Run after each test suite.
>          """
> +        if self.vm_env_done:
> +            self.destroy_vm_env()
>          self.dut.kill_all()
> -        self.destroy_vm_env()
> --
> 1.8.3.1


[-- Attachment #2: TestShutdownApi.log --]
[-- Type: application/octet-stream, Size: 1355126 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1]tests/shutdown_api: fix can't create vf
  2020-03-18  8:28 [dts] [PATCH V1]tests/shutdown_api: fix can't create vf Zeng Xiaoxiao
  2020-03-18  8:31 ` Zeng, XiaoxiaoX
@ 2020-03-20  7:56 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-03-20  7:56 UTC (permalink / raw)
  To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX

Hi xiaoxiao,

Framework has provide API " setup_modules_linux " to implement what you want, so you can call it directly:

self.dut.setup_modules_linux(self.target, 'igb_uio', '')

thanks
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zeng Xiaoxiao
> Sent: Wednesday, March 18, 2020 4:28 PM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1]tests/shutdown_api: fix can't create vf
> 
> *.need insmod igb_uio when drivername is vfio-pci.
> *.destroy vm after vf case finish.
> 
> Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_shutdown_api.py | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 11d451b..ffee0f2 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -260,6 +260,8 @@ class TestShutdownApi(TestCase):
>              self.vf_assign_method = 'vfio-pci'
>              self.dut.send_expect('modprobe vfio-pci', '#')
> 
> +        self.dut.send_expect('modprobe uio', '#')
> +        self.dut.send_expect("insmod ./" + self.target +
> + "/kmod/igb_uio.ko", "#", 60)
>          self.bind_nic_driver(self.dut_ports[:1], driver="igb_uio")
>          self.used_dut_port = self.dut_ports[0]
>          tester_port = self.tester.get_local_port(self.used_dut_port)
> @@ -296,6 +298,7 @@ class TestShutdownApi(TestCase):
> 
>          self.vm_env_done = True
>          self.dut_testpmd.quit()
> +        self.bind_nic_driver(self.dut_ports[:1], driver=self.vf_driver)
> 
>      def destroy_vm_env(self):
>          if not self.vm_env_done:
> @@ -539,6 +542,7 @@ class TestShutdownApi(TestCase):
>          self.dut_testpmd.quit()
>          time.sleep(3)
>          self.vm0_dut.kill_all()
> +        self.destroy_vm_env()
> 
>      def test_enable_disablejumbo(self):
>          """
> @@ -764,5 +768,6 @@ class TestShutdownApi(TestCase):
>          """
>          Run after each test suite.
>          """
> +        if self.vm_env_done:
> +            self.destroy_vm_env()
>          self.dut.kill_all()
> -        self.destroy_vm_env()
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18  8:28 [dts] [PATCH V1]tests/shutdown_api: fix can't create vf Zeng Xiaoxiao
2020-03-18  8:31 ` Zeng, XiaoxiaoX
2020-03-20  7:56 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox