test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH] tests/link_flowctrl: fix case/setting agreement
@ 2020-06-03 17:03 Lijuan Tu
  2020-06-11 12:21 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Lijuan Tu @ 2020-06-03 17:03 UTC (permalink / raw)
  To: dts; +Cc: Lijuan Tu

* fix case setting: test_perf_flowctrl_on_pause_fwd_off
* fix comments

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
---
 tests/TestSuite_link_flowctrl.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_link_flowctrl.py b/tests/TestSuite_link_flowctrl.py
index ee190d0..0349c11 100644
--- a/tests/TestSuite_link_flowctrl.py
+++ b/tests/TestSuite_link_flowctrl.py
@@ -367,7 +367,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_on_pause_fwd_on(self):
         """
-        Disable link flow control and PAUSE frame forwarding
+        Enable link flow control and PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
@@ -381,7 +381,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_on_pause_fwd_off(self):
         """
-        Disable link flow control and enable PAUSE frame forwarding
+        Enable link flow control and disable PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
@@ -399,7 +399,7 @@ class TestLinkFlowctrl(TestCase):
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
-                                            tx_flow_control='on',
+                                            tx_flow_control='off',
                                             pause_frame_fwd='off')
 
         self.logger.info("Packet loss: %.3f" % result)
@@ -409,7 +409,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_off_pause_fwd_on(self):
         """
-        Enable link flow control and disable PAUSE frame forwarding
+        Disable link flow control and enable PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='off',
@@ -437,7 +437,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_tx_on(self):
         """
-        Disable link flow control and PAUSE frame forwarding
+        Enable only tx link flow control
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='off',
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH] tests/link_flowctrl: fix case/setting agreement
  2020-06-03 17:03 [dts] [PATCH] tests/link_flowctrl: fix case/setting agreement Lijuan Tu
@ 2020-06-11 12:21 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-06-11 12:21 UTC (permalink / raw)
  To: dts

Applied, thanks

-----Original Message-----
From: Tu, Lijuan <lijuan.tu@intel.com> 
Sent: 2020^[$BG/^[(B6^[$B7n^[(B4^[$BF|^[(B 1:03
To: dts@dpdk.org
Cc: Tu, Lijuan <lijuan.tu@intel.com>
Subject: [PATCH] tests/link_flowctrl: fix case/setting agreement

* fix case setting: test_perf_flowctrl_on_pause_fwd_off
* fix comments

Signed-off-by: Lijuan Tu <lijuan.tu@intel.com>
---
 tests/TestSuite_link_flowctrl.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_link_flowctrl.py b/tests/TestSuite_link_flowctrl.py
index ee190d0..0349c11 100644
--- a/tests/TestSuite_link_flowctrl.py
+++ b/tests/TestSuite_link_flowctrl.py
@@ -367,7 +367,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_on_pause_fwd_on(self):
         """
-        Disable link flow control and PAUSE frame forwarding
+        Enable link flow control and PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
@@ -381,7 +381,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_on_pause_fwd_off(self):
         """
-        Disable link flow control and enable PAUSE frame forwarding
+        Enable link flow control and disable PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
@@ -399,7 +399,7 @@ class TestLinkFlowctrl(TestCase):
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='on',
-                                            tx_flow_control='on',
+                                            tx_flow_control='off',
                                             pause_frame_fwd='off')
 
         self.logger.info("Packet loss: %.3f" % result) @@ -409,7 +409,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_off_pause_fwd_on(self):
         """
-        Enable link flow control and disable PAUSE frame forwarding
+        Disable link flow control and enable PAUSE frame forwarding
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='off',
@@ -437,7 +437,7 @@ class TestLinkFlowctrl(TestCase):
 
     def test_perf_flowctrl_tx_on(self):
         """
-        Disable link flow control and PAUSE frame forwarding
+        Enable only tx link flow control
         """
 
         result = self.pause_frame_loss_test(rx_flow_control='off',
--
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 17:03 [dts] [PATCH] tests/link_flowctrl: fix case/setting agreement Lijuan Tu
2020-06-11 12:21 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox