test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility
@ 2020-06-05  2:21 yufengmx
  2020-06-05  2:21 ` [dts] [PATCH V1 1/2] tests/power_pbf: add Jansson installation description yufengmx
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: yufengmx @ 2020-06-05  2:21 UTC (permalink / raw)
  To: dts, lei.a.yao; +Cc: yufengmx

 
. add description to install the Jansson development package in test plan. 
 
. resolve high core selection compatibility for different pbf cpu topo. 
 
. add kill_all to deal with process quit exception. 

yufengmx (2):
  tests/power_pbf: add Jansson installation description
  tests/power_pbf: resolve high core selection compatibility

 test_plans/power_pbf_test_plan.rst | 10 ++++++----
 tests/TestSuite_power_pbf.py       | 10 ++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 1/2] tests/power_pbf: add Jansson installation description
  2020-06-05  2:21 [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility yufengmx
@ 2020-06-05  2:21 ` yufengmx
  2020-06-05  2:22   ` Yao, Lei A
  2020-06-05  2:21 ` [dts] [PATCH V1 2/2] tests/power_pbf: resolve high core selection compatibility yufengmx
  2020-06-11 12:26 ` [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: yufengmx @ 2020-06-05  2:21 UTC (permalink / raw)
  To: dts, lei.a.yao; +Cc: yufengmx


add description to install the Jansson development package in test plan.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 test_plans/power_pbf_test_plan.rst | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/test_plans/power_pbf_test_plan.rst b/test_plans/power_pbf_test_plan.rst
index 2ec3e56..a804624 100644
--- a/test_plans/power_pbf_test_plan.rst
+++ b/test_plans/power_pbf_test_plan.rst
@@ -30,9 +30,9 @@
    ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
    OF THE POSSIBILITY OF SUCH DAMAGE.
 
-=================================================
+===============
 Power PBF Tests
-=================================================
+===============
 PBF(Priority Base Frequency) is new power feature on some Intel CPU SKU. This feature can
 support some core in core list have garenteed higher base frequency DPDK start support this feature from 19.05
 
@@ -48,6 +48,8 @@ Check the SKU of Processor: 6230N, 6252N and 5218N can support this feature
 7. Modprobe msr module
 8. DON'T set intel_pstate to disable in grub
 9. Turn on the debug log for DPDK power lib, CONFIG_RTE_LIBRTE_POWER_DEBUG=y
+10. Install the Jansson development package, ``apt-get install libjansson-dev`` or ``dnf -y install jansson-devel``.
+
 
 Test Case1 : Check High Priority Core Can Be Recognized By Power Lib
 ====================================================================
@@ -120,7 +122,7 @@ Step 4: Send different command to power sample, then check the frequency::
     :"DISABLE_TURBO": Disable Turbo Boost for this core
 
 Test Case3 : Check "DISABLE_TURBO" Action When Core is In Turbo Status for High Priority Core
-==============================================================================================
+=============================================================================================
 Step 1. Create powermonitor fold for::
 
    Create monitor channel folder, /tmp/powermonitor, give permission 777
@@ -149,7 +151,7 @@ Step 4. Check the CPU frequency will be set to No turbo max frequency when turbo
 
 
 Test Case4:  Check Distributor Sample Use High Priority Core as Distribute Core
-======================================================================================
+===============================================================================
 Step 1. Get the Priority core list on DUT in test case 1::
 
     For example:
-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dts] [PATCH V1 2/2] tests/power_pbf: resolve high core selection compatibility
  2020-06-05  2:21 [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility yufengmx
  2020-06-05  2:21 ` [dts] [PATCH V1 1/2] tests/power_pbf: add Jansson installation description yufengmx
@ 2020-06-05  2:21 ` yufengmx
  2020-06-11 12:26 ` [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: yufengmx @ 2020-06-05  2:21 UTC (permalink / raw)
  To: dts, lei.a.yao; +Cc: yufengmx


resolve high core selection compatibility for different pbf cpu topo.
add kill_all to deal with process quit exception.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_power_pbf.py | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_power_pbf.py b/tests/TestSuite_power_pbf.py
index 8fcab51..eb5a16e 100644
--- a/tests/TestSuite_power_pbf.py
+++ b/tests/TestSuite_power_pbf.py
@@ -339,17 +339,15 @@ class TestPowerPbf(TestCase):
     def get_high_freq_cores_index(self, number=1):
         ''' get one random high frequency core index, ignore core 0 '''
         high_freq = max(self.base_freqs_info.keys())
-        cores_index = self.base_freqs_info[high_freq][1:number] \
-            if self.base_freqs_info[high_freq][0] == 0 else \
-            self.base_freqs_info[high_freq][:number]
+        cores_index = self.base_freqs_info[high_freq][-number:]
         return cores_index
 
     def get_high_freq_core_mask(self, number=1, min_cores=5):
         index_list = []
         # get high frequency core first
-        cores_index = self.get_high_freq_cores_index(number + 1)
+        cores_index = self.get_high_freq_cores_index(number)
         [index_list.append(core_index) for core_index in cores_index]
-        high_freq_cores = index_list[1:]
+        high_freq_cores = index_list[:]
         # get normal cores to make sure minimum cores are enough
         cores_index = self.get_normal_cores_index()
         for core_index in cores_index:
@@ -622,7 +620,7 @@ class TestPowerPbf(TestCase):
         """
         Run after each test case.
         """
-        pass
+        self.dut.kill_all()
 
     def tear_down_all(self):
         """
-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/power_pbf: add Jansson installation description
  2020-06-05  2:21 ` [dts] [PATCH V1 1/2] tests/power_pbf: add Jansson installation description yufengmx
@ 2020-06-05  2:22   ` Yao, Lei A
  0 siblings, 0 replies; 5+ messages in thread
From: Yao, Lei A @ 2020-06-05  2:22 UTC (permalink / raw)
  To: Mo, YufengX, dts



> -----Original Message-----
> From: Mo, YufengX <yufengx.mo@intel.com>
> Sent: Friday, June 5, 2020 10:22 AM
> To: dts@dpdk.org; Yao, Lei A <lei.a.yao@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 1/2] tests/power_pbf: add Jansson installation
> description
> 
> 
> add description to install the Jansson development package in test plan.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
Acked-by: Lei Yao<lei.a.yao@intel.com>
> ---
>  test_plans/power_pbf_test_plan.rst | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/test_plans/power_pbf_test_plan.rst
> b/test_plans/power_pbf_test_plan.rst
> index 2ec3e56..a804624 100644
> --- a/test_plans/power_pbf_test_plan.rst
> +++ b/test_plans/power_pbf_test_plan.rst
> @@ -30,9 +30,9 @@
>     ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
> ADVISED
>     OF THE POSSIBILITY OF SUCH DAMAGE.
> 
> -=================================================
> +===============
>  Power PBF Tests
> -=================================================
> +===============
>  PBF(Priority Base Frequency) is new power feature on some Intel CPU SKU.
> This feature can
>  support some core in core list have garenteed higher base frequency DPDK
> start support this feature from 19.05
> 
> @@ -48,6 +48,8 @@ Check the SKU of Processor: 6230N, 6252N and 5218N
> can support this feature
>  7. Modprobe msr module
>  8. DON'T set intel_pstate to disable in grub
>  9. Turn on the debug log for DPDK power lib,
> CONFIG_RTE_LIBRTE_POWER_DEBUG=y
> +10. Install the Jansson development package, ``apt-get install libjansson-
> dev`` or ``dnf -y install jansson-devel``.
> +
> 
>  Test Case1 : Check High Priority Core Can Be Recognized By Power Lib
> 
> ==========================================================
> ==========
> @@ -120,7 +122,7 @@ Step 4: Send different command to power sample,
> then check the frequency::
>      :"DISABLE_TURBO": Disable Turbo Boost for this core
> 
>  Test Case3 : Check "DISABLE_TURBO" Action When Core is In Turbo Status
> for High Priority Core
> -
> ==========================================================
> ====================================
> +=========================================================
> ====================================
>  Step 1. Create powermonitor fold for::
> 
>     Create monitor channel folder, /tmp/powermonitor, give permission 777
> @@ -149,7 +151,7 @@ Step 4. Check the CPU frequency will be set to No
> turbo max frequency when turbo
> 
> 
>  Test Case4:  Check Distributor Sample Use High Priority Core as Distribute
> Core
> -
> ==========================================================
> ============================
> +=========================================================
> ======================
>  Step 1. Get the Priority core list on DUT in test case 1::
> 
>      For example:
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility
  2020-06-05  2:21 [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility yufengmx
  2020-06-05  2:21 ` [dts] [PATCH V1 1/2] tests/power_pbf: add Jansson installation description yufengmx
  2020-06-05  2:21 ` [dts] [PATCH V1 2/2] tests/power_pbf: resolve high core selection compatibility yufengmx
@ 2020-06-11 12:26 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-06-11 12:26 UTC (permalink / raw)
  To: Mo, YufengX, dts, Yao, Lei A; +Cc: Mo, YufengX

Applied the series, thanks

-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of yufengmx
Sent: 2020^[$BG/^[(B6^[$B7n^[(B5^[$BF|^[(B 10:22
To: dts@dpdk.org; Yao, Lei A <lei.a.yao@intel.com>
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility

 
. add description to install the Jansson development package in test plan. 
 
. resolve high core selection compatibility for different pbf cpu topo. 
 
. add kill_all to deal with process quit exception. 

yufengmx (2):
  tests/power_pbf: add Jansson installation description
  tests/power_pbf: resolve high core selection compatibility

 test_plans/power_pbf_test_plan.rst | 10 ++++++----
 tests/TestSuite_power_pbf.py       | 10 ++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05  2:21 [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility yufengmx
2020-06-05  2:21 ` [dts] [PATCH V1 1/2] tests/power_pbf: add Jansson installation description yufengmx
2020-06-05  2:22   ` Yao, Lei A
2020-06-05  2:21 ` [dts] [PATCH V1 2/2] tests/power_pbf: resolve high core selection compatibility yufengmx
2020-06-11 12:26 ` [dts] [PATCH V1 0/2] tests/power_pbf: update test plan and fix compatibility Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox