test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1 0/5] tests: update scripts to meet CVL
@ 2020-06-11  6:59 Haiyang Zhao
  2020-06-11  6:59 ` [dts] [PATCH V1 1/5] tests/runtime_vf_queue_number_kernel: " Haiyang Zhao
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Haiyang Zhao @ 2020-06-11  6:59 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.CVL supports following suites, update the scripts.

Haiyang Zhao (5):
  tests/runtime_vf_queue_number_kernel: update scripts to meet CVL    
    *.add CVL support.
  tests/vf_rss: update scripts to meet CVL     *.add CVL support.
  tests/vf_jumboframe: update scripts to meet CVL     *.update scripts
    to meet CVL.
  tests/vf_vlan: update scripts to meet CVL     *.update scripts to meet
    CVL.
  tests/veb_switch: update scripts to meet CVL     *.update scripts to
    meet CVL.

 tests/TestSuite_runtime_vf_queue_number_kernel.py |  6 ++++--
 tests/TestSuite_veb_switch.py                     |  5 ++++-
 tests/TestSuite_vf_jumboframe.py                  |  2 +-
 tests/TestSuite_vf_rss.py                         |  7 ++++---
 tests/TestSuite_vf_vlan.py                        | 20 ++++++++++++++------
 5 files changed, 27 insertions(+), 13 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 1/5] tests/runtime_vf_queue_number_kernel: update scripts to meet CVL
  2020-06-11  6:59 [dts] [PATCH V1 0/5] tests: update scripts to meet CVL Haiyang Zhao
@ 2020-06-11  6:59 ` " Haiyang Zhao
  2020-06-11  6:59 ` [dts] [PATCH V1 2/5] tests/vf_rss: " Haiyang Zhao
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Haiyang Zhao @ 2020-06-11  6:59 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.add CVL support.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_runtime_vf_queue_number_kernel.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_runtime_vf_queue_number_kernel.py b/tests/TestSuite_runtime_vf_queue_number_kernel.py
index b7fd2ba..05db5a0 100644
--- a/tests/TestSuite_runtime_vf_queue_number_kernel.py
+++ b/tests/TestSuite_runtime_vf_queue_number_kernel.py
@@ -51,8 +51,10 @@ class TestRuntimeVfQueueNumberKernel(TestCase):
     max_queue = 16
 
     def set_up_all(self):
-        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_25g", "fortville_spirit_single", "fortpark_BASE-T", "fortpark_TLV", "carlsville"],
-                    "Only supported by Fortville")
+        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_25g", "fortville_spirit_single",
+                                 "fortpark_BASE-T", "fortpark_TLV", "carlsville", 'columbiaville_100g',
+                                 'columbiaville_25g'],
+                    "Only supported by Fortville and columbiaville")
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) > 1, "Insufficient ports")
         self.vm0 = None
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 2/5] tests/vf_rss: update scripts to meet CVL
  2020-06-11  6:59 [dts] [PATCH V1 0/5] tests: update scripts to meet CVL Haiyang Zhao
  2020-06-11  6:59 ` [dts] [PATCH V1 1/5] tests/runtime_vf_queue_number_kernel: " Haiyang Zhao
@ 2020-06-11  6:59 ` " Haiyang Zhao
  2020-06-11  6:59 ` [dts] [PATCH V1 3/5] tests/vf_jumboframe: " Haiyang Zhao
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Haiyang Zhao @ 2020-06-11  6:59 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.add CVL support.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_vf_rss.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_vf_rss.py b/tests/TestSuite_vf_rss.py
index 0bde402..35d4ea2 100644
--- a/tests/TestSuite_vf_rss.py
+++ b/tests/TestSuite_vf_rss.py
@@ -207,7 +207,7 @@ class TestVfRss(TestCase):
             if self.kdriver == "fm10k":
                 # compute the hash result of five tuple into the 7 LSBs value.
                 hash_index = int(tmp_reta_line["RSS hash"], 16) % 128
-            elif self.kdriver == 'i40e' or self.nic in ['sageville', 'sagepond']:
+            elif self.kdriver == 'i40e' or self.kdriver == 'ice' or self.nic in ['sageville', 'sagepond']:
                 # compute the hash result of five tuple into the 7 LSBs value.
                 hash_index = int(tmp_reta_line["RSS hash"], 16) % 64
             else:
@@ -234,7 +234,8 @@ class TestVfRss(TestCase):
 
         self.verify(
             self.nic in ["redrockcanyou", "atwood", "boulderrapid", "fortville_eagle", "fortville_spirit",
-                         "fortville_spirit_single", "fortville_25g", "sageville", "sagepond", "fortpark_TLV","fortpark_BASE-T", "carlsville"],
+                         "fortville_spirit_single", "fortville_25g", "sageville", "sagepond", "fortpark_TLV",
+                         "fortpark_BASE-T", "carlsville", "columbiaville_25g", "columbiaville_100g"],
             "NIC Unsupported: " + str(self.nic))
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Not enough ports available")
@@ -363,7 +364,7 @@ class TestVfRss(TestCase):
                         self.vm_dut_0.send_expect(
                             "port config 0 rss reta (%d,%d)" % (i, reta_entries[i]), "testpmd> ")
                     self.vm_dut_0.send_expect("port config all rss %s" % rss_type, "testpmd> ")
-                elif self.kdriver == 'i40e' or self.nic in ['sageville', 'sagepond']:
+                elif self.kdriver == 'i40e' or self.kdriver == 'ice' or self.nic in ['sageville', 'sagepond']:
                     if self.nic in ['sageville', 'sagepond'] and rss_type == 'sctp':
                         self.logger.info('sageville and sagepond do not support rsstype sctp')
                         continue
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 3/5] tests/vf_jumboframe: update scripts to meet CVL
  2020-06-11  6:59 [dts] [PATCH V1 0/5] tests: update scripts to meet CVL Haiyang Zhao
  2020-06-11  6:59 ` [dts] [PATCH V1 1/5] tests/runtime_vf_queue_number_kernel: " Haiyang Zhao
  2020-06-11  6:59 ` [dts] [PATCH V1 2/5] tests/vf_rss: " Haiyang Zhao
@ 2020-06-11  6:59 ` " Haiyang Zhao
  2020-06-11  6:59 ` [dts] [PATCH V1 4/5] tests/vf_vlan: " Haiyang Zhao
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Haiyang Zhao @ 2020-06-11  6:59 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

 *.update scripts to meet CVL.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index 519e7aa..fcdf1b1 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -190,7 +190,7 @@ class TestVfJumboFrame(TestCase):
         if received:
             self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error")
 
-            if self.kdriver == "ixgbe":
+            if self.kdriver == "ixgbe" or self.kdriver == 'ice':
                 self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
             else:
                 self.verify(rx_bytes == pktsize, "Rx packet size should be equal to packet size")
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 4/5] tests/vf_vlan: update scripts to meet CVL
  2020-06-11  6:59 [dts] [PATCH V1 0/5] tests: update scripts to meet CVL Haiyang Zhao
                   ` (2 preceding siblings ...)
  2020-06-11  6:59 ` [dts] [PATCH V1 3/5] tests/vf_jumboframe: " Haiyang Zhao
@ 2020-06-11  6:59 ` " Haiyang Zhao
  2020-06-11  6:59 ` [dts] [PATCH V1 5/5] tests/veb_switch: " Haiyang Zhao
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Haiyang Zhao @ 2020-06-11  6:59 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.update scripts to meet CVL.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_vf_vlan.py | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index 7f46aa6..7aec89c 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -36,7 +36,6 @@ class TestVfVlan(TestCase):
             self.vf_assign_method = 'vfio-pci'
             self.dut.send_expect('modprobe vfio-pci', '#')
 
-
     def set_up(self):
         self.setup_vm_env()
 
@@ -84,6 +83,8 @@ class TestVfVlan(TestCase):
             self.used_dut_port_0, 1, driver=driver)
         self.sriov_vfs_port_0 = self.dut.ports_info[
             self.used_dut_port_0]['vfs_port']
+        if self.kdriver == 'ice':
+            self.dut.send_expect("ip link set %s vf 0 spoofchk off" %(self.host_intf0), "# ")
         self.vf0_mac = "00:10:00:00:00:00"
         self.dut.send_expect("ip link set %s vf 0 mac %s" %
                              (self.host_intf0, self.vf0_mac), "# ")
@@ -231,12 +232,19 @@ class TestVfVlan(TestCase):
             "received" not in out, "Received pacekt with wrong vlan!!!")
 
         # remove vlan
-        self.dut.send_expect(
-            "ip link set %s vf 0 vlan 0" % self.host_intf0, "# ")
+        self.vm0_testpmd.execute_cmd("stop")
+        self.vm0_testpmd.execute_cmd("port stop all")
+        self.dut.send_expect("ip link set %s vf 0 vlan 0" % self.host_intf0, "# ")
+        out = self.dut.send_expect("ip link show %s" % self.host_intf0, "# ")
+        self.verify("vlan %d" % random_vlan not in out, "Failed to remove pvid on VF0")
 
         # send packet with vlan
+        self.vm0_testpmd.execute_cmd("port reset 0")
+        self.vm0_testpmd.execute_cmd("port start all")
+        self.vm0_testpmd.execute_cmd("start")
+
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
-        if self.kdriver == "i40e":
+        if self.kdriver == "i40e" or self.kdriver == 'ice':
             self.verify("received" in out, "Failed to received vlan packet!!!")
         else:
             self.verify(
@@ -288,7 +296,7 @@ class TestVfVlan(TestCase):
             # for fortville ,
             # if you want insert tx_vlan,
             # please enable rx_vlan at the same time
-            if self.kdriver == "i40e":
+            if self.kdriver == "i40e" or self.kdriver == 'ice':
                 self.vm0_testpmd.execute_cmd('vlan set filter on 0')
                 self.vm0_testpmd.execute_cmd('rx_vlan add %d 0' % tx_vlan)
             self.vm0_testpmd.execute_cmd('stop')
@@ -358,7 +366,7 @@ class TestVfVlan(TestCase):
 
         # send packet with vlan
         out = self.send_and_getout(vlan=random_vlan, pkt_type="VLAN_UDP")
-        if self.kdriver == "i40e":
+        if self.kdriver == "i40e" or self.kdriver == 'ice':
             self.verify(
                 "received 1 packets" in out, "Received mismatched vlan packet while vlan filter on")
         else:
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dts] [PATCH V1 5/5] tests/veb_switch: update scripts to meet CVL
  2020-06-11  6:59 [dts] [PATCH V1 0/5] tests: update scripts to meet CVL Haiyang Zhao
                   ` (3 preceding siblings ...)
  2020-06-11  6:59 ` [dts] [PATCH V1 4/5] tests/vf_vlan: " Haiyang Zhao
@ 2020-06-11  6:59 ` " Haiyang Zhao
  2020-06-11  7:17 ` [dts] [PATCH V1 0/5] tests: " Zhao, HaiyangX
  2020-06-19  4:50 ` Tu, Lijuan
  6 siblings, 0 replies; 8+ messages in thread
From: Haiyang Zhao @ 2020-06-11  6:59 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.update scripts to meet CVL.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 tests/TestSuite_veb_switch.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_veb_switch.py b/tests/TestSuite_veb_switch.py
index 0753646..b6b4034 100644
--- a/tests/TestSuite_veb_switch.py
+++ b/tests/TestSuite_veb_switch.py
@@ -157,7 +157,8 @@ class TestVEBSwitching(TestCase):
         Prerequisite steps for each test suite.
         """
         self.verify(self.nic in ["fortville_eagle", "fortville_spirit",
-                    "fortville_spirit_single", "fortville_25g", "carlsville"],
+                    "fortville_spirit_single", "fortville_25g", "carlsville",
+                                 'columbiaville_100g', 'columbiaville_25g'],
                     "NIC Unsupported: " + str(self.nic))
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
@@ -279,6 +280,8 @@ class TestVEBSwitching(TestCase):
 
         vf0_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
         vf1_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
+        if self.kdriver == 'ice':
+            vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
         self.verify(vf0_tx_stats[0] != 0, "no packet was sent by VF0")
         self.verify(vf0_tx_stats == vf1_rx_stats, "VF1 failed to receive packets from VF0")
     
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dts] [PATCH V1 0/5] tests: update scripts to meet CVL
  2020-06-11  6:59 [dts] [PATCH V1 0/5] tests: update scripts to meet CVL Haiyang Zhao
                   ` (4 preceding siblings ...)
  2020-06-11  6:59 ` [dts] [PATCH V1 5/5] tests/veb_switch: " Haiyang Zhao
@ 2020-06-11  7:17 ` " Zhao, HaiyangX
  2020-06-19  4:50 ` Tu, Lijuan
  6 siblings, 0 replies; 8+ messages in thread
From: Zhao, HaiyangX @ 2020-06-11  7:17 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

Tested-by: Zhao, HaiyangX <haiyangx.zhao@intel.com>

Best Regards,
Zhao haiyang

> -----Original Message-----
> From: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Sent: Thursday, June 11, 2020 15:00
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts][PATCH V1 0/5] tests: update scripts to meet CVL
> 
> *.CVL supports following suites, update the scripts.
> 
> Haiyang Zhao (5):
>   tests/runtime_vf_queue_number_kernel: update scripts to meet CVL
>     *.add CVL support.
>   tests/vf_rss: update scripts to meet CVL     *.add CVL support.
>   tests/vf_jumboframe: update scripts to meet CVL     *.update scripts
>     to meet CVL.
>   tests/vf_vlan: update scripts to meet CVL     *.update scripts to meet
>     CVL.
>   tests/veb_switch: update scripts to meet CVL     *.update scripts to
>     meet CVL.
> 
>  tests/TestSuite_runtime_vf_queue_number_kernel.py |  6 ++++--
>  tests/TestSuite_veb_switch.py                     |  5 ++++-
>  tests/TestSuite_vf_jumboframe.py                  |  2 +-
>  tests/TestSuite_vf_rss.py                         |  7 ++++---
>  tests/TestSuite_vf_vlan.py                        | 20 ++++++++++++++------
>  5 files changed, 27 insertions(+), 13 deletions(-)
> 
> --
> 1.8.3.1


[-- Attachment #2: TestVfVlan.log --]
[-- Type: application/octet-stream, Size: 157420 bytes --]

[-- Attachment #3: TestVfRss.log --]
[-- Type: application/octet-stream, Size: 1267312 bytes --]

[-- Attachment #4: TestVfJumboFrame.log --]
[-- Type: application/octet-stream, Size: 95891 bytes --]

[-- Attachment #5: TestVEBSwitching.log --]
[-- Type: application/octet-stream, Size: 30077 bytes --]

[-- Attachment #6: TestRuntimeVfQueueNumberKernel.log --]
[-- Type: application/octet-stream, Size: 725603 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dts] [PATCH V1 0/5] tests: update scripts to meet CVL
  2020-06-11  6:59 [dts] [PATCH V1 0/5] tests: update scripts to meet CVL Haiyang Zhao
                   ` (5 preceding siblings ...)
  2020-06-11  7:17 ` [dts] [PATCH V1 0/5] tests: " Zhao, HaiyangX
@ 2020-06-19  4:50 ` Tu, Lijuan
  6 siblings, 0 replies; 8+ messages in thread
From: Tu, Lijuan @ 2020-06-19  4:50 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Applied the series, thanks

-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of Haiyang Zhao
Sent: 2020^[$BG/^[(B6^[$B7n^[(B11^[$BF|^[(B 15:00
To: dts@dpdk.org
Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
Subject: [dts] [PATCH V1 0/5] tests: update scripts to meet CVL

*.CVL supports following suites, update the scripts.

Haiyang Zhao (5):
  tests/runtime_vf_queue_number_kernel: update scripts to meet CVL    
    *.add CVL support.
  tests/vf_rss: update scripts to meet CVL     *.add CVL support.
  tests/vf_jumboframe: update scripts to meet CVL     *.update scripts
    to meet CVL.
  tests/vf_vlan: update scripts to meet CVL     *.update scripts to meet
    CVL.
  tests/veb_switch: update scripts to meet CVL     *.update scripts to
    meet CVL.

 tests/TestSuite_runtime_vf_queue_number_kernel.py |  6 ++++--
 tests/TestSuite_veb_switch.py                     |  5 ++++-
 tests/TestSuite_vf_jumboframe.py                  |  2 +-
 tests/TestSuite_vf_rss.py                         |  7 ++++---
 tests/TestSuite_vf_vlan.py                        | 20 ++++++++++++++------
 5 files changed, 27 insertions(+), 13 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11  6:59 [dts] [PATCH V1 0/5] tests: update scripts to meet CVL Haiyang Zhao
2020-06-11  6:59 ` [dts] [PATCH V1 1/5] tests/runtime_vf_queue_number_kernel: " Haiyang Zhao
2020-06-11  6:59 ` [dts] [PATCH V1 2/5] tests/vf_rss: " Haiyang Zhao
2020-06-11  6:59 ` [dts] [PATCH V1 3/5] tests/vf_jumboframe: " Haiyang Zhao
2020-06-11  6:59 ` [dts] [PATCH V1 4/5] tests/vf_vlan: " Haiyang Zhao
2020-06-11  6:59 ` [dts] [PATCH V1 5/5] tests/veb_switch: " Haiyang Zhao
2020-06-11  7:17 ` [dts] [PATCH V1 0/5] tests: " Zhao, HaiyangX
2020-06-19  4:50 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox