test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] Fix VF driver problem
@ 2020-07-03  7:19 ChenBo
  2020-07-03  7:33 ` Chen, BoX C
  2020-07-20  6:57 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: ChenBo @ 2020-07-03  7:19 UTC (permalink / raw)
  To: dts; +Cc: ChenBo

After creating VF, VF needs to be bound to the default driver to generate the port name.

Signed-off-by: ChenBo <box.c.chen@intel.com>
---
 tests/TestSuite_cvl_dcf_switch_filter.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_cvl_dcf_switch_filter.py b/tests/TestSuite_cvl_dcf_switch_filter.py
index 5c39eaa..1a51d40 100644
--- a/tests/TestSuite_cvl_dcf_switch_filter.py
+++ b/tests/TestSuite_cvl_dcf_switch_filter.py
@@ -903,7 +903,8 @@ class SwitchFilterTest(TestCase):
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
         localPort = self.tester.get_local_port(self.dut_ports[0])
         self.__tx_iface = self.tester.get_interface(localPort)
-        self.dut.send_expect("ifconfig %s up" % self.__tx_iface, "# ")
+        self.tester.send_expect("ifconfig %s up" % self.__tx_iface, "# ")
+        self.dut.send_expect("ifconfig %s up" % self.dut_ports[0], "# ")
         self.pkt = Packet()
         self.testpmd_status = "close"
         self.suite_config = rfc.get_suite_config(self)
@@ -1586,6 +1587,7 @@ class SwitchFilterTest(TestCase):
         #sort the vf interfaces and pcis by pcis
         vfs = {}
         for vf_port in self.sriov_vfs_port:
+            vf_port.bind_driver()
             vfs[vf_port.pci] = vf_port.intf_name
         vfs_sort = sorted(vfs.items(), key=lambda item:item[0])
         vf_pci = [key for key,value in vfs_sort]
@@ -1808,7 +1810,7 @@ class SwitchFilterTest(TestCase):
         """
         if self.testpmd_status != "close":
             # destroy all flow rules on DCF
-            self.dut.send_expect("flow flush 0", "testpmd> ", 15)
+            self.dut.send_expect("flow flush 0", "testpmd> ", 120)
             self.dut.send_expect("clear port stats all", "testpmd> ", 15)
             self.dut.send_expect("quit", "#", 15)
         self.testpmd_status = "close"
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] Fix VF driver problem
  2020-07-03  7:19 [dts] [PATCH V1] Fix VF driver problem ChenBo
@ 2020-07-03  7:33 ` Chen, BoX C
  2020-07-20  6:57 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Chen, BoX C @ 2020-07-03  7:33 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 2321 bytes --]

Tested-by:  Chen, BoX C <BoX.C.Chen@intel.com>

Regards,
Chen Bo

> -----Original Message-----
> From: Chen, BoX C <box.c.chen@intel.com>
> Sent: July 3, 2020 15:20
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>
> Subject: [dts][PATCH V1] Fix VF driver problem
> 
> After creating VF, VF needs to be bound to the default driver to generate the
> port name.
> 
> Signed-off-by: ChenBo <box.c.chen@intel.com>
> ---
>  tests/TestSuite_cvl_dcf_switch_filter.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_cvl_dcf_switch_filter.py
> b/tests/TestSuite_cvl_dcf_switch_filter.py
> index 5c39eaa..1a51d40 100644
> --- a/tests/TestSuite_cvl_dcf_switch_filter.py
> +++ b/tests/TestSuite_cvl_dcf_switch_filter.py
> @@ -903,7 +903,8 @@ class SwitchFilterTest(TestCase):
>          self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
>          localPort = self.tester.get_local_port(self.dut_ports[0])
>          self.__tx_iface = self.tester.get_interface(localPort)
> -        self.dut.send_expect("ifconfig %s up" % self.__tx_iface, "# ")
> +        self.tester.send_expect("ifconfig %s up" % self.__tx_iface, "# ")
> +        self.dut.send_expect("ifconfig %s up" % self.dut_ports[0], "#
> + ")
>          self.pkt = Packet()
>          self.testpmd_status = "close"
>          self.suite_config = rfc.get_suite_config(self) @@ -1586,6 +1587,7 @@
> class SwitchFilterTest(TestCase):
>          #sort the vf interfaces and pcis by pcis
>          vfs = {}
>          for vf_port in self.sriov_vfs_port:
> +            vf_port.bind_driver()
>              vfs[vf_port.pci] = vf_port.intf_name
>          vfs_sort = sorted(vfs.items(), key=lambda item:item[0])
>          vf_pci = [key for key,value in vfs_sort] @@ -1808,7 +1810,7 @@ class
> SwitchFilterTest(TestCase):
>          """
>          if self.testpmd_status != "close":
>              # destroy all flow rules on DCF
> -            self.dut.send_expect("flow flush 0", "testpmd> ", 15)
> +            self.dut.send_expect("flow flush 0", "testpmd> ", 120)
>              self.dut.send_expect("clear port stats all", "testpmd> ", 15)
>              self.dut.send_expect("quit", "#", 15)
>          self.testpmd_status = "close"
> --
> 2.17.1


[-- Attachment #2: SwitchFilterTest.log --]
[-- Type: application/octet-stream, Size: 2954350 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] Fix VF driver problem
  2020-07-03  7:19 [dts] [PATCH V1] Fix VF driver problem ChenBo
  2020-07-03  7:33 ` Chen, BoX C
@ 2020-07-20  6:57 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-07-20  6:57 UTC (permalink / raw)
  To: Chen, BoX C, dts; +Cc: Chen, BoX C

Applied, thanks

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of ChenBo
> Sent: 2020^[$BG/^[(B7^[$B7n^[(B3^[$BF|^[(B 15:20
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>
> Subject: [dts] [PATCH V1] Fix VF driver problem
> 
> After creating VF, VF needs to be bound to the default driver to generate the
> port name.
> 
> Signed-off-by: ChenBo <box.c.chen@intel.com>
> ---
>  tests/TestSuite_cvl_dcf_switch_filter.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_cvl_dcf_switch_filter.py
> b/tests/TestSuite_cvl_dcf_switch_filter.py
> index 5c39eaa..1a51d40 100644
> --- a/tests/TestSuite_cvl_dcf_switch_filter.py
> +++ b/tests/TestSuite_cvl_dcf_switch_filter.py
> @@ -903,7 +903,8 @@ class SwitchFilterTest(TestCase):
>          self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
>          localPort = self.tester.get_local_port(self.dut_ports[0])
>          self.__tx_iface = self.tester.get_interface(localPort)
> -        self.dut.send_expect("ifconfig %s up" % self.__tx_iface, "# ")
> +        self.tester.send_expect("ifconfig %s up" % self.__tx_iface, "# ")
> +        self.dut.send_expect("ifconfig %s up" % self.dut_ports[0], "#
> + ")
>          self.pkt = Packet()
>          self.testpmd_status = "close"
>          self.suite_config = rfc.get_suite_config(self) @@ -1586,6 +1587,7 @@
> class SwitchFilterTest(TestCase):
>          #sort the vf interfaces and pcis by pcis
>          vfs = {}
>          for vf_port in self.sriov_vfs_port:
> +            vf_port.bind_driver()
>              vfs[vf_port.pci] = vf_port.intf_name
>          vfs_sort = sorted(vfs.items(), key=lambda item:item[0])
>          vf_pci = [key for key,value in vfs_sort] @@ -1808,7 +1810,7 @@ class
> SwitchFilterTest(TestCase):
>          """
>          if self.testpmd_status != "close":
>              # destroy all flow rules on DCF
> -            self.dut.send_expect("flow flush 0", "testpmd> ", 15)
> +            self.dut.send_expect("flow flush 0", "testpmd> ", 120)
>              self.dut.send_expect("clear port stats all", "testpmd> ", 15)
>              self.dut.send_expect("quit", "#", 15)
>          self.testpmd_status = "close"
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-03  7:19 [dts] [PATCH V1] Fix VF driver problem ChenBo
2020-07-03  7:33 ` Chen, BoX C
2020-07-20  6:57 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox