test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Mo, YufengX" <yufengx.mo@intel.com>,
	"Zhang, YanX A" <yanx.a.zhang@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen	before	connect to vm
Date: Thu, 26 Sep 2019 02:59:44 +0000	[thread overview]
Message-ID: <BE1E572D0441E34284F1F8B7AC28F1970BB0473B@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <B8B15C44A3F2C044966E545C7B7371153E84DA34@shsmsx102.ccr.corp.intel.com>

Hi, yufeng
Yan has verify this scenes, the dts and dut not on same server.
And i think all the session connect is from the server which run dts, so it can not use the self.host_session.

-----Original Message-----
From: Mo, YufengX 
Sent: Thursday, September 26, 2019 10:49 AM
To: Zhang, YanX A <yanx.a.zhang@intel.com>; dts@dpdk.org
Cc: Ma, LihongX <lihongx.ma@intel.com>
Subject: RE: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm

Hi,zhangyan

when dts doesn't run on dut, your fix will malfunction. 

In LibvirtKvm class, use self.host_session.send_expect to do action on the node, which run virtual machine using libvirt tool.

BRs
Yufen, Mo


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhang, YanX A
> Sent: Wednesday, September 25, 2019 3:18 PM
> To: Ma, LihongX <lihongx.ma@intel.com>; dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: Re: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm
> 
> Tested-by:  Zhang, YanX A <yanx.a.zhang@intel.com>
> 
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Wednesday, September 25, 2019 7:49 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] framework/qemu_libvirt: rm ssh keygen before connect to vm
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  framework/qemu_libvirt.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/framework/qemu_libvirt.py b/framework/qemu_libvirt.py index d2edd31..5b25dec 100644
> --- a/framework/qemu_libvirt.py
> +++ b/framework/qemu_libvirt.py
> @@ -817,6 +817,9 @@ class LibvirtKvm(VirtBase):
>          while count:
>              out = self.__control_session('ifconfig')
>              if "10.0.2" in out:
> +                pos = self.vm_ip.find(':')
> +                ssh_key = '[' + self.vm_ip[:pos] + ']' + self.vm_ip[pos:]
> +                os.system('ssh-keygen -R %s' % ssh_key)
>                  return True
>              time.sleep(6)
>              count -= 1
> --
> 2.7.4


  reply	other threads:[~2019-09-26  3:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 23:48 lihong
2019-09-25  7:17 ` Zhang, YanX A
2019-09-26  2:49   ` Mo, YufengX
2019-09-26  2:59     ` Ma, LihongX [this message]
2019-09-26  3:05       ` Mo, YufengX
2019-09-26  3:17         ` Ma, LihongX
2019-09-26  3:23           ` Mo, YufengX
2019-09-26  3:26             ` Ma, LihongX
2019-09-26  3:09 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1E572D0441E34284F1F8B7AC28F1970BB0473B@SHSMSX101.ccr.corp.intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    --cc=yanx.a.zhang@intel.com \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).