test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/external_memory:modify expected feedback
@ 2019-11-05 19:23 Xiaoxiao Zeng
  2019-11-06  1:15 ` Ma, LihongX
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaoxiao Zeng @ 2019-11-05 19:23 UTC (permalink / raw)
  To: dts; +Cc: Xiaoxiao Zeng

*.change expected testpmd> to link state change event.

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_external_memory.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_external_memory.py b/tests/TestSuite_external_memory.py
index 9a75427..bb6d51e 100644
--- a/tests/TestSuite_external_memory.py
+++ b/tests/TestSuite_external_memory.py
@@ -92,7 +92,7 @@ class TestExternalMemory(TestCase):
         self.insmod_modprobe(modename="igb_uio")
         cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmem -i"%(self.target,self.coremask)
 
-        self.dut.send_expect(cmd,"testpmd>",60)
+        self.dut.send_expect(cmd,"link state change event",60)
         self.verifier_result()
 
     def test_IGB_UIO_xmemhuage(self):
@@ -103,7 +103,7 @@ class TestExternalMemory(TestCase):
 
         cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmemhuge -i"%(self.target,self.coremask)
 
-        self.dut.send_expect(cmd,"testpmd>",60)
+        self.dut.send_expect(cmd,"link state change event",60)
         self.verifier_result()
 
     def test_VFIO_PCI_xmem(self):
@@ -113,7 +113,7 @@ class TestExternalMemory(TestCase):
         self.insmod_modprobe(modename="vfio-pci")
 
         cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmem -i"%(self.target,self.coremask)
-        self.dut.send_expect(cmd,"testpmd>",60)
+        self.dut.send_expect(cmd,"link state change event",60)
 
         self.verifier_result()
 
@@ -123,7 +123,7 @@ class TestExternalMemory(TestCase):
         """
         self.insmod_modprobe(modename="vfio-pci")
         cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmemhuge -i"%(self.target,self.coremask)
-        self.dut.send_expect(cmd,"testpmd>",60)
+        self.dut.send_expect(cmd,"link state change event",60)
 
         self.verifier_result()
 
-- 
2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/external_memory:modify expected feedback
  2019-11-05 19:23 [dts] [PATCH V1] tests/external_memory:modify expected feedback Xiaoxiao Zeng
@ 2019-11-06  1:15 ` Ma, LihongX
  0 siblings, 0 replies; 2+ messages in thread
From: Ma, LihongX @ 2019-11-06  1:15 UTC (permalink / raw)
  To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX

Hi, xiaoxiao
If you want wait the link status to up then start 'verifier_result', I think it better to use the unified interface ' wait_link_status_up' in framework/pmdout.py

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
Sent: Wednesday, November 6, 2019 3:23 AM
To: dts@dpdk.org
Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
Subject: [dts] [PATCH V1] tests/external_memory:modify expected feedback

*.change expected testpmd> to link state change event.

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_external_memory.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_external_memory.py b/tests/TestSuite_external_memory.py
index 9a75427..bb6d51e 100644
--- a/tests/TestSuite_external_memory.py
+++ b/tests/TestSuite_external_memory.py
@@ -92,7 +92,7 @@ class TestExternalMemory(TestCase):
         self.insmod_modprobe(modename="igb_uio")
         cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmem -i"%(self.target,self.coremask)
 
-        self.dut.send_expect(cmd,"testpmd>",60)
+        self.dut.send_expect(cmd,"link state change event",60)
         self.verifier_result()
 
     def test_IGB_UIO_xmemhuage(self):
@@ -103,7 +103,7 @@ class TestExternalMemory(TestCase):
 
         cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmemhuge -i"%(self.target,self.coremask)
 
-        self.dut.send_expect(cmd,"testpmd>",60)
+        self.dut.send_expect(cmd,"link state change event",60)
         self.verifier_result()
 
     def test_VFIO_PCI_xmem(self):
@@ -113,7 +113,7 @@ class TestExternalMemory(TestCase):
         self.insmod_modprobe(modename="vfio-pci")
 
         cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmem -i"%(self.target,self.coremask)
-        self.dut.send_expect(cmd,"testpmd>",60)
+        self.dut.send_expect(cmd,"link state change event",60)
 
         self.verifier_result()
 
@@ -123,7 +123,7 @@ class TestExternalMemory(TestCase):
         """
         self.insmod_modprobe(modename="vfio-pci")
         cmd = "./%s/app/testpmd -c %s -n 4 -- --mp-alloc=xmemhuge -i"%(self.target,self.coremask)
-        self.dut.send_expect(cmd,"testpmd>",60)
+        self.dut.send_expect(cmd,"link state change event",60)
 
         self.verifier_result()
 
-- 
2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 19:23 [dts] [PATCH V1] tests/external_memory:modify expected feedback Xiaoxiao Zeng
2019-11-06  1:15 ` Ma, LihongX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox