test suite reviews and discussions
 help / color / Atom feed
From: "Ma, LihongX" <lihongx.ma@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Wang, Yinan" <yinan.wang@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS
Date: Wed, 6 Nov 2019 01:54:08 +0000
Message-ID: <BE1E572D0441E34284F1F8B7AC28F1970BB263A3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <4DC48DF9BDA3E54A836D2D3C057DEC6F0BBA8220@SHSMSX103.ccr.corp.intel.com>

Yes, you are right, the second app should wait first complete.

-----Original Message-----
From: Zhu, ShuaiX 
Sent: Wednesday, November 6, 2019 9:34 AM
To: Ma, LihongX <lihongx.ma@intel.com>; dts@dpdk.org
Cc: Wang, Yinan <yinan.wang@intel.com>
Subject: RE: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS

Hi lihong,
    Time.sleep needs to be added after the first process starts, waiting for the second start. If placed after the second process, the second process cannot be started.

> -----Original Message-----
> From: Ma, LihongX
> Sent: Wednesday, November 6, 2019 9:12 AM
> To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX 
> <shuaix.zhu@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS
> 
> Hi, shuai
> I think you time.sleep(3) should add after the command '
> self.vhost_secondary.send_expect(final_cmd_secondary, " ", 120)'
> Because you only wait the first app but not wait the second app.
> And I think you can use ' Checking' or 'Port' instead of ' ' as a expected word.
> 
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Tuesday, November 5, 2019 2:22 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX 
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS
> 
> RSS is not support by virito device and will thus will return error 
> configure device with RSS enabled. Need to disable RSS when configuring virtio device.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vdev_primary_secondary.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/TestSuite_vdev_primary_secondary.py
> b/tests/TestSuite_vdev_primary_secondary.py
> index 8b7b899..102a9e0 100644
> --- a/tests/TestSuite_vdev_primary_secondary.py
> +++ b/tests/TestSuite_vdev_primary_secondary.py
> @@ -119,6 +119,7 @@ class TestVdevPrimarySecondary(TestCase):
>          final_cmd_first = example_cmd_auto % (self.mem_channels,
> self.queues)
>          final_cmd_secondary = example_cmd_secondary % 
> (self.mem_channels, self.queues)
>          self.vhost_first.send_expect(final_cmd_first, " ", 120)
> +        time.sleep(3)
>          self.vhost_secondary.send_expect(final_cmd_secondary, " ", 
> 120)
> 
> 
> @@ -126,6 +127,8 @@ class TestVdevPrimarySecondary(TestCase):
> 
> self.vm_dut.send_expect("cp 
> ./examples/multi_process/symmetric_mp/main.c
> .", "#")
>          self.vm_dut.send_expect(
>                  "sed -i '/.offloads = DEV_RX_OFFLOAD_CHECKSUM,/d' 
> ./examples/multi_process/symmetric_mp/m
> ain.c", "#")
> +        self.vm_dut.send_expect(
> +                "sed -i 's/.mq_mode        =
> ETH_MQ_RX_RSS,/.mq_mode        =
> ETH_MQ_RX_NONE,/g' ./examples/multi_process/symmetric_mp/main.c", "#")
>          out =
> self.vm_dut.build_dpdk_apps('./examples/multi_process/symmetric_mp')
>          self.verify("Error" not in out, "compilation symmetric_mp 
> error")
> 
> --
> 2.17.2


      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  6:21 zhu,shuai
2019-11-05  7:46 ` Wang, Yinan
2019-11-06  1:11 ` Ma, LihongX
2019-11-06  1:33   ` Zhu, ShuaiX
2019-11-06  1:54     ` Ma, LihongX [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE1E572D0441E34284F1F8B7AC28F1970BB263A3@SHSMSX101.ccr.corp.intel.com \
    --to=lihongx.ma@intel.com \
    --cc=dts@dpdk.org \
    --cc=shuaix.zhu@intel.com \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox