test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] tests/shutdown_api: add judgment range to suit CVL 100G
@ 2019-11-19 14:10 Xiaoxiao Zeng
  2019-11-20  5:19 ` Ma, LihongX
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaoxiao Zeng @ 2019-11-19 14:10 UTC (permalink / raw)
  To: dts; +Cc: Xiaoxiao Zeng

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_shutdown_api.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index 63fff84..eb20583 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -314,10 +314,9 @@ class TestShutdownApi(TestCase):
 
         self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
         self.dut.send_expect("set promisc all off", "testpmd>")
-
         out = self.tester.send_expect(
             "ethtool %s" % self.tester.get_interface(self.tester.get_local_port(self.ports[0])), "# ")
-        if 'fortville_spirit' == self.nic:
+        if 'fortville_spirit' == self.nic or 'columbiaville' in self.nic :
             result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
         else:
             result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"
-- 
2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1] tests/shutdown_api: add judgment range to suit CVL 100G
  2019-11-19 14:10 [dts] [PATCH V1] tests/shutdown_api: add judgment range to suit CVL 100G Xiaoxiao Zeng
@ 2019-11-20  5:19 ` Ma, LihongX
  0 siblings, 0 replies; 2+ messages in thread
From: Ma, LihongX @ 2019-11-20  5:19 UTC (permalink / raw)
  To: Zeng, XiaoxiaoX, dts; +Cc: Zeng, XiaoxiaoX

Hi, xiaoxiao
If you change only for cvl_100 G, the condition about 'columbiaville' in self.nic    is not right.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiaoxiao Zeng
Sent: Tuesday, November 19, 2019 10:10 PM
To: dts@dpdk.org
Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
Subject: [dts] [PATCH V1] tests/shutdown_api: add judgment range to suit CVL 100G

Signed-off-by: Xiaoxiao Zeng <xiaoxiaox.zeng@intel.com>
---
 tests/TestSuite_shutdown_api.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index 63fff84..eb20583 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -314,10 +314,9 @@ class TestShutdownApi(TestCase):
 
         self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
         self.dut.send_expect("set promisc all off", "testpmd>")
-
         out = self.tester.send_expect(
             "ethtool %s" % self.tester.get_interface(self.tester.get_local_port(self.ports[0])), "# ")
-        if 'fortville_spirit' == self.nic:
+        if 'fortville_spirit' == self.nic or 'columbiaville' in self.nic :
             result_scanner = r"([0-9]+)baseSR4/([A-Za-z]+)"
         else:
             result_scanner = r"([0-9]+)baseT/([A-Za-z]+)"
--
2.17.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 14:10 [dts] [PATCH V1] tests/shutdown_api: add judgment range to suit CVL 100G Xiaoxiao Zeng
2019-11-20  5:19 ` Ma, LihongX

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox