test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529
@ 2020-08-26 15:53 Owen Hilyard
  2020-08-27  7:35 ` Chen, BoX C
  2020-09-01  2:55 ` Ma, LihongX
  0 siblings, 2 replies; 12+ messages in thread
From: Owen Hilyard @ 2020-08-26 15:53 UTC (permalink / raw)
  To: dts; +Cc: xix.zhang, xuemingx.zhang, lihongx.ma, Owen Hilyard

added missing quote in template for scapy packets.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 tests/TestSuite_checksum_offload.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index c4a877d..b07ae16 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
         for l4 in l4_protos:
             for chksum in "", "chksum=0xf":
                 vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
-                    f"eth/IP({chksum})/{l4}()/(X'*50)",
+                    f"eth/IP({chksum})/{l4}()/('X'*50)",
                     "PKT_RX_IP_CKSUM_", f"{l4}",
                     should_pass=(chksum == ""))
                 if vf is not None:
-- 
2.25.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529
  2020-08-26 15:53 [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529 Owen Hilyard
@ 2020-08-27  7:35 ` Chen, BoX C
  2020-09-01  2:55 ` Ma, LihongX
  1 sibling, 0 replies; 12+ messages in thread
From: Chen, BoX C @ 2020-08-27  7:35 UTC (permalink / raw)
  To: Owen Hilyard, dts; +Cc: Zhang, XiX, Zhang, XuemingX, Ma, LihongX

Tested Failed by: xix.zhang@intel.com

There may be two more errors:
1.The Iface here is a function variable, not an Iface defined by scapy. I think you forgot to put quotation marks

@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
     def replay_pcap_file_on_tester(self, iface, packet_file_path):
         self.tester.send_expect("scapy", ">>>")
         self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
-        self.scapy_exec(f"sendp(packets, iface={iface})")
+        self.scapy_exec(f"sendp(packets, iface='{iface}')")
         self.tester.send_expect("quit()", "# ")
    
2.SyntaxError: invalid syntax(This format should not appear :UDP(chksum=chksum=0xf))
    File "/usr/lib/python3.6/code.py", line 64, in runsource
    code = self.compile(source, filename, symbol)
  File "/usr/lib/python3.6/codeop.py", line 168, in __call__
    return _maybe_compile(self.compiler, source, filename, symbol)
  File "/usr/lib/python3.6/codeop.py", line 99, in _maybe_compile
    raise err1
  File "/usr/lib/python3.6/codeop.py", line 87, in _maybe_compile
    code1 = compiler(source + "\n", filename, symbol)
  File "/usr/lib/python3.6/codeop.py", line 133, in __call__
    codeob = compile(source, filename, symbol, self.flags, 1)
  File "<console>", line 1
    sendp(eth/IP()/UDP(chksum=0xf)/VXLAN()/IP()/UDP(chksum=chksum=0xf)/('X'*50), iface=iface)

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Owen Hilyard
> Sent: August 26, 2020 23:53
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>; Zhang, XuemingX
> <xuemingx.zhang@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Owen
> Hilyard <ohilyard@iol.unh.edu>
> Subject: [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529
> 
> added missing quote in template for scapy packets.
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  tests/TestSuite_checksum_offload.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index c4a877d..b07ae16 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
>          for l4 in l4_protos:
>              for chksum in "", "chksum=0xf":
>                  vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
> -                    f"eth/IP({chksum})/{l4}()/(X'*50)",
> +                    f"eth/IP({chksum})/{l4}()/('X'*50)",
>                      "PKT_RX_IP_CKSUM_", f"{l4}",
>                      should_pass=(chksum == ""))
>                  if vf is not None:
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529
  2020-08-26 15:53 [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529 Owen Hilyard
  2020-08-27  7:35 ` Chen, BoX C
@ 2020-09-01  2:55 ` Ma, LihongX
  2020-09-04  7:13   ` [dts] [PATCH V1] tests/checksum_offload: " Owen Hilyard
  1 sibling, 1 reply; 12+ messages in thread
From: Ma, LihongX @ 2020-09-01  2:55 UTC (permalink / raw)
  To: Owen Hilyard, dts; +Cc: Zhang, XiX, Zhang, XuemingX

Hi, Owen
Can you add the patch version of the patch, and the subject of the patch format like below: 
[dts][PATCH V1]tests/checksum_offload: Bugfix for bug 529

Regards,
Ma,lihong

> -----Original Message-----
> From: Owen Hilyard <ohilyard@iol.unh.edu>
> Sent: Wednesday, August 26, 2020 11:53 PM
> To: dts@dpdk.org
> Cc: Zhang, XiX <xix.zhang@intel.com>; Zhang, XuemingX
> <xuemingx.zhang@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Owen
> Hilyard <ohilyard@iol.unh.edu>
> Subject: [PATCH] l4 hardware checksum: Bugfix for bug 529
> 
> added missing quote in template for scapy packets.
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  tests/TestSuite_checksum_offload.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-01  2:55 ` Ma, LihongX
@ 2020-09-04  7:13   ` " Owen Hilyard
  2020-09-09  5:32     ` Ma, LihongX
  0 siblings, 1 reply; 12+ messages in thread
From: Owen Hilyard @ 2020-09-04  7:13 UTC (permalink / raw)
  To: dts, lihongx.ma; +Cc: xix.zhang, xuemingx.zhang, ohilyard

added missing quote in template for scapy packets.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 tests/TestSuite_checksum_offload.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index c4a877d..ef7a9de 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
     def replay_pcap_file_on_tester(self, iface, packet_file_path):
         self.tester.send_expect("scapy", ">>>")
         self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
-        self.scapy_exec(f"sendp(packets, iface={iface})")
+        self.scapy_exec(f"sendp(packets, iface='{iface}')")
         self.tester.send_expect("quit()", "# ")
 
     def validate_packet_list_checksums(self, packets):
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
         for l4 in l4_protos:
             for chksum in "", "chksum=0xf":
                 vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
-                    f"eth/IP({chksum})/{l4}()/(X'*50)",
+                    f"eth/IP({chksum})/{l4}()/('X'*50)",
                     "PKT_RX_IP_CKSUM_", f"{l4}",
                     should_pass=(chksum == ""))
                 if vf is not None:
-- 
2.25.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-04  7:13   ` [dts] [PATCH V1] tests/checksum_offload: " Owen Hilyard
@ 2020-09-09  5:32     ` Ma, LihongX
  2020-09-09 21:08       ` Owen Hilyard
  0 siblings, 1 reply; 12+ messages in thread
From: Ma, LihongX @ 2020-09-09  5:32 UTC (permalink / raw)
  To: Owen Hilyard, dts; +Cc: Zhang, XiX, Zhang, XuemingX

Hi, owen
Can you send a tested-by of this patch base on self-test and the result is pass,
It is best to upload the test log at same time.

Regards,
Ma,lihong

> -----Original Message-----
> From: Owen Hilyard <ohilyard@iol.unh.edu>
> Sent: Friday, September 4, 2020 3:13 PM
> To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
> Cc: Zhang, XiX <xix.zhang@intel.com>; Zhang, XuemingX
> <xuemingx.zhang@intel.com>; ohilyard@iol.unh.edu
> Subject: [dts][PATCH V1] tests/checksum_offload: Bugfix for bug 529
> 
> added missing quote in template for scapy packets.
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  tests/TestSuite_checksum_offload.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index c4a877d..ef7a9de 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
>      def replay_pcap_file_on_tester(self, iface, packet_file_path):
>          self.tester.send_expect("scapy", ">>>")
>          self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
> -        self.scapy_exec(f"sendp(packets, iface={iface})")
> +        self.scapy_exec(f"sendp(packets, iface='{iface}')")
>          self.tester.send_expect("quit()", "# ")
> 
>      def validate_packet_list_checksums(self, packets):
> @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
>          for l4 in l4_protos:
>              for chksum in "", "chksum=0xf":
>                  vf =
> self.send_pkt_expect_good_bad_from_flag_catch_failure(
> -                    f"eth/IP({chksum})/{l4}()/(X'*50)",
> +                    f"eth/IP({chksum})/{l4}()/('X'*50)",
>                      "PKT_RX_IP_CKSUM_", f"{l4}",
>                      should_pass=(chksum == ""))
>                  if vf is not None:
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-09  5:32     ` Ma, LihongX
@ 2020-09-09 21:08       ` Owen Hilyard
  2020-09-09 21:14         ` Owen Hilyard
  0 siblings, 1 reply; 12+ messages in thread
From: Owen Hilyard @ 2020-09-09 21:08 UTC (permalink / raw)
  To: dts, lihongx.ma; +Cc: ohilyard, lylavoie

added missing quote in template for scapy packets.
rearraged closing down scapy and testpmd to avoid issues with other test
cases.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 tests/TestSuite_checksum_offload.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index c4a877d..f2e9878 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
     def replay_pcap_file_on_tester(self, iface, packet_file_path):
         self.tester.send_expect("scapy", ">>>")
         self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
-        self.scapy_exec(f"sendp(packets, iface={iface})")
+        self.scapy_exec(f"sendp(packets, iface='{iface}')")
         self.tester.send_expect("quit()", "# ")
 
     def validate_packet_list_checksums(self, packets):
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
         for l4 in l4_protos:
             for chksum in "", "chksum=0xf":
                 vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
-                    f"eth/IP({chksum})/{l4}()/(X'*50)",
+                    f"eth/IP({chksum})/{l4}()/('X'*50)",
                     "PKT_RX_IP_CKSUM_", f"{l4}",
                     should_pass=(chksum == ""))
                 if vf is not None:
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):
         #                             if vf is not None:
         #                                 verification_errors.append(vf)
 
-        # tunneled inner
+        self.tester.send_expect("quit", "#")
+        self.dut.send_expect("stop", "testpmd>")
 
         for err in verification_errors:
             self.logger.error(str(err))
         self.verify(len(verification_errors) == 0, "See previous output")
 
	-        self.tester.send_expect("quit", "#")
-        self.dut.send_expect("stop", "testpmd>")
 
     def test_hardware_checksum_check_l4_tx(self):
         self.checksum_enablehw(self.dut_ports[0])
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):
 
         error_messages = self.validate_packet_list_checksums(captured_packets)
 
+        self.tester.send_expect("quit", "#")
         self.dut.send_expect("stop", "testpmd>")
+
         if len(error_messages) != 0:
             for error_msg in error_messages:
                 self.logger.error(error_msg)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-09 21:08       ` Owen Hilyard
@ 2020-09-09 21:14         ` Owen Hilyard
  2020-09-09 21:16           ` Owen Hilyard
  2020-09-10  1:45           ` Ma, LihongX
  0 siblings, 2 replies; 12+ messages in thread
From: Owen Hilyard @ 2020-09-09 21:14 UTC (permalink / raw)
  To: dts, Ma, LihongX; +Cc: Lincoln Lavoie

[-- Attachment #1.1: Type: text/plain, Size: 3406 bytes --]

Hello Ma,lihong,

While I was re-testing the entire suite to get the test log file for you, I
found a few more issues that occur when running the entire test suite at
once. I've included fixes for these but apparently checkpatch doesn't like
something about the patch, so I'll resubmit. Sorry about that. I've
included the log file after stripping some of the output. Due to how the
test was constructed, I wasn't able to use the normal method to run scapy
and had to do it through send_expect, which means that all of the colorings
in the shell were logged. I've done my best to remove all of the lines with
color symbols in them since they aren't needed to understand the output.

Sorry about messing up the submission again,
Owen

On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu> wrote:

> added missing quote in template for scapy packets.
> rearraged closing down scapy and testpmd to avoid issues with other test
> cases.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  tests/TestSuite_checksum_offload.py | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index c4a877d..f2e9878 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
>      def replay_pcap_file_on_tester(self, iface, packet_file_path):
>          self.tester.send_expect("scapy", ">>>")
>          self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
> -        self.scapy_exec(f"sendp(packets, iface={iface})")
> +        self.scapy_exec(f"sendp(packets, iface='{iface}')")
>          self.tester.send_expect("quit()", "# ")
>
>      def validate_packet_list_checksums(self, packets):
> @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
>          for l4 in l4_protos:
>              for chksum in "", "chksum=0xf":
>                  vf =
> self.send_pkt_expect_good_bad_from_flag_catch_failure(
> -                    f"eth/IP({chksum})/{l4}()/(X'*50)",
> +                    f"eth/IP({chksum})/{l4}()/('X'*50)",
>                      "PKT_RX_IP_CKSUM_", f"{l4}",
>                      should_pass=(chksum == ""))
>                  if vf is not None:
> @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):
>          #                             if vf is not None:
>          #                                 verification_errors.append(vf)
>
> -        # tunneled inner
> +        self.tester.send_expect("quit", "#")
> +        self.dut.send_expect("stop", "testpmd>")
>
>          for err in verification_errors:
>              self.logger.error(str(err))
>          self.verify(len(verification_errors) == 0, "See previous output")
>
>         -        self.tester.send_expect("quit", "#")
> -        self.dut.send_expect("stop", "testpmd>")
>
>      def test_hardware_checksum_check_l4_tx(self):
>          self.checksum_enablehw(self.dut_ports[0])
> @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):
>
>          error_messages =
> self.validate_packet_list_checksums(captured_packets)
>
> +        self.tester.send_expect("quit", "#")
>          self.dut.send_expect("stop", "testpmd>")
> +
>          if len(error_messages) != 0:
>              for error_msg in error_messages:
>                  self.logger.error(error_msg)
> --
> 2.25.1
>
>

[-- Attachment #1.2: Type: text/html, Size: 4586 bytes --]

<div dir="ltr">Hello Ma,lihong,<div><br></div><div>While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I&#39;ve included fixes for these but apparently checkpatch doesn&#39;t like something about the patch, so I&#39;ll resubmit. Sorry about that. I&#39;ve included the log file after stripping some of the output. Due to how the test was constructed, I wasn&#39;t able to use the normal method to run scapy and had to do it through send_expect, which means that all of the colorings in the shell were logged. I&#39;ve done my best to remove all of the lines with color symbols in them since they aren&#39;t needed to understand the output. </div><div><br></div><div>Sorry about messing up the submission again,</div><div>Owen</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">added missing quote in template for scapy packets.<br>
rearraged closing down scapy and testpmd to avoid issues with other test<br>
cases.<br>
<br>
Signed-off-by: Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt;<br>
---<br>
 tests/TestSuite_checksum_offload.py | 11 ++++++-----<br>
 1 file changed, 6 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py<br>
index c4a877d..f2e9878 100644<br>
--- a/tests/TestSuite_checksum_offload.py<br>
+++ b/tests/TestSuite_checksum_offload.py<br>
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):<br>
     def replay_pcap_file_on_tester(self, iface, packet_file_path):<br>
         self.tester.send_expect(&quot;scapy&quot;, &quot;&gt;&gt;&gt;&quot;)<br>
         self.scapy_exec(f&quot;packets = rdpcap(&#39;{packet_file_path}&#39;)&quot;)<br>
-        self.scapy_exec(f&quot;sendp(packets, iface={iface})&quot;)<br>
+        self.scapy_exec(f&quot;sendp(packets, iface=&#39;{iface}&#39;)&quot;)<br>
         self.tester.send_expect(&quot;quit()&quot;, &quot;# &quot;)<br>
<br>
     def validate_packet_list_checksums(self, packets):<br>
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):<br>
         for l4 in l4_protos:<br>
             for chksum in &quot;&quot;, &quot;chksum=0xf&quot;:<br>
                 vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(<br>
-                    f&quot;eth/IP({chksum})/{l4}()/(X&#39;*50)&quot;,<br>
+                    f&quot;eth/IP({chksum})/{l4}()/(&#39;X&#39;*50)&quot;,<br>
                     &quot;PKT_RX_IP_CKSUM_&quot;, f&quot;{l4}&quot;,<br>
                     should_pass=(chksum == &quot;&quot;))<br>
                 if vf is not None:<br>
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):<br>
         #                             if vf is not None:<br>
         #                                 verification_errors.append(vf)<br>
<br>
-        # tunneled inner<br>
+        self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
+        self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
<br>
         for err in verification_errors:<br>
             self.logger.error(str(err))<br>
         self.verify(len(verification_errors) == 0, &quot;See previous output&quot;)<br>
<br>
        -        self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
-        self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
<br>
     def test_hardware_checksum_check_l4_tx(self):<br>
         self.checksum_enablehw(self.dut_ports[0])<br>
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):<br>
<br>
         error_messages = self.validate_packet_list_checksums(captured_packets)<br>
<br>
+        self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
         self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
+<br>
         if len(error_messages) != 0:<br>
             for error_msg in error_messages:<br>
                 self.logger.error(error_msg)<br>
-- <br>
2.25.1<br>
<br>
</blockquote></div>

[-- Attachment #2: TestChecksumOffload.log.cleaned --]
[-- Type: application/octet-stream, Size: 464232 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-09 21:14         ` Owen Hilyard
@ 2020-09-09 21:16           ` Owen Hilyard
  2020-09-15  8:27             ` Tu, Lijuan
  2020-09-10  1:45           ` Ma, LihongX
  1 sibling, 1 reply; 12+ messages in thread
From: Owen Hilyard @ 2020-09-09 21:16 UTC (permalink / raw)
  To: dts, lihongx.ma; +Cc: ohilyard, lylavoie

added missing quote in template for scapy packets.
rearraged closing down scapy and testpmd to avoid issues with other test
cases.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 tests/TestSuite_checksum_offload.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index c4a877d..f2e9878 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
     def replay_pcap_file_on_tester(self, iface, packet_file_path):
         self.tester.send_expect("scapy", ">>>")
         self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
-        self.scapy_exec(f"sendp(packets, iface={iface})")
+        self.scapy_exec(f"sendp(packets, iface='{iface}')")
         self.tester.send_expect("quit()", "# ")
 
     def validate_packet_list_checksums(self, packets):
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
         for l4 in l4_protos:
             for chksum in "", "chksum=0xf":
                 vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
-                    f"eth/IP({chksum})/{l4}()/(X'*50)",
+                    f"eth/IP({chksum})/{l4}()/('X'*50)",
                     "PKT_RX_IP_CKSUM_", f"{l4}",
                     should_pass=(chksum == ""))
                 if vf is not None:
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):
         #                             if vf is not None:
         #                                 verification_errors.append(vf)
 
-        # tunneled inner
+        self.tester.send_expect("quit", "#")
+        self.dut.send_expect("stop", "testpmd>")
 
         for err in verification_errors:
             self.logger.error(str(err))
         self.verify(len(verification_errors) == 0, "See previous output")
 
-        self.tester.send_expect("quit", "#")
-        self.dut.send_expect("stop", "testpmd>")
 
     def test_hardware_checksum_check_l4_tx(self):
         self.checksum_enablehw(self.dut_ports[0])
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):
 
         error_messages = self.validate_packet_list_checksums(captured_packets)
 
+        self.tester.send_expect("quit", "#")
         self.dut.send_expect("stop", "testpmd>")
+
         if len(error_messages) != 0:
             for error_msg in error_messages:
                 self.logger.error(error_msg)
-- 
2.25.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-09 21:14         ` Owen Hilyard
  2020-09-09 21:16           ` Owen Hilyard
@ 2020-09-10  1:45           ` Ma, LihongX
  2020-09-10  1:50             ` Ma, LihongX
  1 sibling, 1 reply; 12+ messages in thread
From: Ma, LihongX @ 2020-09-10  1:45 UTC (permalink / raw)
  To: Owen Hilyard, dts; +Cc: Lincoln Lavoie

[-- Attachment #1: Type: text/plain, Size: 3903 bytes --]

Thanks response of that, in the log file, I find the result of new cases test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx are failed,
Is it expected result of now or there is bug of it ?

Regards,
Ma,lihong

From: Owen Hilyard <ohilyard@iol.unh.edu>
Sent: Thursday, September 10, 2020 5:14 AM
To: dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
Cc: Lincoln Lavoie <lylavoie@iol.unh.edu>
Subject: Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529

Hello Ma,lihong,

While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I've included fixes for these but apparently checkpatch doesn't like something about the patch, so I'll resubmit. Sorry about that. I've included the log file after stripping some of the output. Due to how the test was constructed, I wasn't able to use the normal method to run scapy and had to do it through send_expect, which means that all of the colorings in the shell were logged. I've done my best to remove all of the lines with color symbols in them since they aren't needed to understand the output.

Sorry about messing up the submission again,
Owen

On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>> wrote:
added missing quote in template for scapy packets.
rearraged closing down scapy and testpmd to avoid issues with other test
cases.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>>
---
 tests/TestSuite_checksum_offload.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index c4a877d..f2e9878 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
     def replay_pcap_file_on_tester(self, iface, packet_file_path):
         self.tester.send_expect("scapy", ">>>")
         self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
-        self.scapy_exec(f"sendp(packets, iface={iface})")
+        self.scapy_exec(f"sendp(packets, iface='{iface}')")
         self.tester.send_expect("quit()", "# ")

     def validate_packet_list_checksums(self, packets):
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
         for l4 in l4_protos:
             for chksum in "", "chksum=0xf":
                 vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
-                    f"eth/IP({chksum})/{l4}()/(X'*50)",
+                    f"eth/IP({chksum})/{l4}()/('X'*50)",
                     "PKT_RX_IP_CKSUM_", f"{l4}",
                     should_pass=(chksum == ""))
                 if vf is not None:
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):
         #                             if vf is not None:
         #                                 verification_errors.append(vf)

-        # tunneled inner
+        self.tester.send_expect("quit", "#")
+        self.dut.send_expect("stop", "testpmd>")

         for err in verification_errors:
             self.logger.error(str(err))
         self.verify(len(verification_errors) == 0, "See previous output")

        -        self.tester.send_expect("quit", "#")
-        self.dut.send_expect("stop", "testpmd>")

     def test_hardware_checksum_check_l4_tx(self):
         self.checksum_enablehw(self.dut_ports[0])
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):

         error_messages = self.validate_packet_list_checksums(captured_packets)

+        self.tester.send_expect("quit", "#")
         self.dut.send_expect("stop", "testpmd>")
+
         if len(error_messages) != 0:
             for error_msg in error_messages:
                 self.logger.error(error_msg)
--
2.25.1

[-- Attachment #2: Type: text/html, Size: 8930 bytes --]

<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:SimSun;
	panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:"\@SimSun";
	panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
span.EmailStyle18
	{mso-style-type:personal-reply;
	font-family:"Calibri",sans-serif;
	color:#1F497D;
	font-weight:normal;
	font-style:normal;
	text-decoration:none none;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri",sans-serif;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Thanks response of that, in the log file, I find the result of new cases test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx are failed,
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Is it expected result of now or there is bug of it ?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Ma,lihong</span><span style="font-size:12.0pt;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Owen Hilyard &lt;ohilyard@iol.unh.edu&gt; <br>
<b>Sent:</b> Thursday, September 10, 2020 5:14 AM<br>
<b>To:</b> dts@dpdk.org; Ma, LihongX &lt;lihongx.ma@intel.com&gt;<br>
<b>Cc:</b> Lincoln Lavoie &lt;lylavoie@iol.unh.edu&gt;<br>
<b>Subject:</b> Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<div>
<p class="MsoNormal">Hello Ma,lihong,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
<div>
<p class="MsoNormal">While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I've included fixes for these but apparently checkpatch doesn't like something about
 the patch, so I'll resubmit. Sorry about that. I've included the log file after stripping some of the output. Due to how the test was constructed, I wasn't able to use the normal method to run scapy and had to do it through&nbsp;send_expect, which means that all
 of the colorings in the shell were logged. I've done my best to remove all of the lines with color symbols in them since they aren't needed to understand the output.&nbsp;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
<div>
<p class="MsoNormal">Sorry about messing up the submission again,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Owen<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<div>
<div>
<p class="MsoNormal">On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt; wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">added missing quote in template for scapy packets.<br>
rearraged closing down scapy and testpmd to avoid issues with other test<br>
cases.<br>
<br>
Signed-off-by: Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt;<br>
---<br>
&nbsp;tests/TestSuite_checksum_offload.py | 11 ++++++-----<br>
&nbsp;1 file changed, 6 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py<br>
index c4a877d..f2e9878 100644<br>
--- a/tests/TestSuite_checksum_offload.py<br>
+++ b/tests/TestSuite_checksum_offload.py<br>
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):<br>
&nbsp; &nbsp; &nbsp;def replay_pcap_file_on_tester(self, iface, packet_file_path):<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.tester.send_expect(&quot;scapy&quot;, &quot;&gt;&gt;&gt;&quot;)<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.scapy_exec(f&quot;packets = rdpcap('{packet_file_path}')&quot;)<br>
-&nbsp; &nbsp; &nbsp; &nbsp; self.scapy_exec(f&quot;sendp(packets, iface={iface})&quot;)<br>
+&nbsp; &nbsp; &nbsp; &nbsp; self.scapy_exec(f&quot;sendp(packets, iface='{iface}')&quot;)<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.tester.send_expect(&quot;quit()&quot;, &quot;# &quot;)<br>
<br>
&nbsp; &nbsp; &nbsp;def validate_packet_list_checksums(self, packets):<br>
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;for l4 in l4_protos:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;for chksum in &quot;&quot;, &quot;chksum=0xf&quot;:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(<br>
-&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; f&quot;eth/IP({chksum})/{l4}()/(X'*50)&quot;,<br>
+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; f&quot;eth/IP({chksum})/{l4}()/('X'*50)&quot;,<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&quot;PKT_RX_IP_CKSUM_&quot;, f&quot;{l4}&quot;,<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;should_pass=(chksum == &quot;&quot;))<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if vf is not None:<br>
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;#&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if vf is not None:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;#&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;verification_errors.append(vf)<br>
<br>
-&nbsp; &nbsp; &nbsp; &nbsp; # tunneled inner<br>
+&nbsp; &nbsp; &nbsp; &nbsp; self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
+&nbsp; &nbsp; &nbsp; &nbsp; self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;for err in verification_errors:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.logger.error(str(err))<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.verify(len(verification_errors) == 0, &quot;See previous output&quot;)<br>
<br>
&nbsp; &nbsp; &nbsp; &nbsp; -&nbsp; &nbsp; &nbsp; &nbsp; self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
-&nbsp; &nbsp; &nbsp; &nbsp; self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
<br>
&nbsp; &nbsp; &nbsp;def test_hardware_checksum_check_l4_tx(self):<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.checksum_enablehw(self.dut_ports[0])<br>
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):<br>
<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;error_messages = self.validate_packet_list_checksums(captured_packets)<br>
<br>
+&nbsp; &nbsp; &nbsp; &nbsp; self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
+<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if len(error_messages) != 0:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;for error_msg in error_messages:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.logger.error(error_msg)<br>
-- <br>
2.25.1<o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-10  1:45           ` Ma, LihongX
@ 2020-09-10  1:50             ` Ma, LihongX
  2020-09-11 18:33               ` Owen Hilyard
  0 siblings, 1 reply; 12+ messages in thread
From: Ma, LihongX @ 2020-09-10  1:50 UTC (permalink / raw)
  To: Owen Hilyard, dts; +Cc: Lincoln Lavoie

[-- Attachment #1: Type: text/plain, Size: 4431 bytes --]

BTW, it is better increase the version number when we submit a new version of the patch, it will easy to know the latest version of the patch. eg: V1 ,V2, V3 ….

Regards,
Ma,lihong

From: Ma, LihongX
Sent: Thursday, September 10, 2020 9:46 AM
To: Owen Hilyard <ohilyard@iol.unh.edu>; dts@dpdk.org
Cc: Lincoln Lavoie <lylavoie@iol.unh.edu>
Subject: RE: [PATCH V1] tests/checksum_offload: Bugfix for bug 529

Thanks response of that, in the log file, I find the result of new cases test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx are failed,
Is it expected result of now or there is bug of it ?

Regards,
Ma,lihong

From: Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>>
Sent: Thursday, September 10, 2020 5:14 AM
To: dts@dpdk.org<mailto:dts@dpdk.org>; Ma, LihongX <lihongx.ma@intel.com<mailto:lihongx.ma@intel.com>>
Cc: Lincoln Lavoie <lylavoie@iol.unh.edu<mailto:lylavoie@iol.unh.edu>>
Subject: Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529

Hello Ma,lihong,

While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I've included fixes for these but apparently checkpatch doesn't like something about the patch, so I'll resubmit. Sorry about that. I've included the log file after stripping some of the output. Due to how the test was constructed, I wasn't able to use the normal method to run scapy and had to do it through send_expect, which means that all of the colorings in the shell were logged. I've done my best to remove all of the lines with color symbols in them since they aren't needed to understand the output.

Sorry about messing up the submission again,
Owen

On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>> wrote:
added missing quote in template for scapy packets.
rearraged closing down scapy and testpmd to avoid issues with other test
cases.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu<mailto:ohilyard@iol.unh.edu>>
---
 tests/TestSuite_checksum_offload.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index c4a877d..f2e9878 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
     def replay_pcap_file_on_tester(self, iface, packet_file_path):
         self.tester.send_expect("scapy", ">>>")
         self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
-        self.scapy_exec(f"sendp(packets, iface={iface})")
+        self.scapy_exec(f"sendp(packets, iface='{iface}')")
         self.tester.send_expect("quit()", "# ")

     def validate_packet_list_checksums(self, packets):
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
         for l4 in l4_protos:
             for chksum in "", "chksum=0xf":
                 vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(
-                    f"eth/IP({chksum})/{l4}()/(X'*50)",
+                    f"eth/IP({chksum})/{l4}()/('X'*50)",
                     "PKT_RX_IP_CKSUM_", f"{l4}",
                     should_pass=(chksum == ""))
                 if vf is not None:
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):
         #                             if vf is not None:
         #                                 verification_errors.append(vf)

-        # tunneled inner
+        self.tester.send_expect("quit", "#")
+        self.dut.send_expect("stop", "testpmd>")

         for err in verification_errors:
             self.logger.error(str(err))
         self.verify(len(verification_errors) == 0, "See previous output")

        -        self.tester.send_expect("quit", "#")
-        self.dut.send_expect("stop", "testpmd>")

     def test_hardware_checksum_check_l4_tx(self):
         self.checksum_enablehw(self.dut_ports[0])
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):

         error_messages = self.validate_packet_list_checksums(captured_packets)

+        self.tester.send_expect("quit", "#")
         self.dut.send_expect("stop", "testpmd>")
+
         if len(error_messages) != 0:
             for error_msg in error_messages:
                 self.logger.error(error_msg)
--
2.25.1

[-- Attachment #2: Type: text/html, Size: 10338 bytes --]

<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:SimSun;
	panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:"\@SimSun";
	panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
span.EmailStyle20
	{mso-style-type:personal-reply;
	font-family:"Calibri",sans-serif;
	color:#1F497D;
	font-weight:normal;
	font-style:normal;
	text-decoration:none none;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">BTW, it is better increase the version number when we submit a new version of the patch, it will easy to know the latest version of the patch. eg: V1 ,V2, V3 ….<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Ma,lihong</span><span style="font-size:12.0pt;color:#1F497D"><o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Ma, LihongX <br>
<b>Sent:</b> Thursday, September 10, 2020 9:46 AM<br>
<b>To:</b> Owen Hilyard &lt;ohilyard@iol.unh.edu&gt;; dts@dpdk.org<br>
<b>Cc:</b> Lincoln Lavoie &lt;lylavoie@iol.unh.edu&gt;<br>
<b>Subject:</b> RE: [PATCH V1] tests/checksum_offload: Bugfix for bug 529<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Thanks response of that, in the log file, I find the result of new cases test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx are failed,
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Is it expected result of now or there is bug of it ?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D">Ma,lihong<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;color:#1F497D"><o:p>&nbsp;</o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu">ohilyard@iol.unh.edu</a>&gt;
<br>
<b>Sent:</b> Thursday, September 10, 2020 5:14 AM<br>
<b>To:</b> <a href="mailto:dts@dpdk.org">dts@dpdk.org</a>; Ma, LihongX &lt;<a href="mailto:lihongx.ma@intel.com">lihongx.ma@intel.com</a>&gt;<br>
<b>Cc:</b> Lincoln Lavoie &lt;<a href="mailto:lylavoie@iol.unh.edu">lylavoie@iol.unh.edu</a>&gt;<br>
<b>Subject:</b> Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<div>
<p class="MsoNormal">Hello Ma,lihong,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
<div>
<p class="MsoNormal">While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I've included fixes for these but apparently checkpatch doesn't like something about
 the patch, so I'll resubmit. Sorry about that. I've included the log file after stripping some of the output. Due to how the test was constructed, I wasn't able to use the normal method to run scapy and had to do it through&nbsp;send_expect, which means that all
 of the colorings in the shell were logged. I've done my best to remove all of the lines with color symbols in them since they aren't needed to understand the output.&nbsp;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
<div>
<p class="MsoNormal">Sorry about messing up the submission again,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Owen<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<div>
<div>
<p class="MsoNormal">On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt; wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">added missing quote in template for scapy packets.<br>
rearraged closing down scapy and testpmd to avoid issues with other test<br>
cases.<br>
<br>
Signed-off-by: Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt;<br>
---<br>
&nbsp;tests/TestSuite_checksum_offload.py | 11 ++++++-----<br>
&nbsp;1 file changed, 6 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py<br>
index c4a877d..f2e9878 100644<br>
--- a/tests/TestSuite_checksum_offload.py<br>
+++ b/tests/TestSuite_checksum_offload.py<br>
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):<br>
&nbsp; &nbsp; &nbsp;def replay_pcap_file_on_tester(self, iface, packet_file_path):<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.tester.send_expect(&quot;scapy&quot;, &quot;&gt;&gt;&gt;&quot;)<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.scapy_exec(f&quot;packets = rdpcap('{packet_file_path}')&quot;)<br>
-&nbsp; &nbsp; &nbsp; &nbsp; self.scapy_exec(f&quot;sendp(packets, iface={iface})&quot;)<br>
+&nbsp; &nbsp; &nbsp; &nbsp; self.scapy_exec(f&quot;sendp(packets, iface='{iface}')&quot;)<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.tester.send_expect(&quot;quit()&quot;, &quot;# &quot;)<br>
<br>
&nbsp; &nbsp; &nbsp;def validate_packet_list_checksums(self, packets):<br>
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;for l4 in l4_protos:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;for chksum in &quot;&quot;, &quot;chksum=0xf&quot;:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(<br>
-&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; f&quot;eth/IP({chksum})/{l4}()/(X'*50)&quot;,<br>
+&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; f&quot;eth/IP({chksum})/{l4}()/('X'*50)&quot;,<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&quot;PKT_RX_IP_CKSUM_&quot;, f&quot;{l4}&quot;,<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;should_pass=(chksum == &quot;&quot;))<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if vf is not None:<br>
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;#&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if vf is not None:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;#&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;verification_errors.append(vf)<br>
<br>
-&nbsp; &nbsp; &nbsp; &nbsp; # tunneled inner<br>
+&nbsp; &nbsp; &nbsp; &nbsp; self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
+&nbsp; &nbsp; &nbsp; &nbsp; self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;for err in verification_errors:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.logger.error(str(err))<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.verify(len(verification_errors) == 0, &quot;See previous output&quot;)<br>
<br>
&nbsp; &nbsp; &nbsp; &nbsp; -&nbsp; &nbsp; &nbsp; &nbsp; self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
-&nbsp; &nbsp; &nbsp; &nbsp; self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
<br>
&nbsp; &nbsp; &nbsp;def test_hardware_checksum_check_l4_tx(self):<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.checksum_enablehw(self.dut_ports[0])<br>
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):<br>
<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;error_messages = self.validate_packet_list_checksums(captured_packets)<br>
<br>
+&nbsp; &nbsp; &nbsp; &nbsp; self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
+<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;if len(error_messages) != 0:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;for error_msg in error_messages:<br>
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;self.logger.error(error_msg)<br>
-- <br>
2.25.1<o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-10  1:50             ` Ma, LihongX
@ 2020-09-11 18:33               ` Owen Hilyard
  0 siblings, 0 replies; 12+ messages in thread
From: Owen Hilyard @ 2020-09-11 18:33 UTC (permalink / raw)
  To: Ma, LihongX; +Cc: dts, Lincoln Lavoie

[-- Attachment #1: Type: text/plain, Size: 5092 bytes --]

With regards to the failed test cases, that is expected behavior for the
machine I was running it on. The NIC in the dev machine the IOL team is
using is running i40e and the support is P in the compatibility table, and
I'm fairly sure our NIC doesn't support inner checksum offloads but does
support outer checksum offloads. I'll try to remember to increment the
version number if I need more than 1 patch again.

Thanks,
Owen Hilyard

On Wed, Sep 9, 2020 at 9:51 PM Ma, LihongX <lihongx.ma@intel.com> wrote:

> BTW, it is better increase the version number when we submit a new version
> of the patch, it will easy to know the latest version of the patch. eg: V1
> ,V2, V3 ….
>
>
>
> Regards,
>
> Ma,lihong
>
>
>
> *From:* Ma, LihongX
> *Sent:* Thursday, September 10, 2020 9:46 AM
> *To:* Owen Hilyard <ohilyard@iol.unh.edu>; dts@dpdk.org
> *Cc:* Lincoln Lavoie <lylavoie@iol.unh.edu>
> *Subject:* RE: [PATCH V1] tests/checksum_offload: Bugfix for bug 529
>
>
>
> Thanks response of that, in the log file, I find the result of new cases
> test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx
> are failed,
>
> Is it expected result of now or there is bug of it ?
>
>
>
> Regards,
>
> Ma,lihong
>
>
>
> *From:* Owen Hilyard <ohilyard@iol.unh.edu>
> *Sent:* Thursday, September 10, 2020 5:14 AM
> *To:* dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
> *Cc:* Lincoln Lavoie <lylavoie@iol.unh.edu>
> *Subject:* Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529
>
>
>
> Hello Ma,lihong,
>
>
>
> While I was re-testing the entire suite to get the test log file for you,
> I found a few more issues that occur when running the entire test suite at
> once. I've included fixes for these but apparently checkpatch doesn't like
> something about the patch, so I'll resubmit. Sorry about that. I've
> included the log file after stripping some of the output. Due to how the
> test was constructed, I wasn't able to use the normal method to run scapy
> and had to do it through send_expect, which means that all of the colorings
> in the shell were logged. I've done my best to remove all of the lines with
> color symbols in them since they aren't needed to understand the output.
>
>
>
> Sorry about messing up the submission again,
>
> Owen
>
>
>
> On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard <ohilyard@iol.unh.edu> wrote:
>
> added missing quote in template for scapy packets.
> rearraged closing down scapy and testpmd to avoid issues with other test
> cases.
>
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> ---
>  tests/TestSuite_checksum_offload.py | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index c4a877d..f2e9878 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):
>      def replay_pcap_file_on_tester(self, iface, packet_file_path):
>          self.tester.send_expect("scapy", ">>>")
>          self.scapy_exec(f"packets = rdpcap('{packet_file_path}')")
> -        self.scapy_exec(f"sendp(packets, iface={iface})")
> +        self.scapy_exec(f"sendp(packets, iface='{iface}')")
>          self.tester.send_expect("quit()", "# ")
>
>      def validate_packet_list_checksums(self, packets):
> @@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):
>          for l4 in l4_protos:
>              for chksum in "", "chksum=0xf":
>                  vf =
> self.send_pkt_expect_good_bad_from_flag_catch_failure(
> -                    f"eth/IP({chksum})/{l4}()/(X'*50)",
> +                    f"eth/IP({chksum})/{l4}()/('X'*50)",
>                      "PKT_RX_IP_CKSUM_", f"{l4}",
>                      should_pass=(chksum == ""))
>                  if vf is not None:
> @@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):
>          #                             if vf is not None:
>          #                                 verification_errors.append(vf)
>
> -        # tunneled inner
> +        self.tester.send_expect("quit", "#")
> +        self.dut.send_expect("stop", "testpmd>")
>
>          for err in verification_errors:
>              self.logger.error(str(err))
>          self.verify(len(verification_errors) == 0, "See previous output")
>
>         -        self.tester.send_expect("quit", "#")
> -        self.dut.send_expect("stop", "testpmd>")
>
>      def test_hardware_checksum_check_l4_tx(self):
>          self.checksum_enablehw(self.dut_ports[0])
> @@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):
>
>          error_messages =
> self.validate_packet_list_checksums(captured_packets)
>
> +        self.tester.send_expect("quit", "#")
>          self.dut.send_expect("stop", "testpmd>")
> +
>          if len(error_messages) != 0:
>              for error_msg in error_messages:
>                  self.logger.error(error_msg)
> --
> 2.25.1
>
>

[-- Attachment #2: Type: text/html, Size: 9201 bytes --]

<div dir="ltr">With regards to the failed test cases, that is expected behavior for the machine I was running it on. The NIC in the dev machine the IOL team is using is running i40e and the support is P in the compatibility table, and I&#39;m fairly sure our NIC doesn&#39;t support inner checksum offloads but does support outer checksum offloads. I&#39;ll try to remember to increment the version number if I need more than 1 patch again. <br><br>Thanks,<div>Owen Hilyard</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Sep 9, 2020 at 9:51 PM Ma, LihongX &lt;<a href="mailto:lihongx.ma@intel.com">lihongx.ma@intel.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">





<div lang="EN-US">
<div class="gmail-m_-7292057732024032006WordSection1">
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)">BTW, it is better increase the version number when we submit a new version of the patch, it will easy to know the latest version of the patch. eg: V1 ,V2, V3 ….<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)">Regards,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)">Ma,lihong</span><span style="font-size:12pt;color:rgb(31,73,125)"><u></u><u></u></span></p>
</div>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0in 0in 0in 4pt">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> Ma, LihongX <br>
<b>Sent:</b> Thursday, September 10, 2020 9:46 AM<br>
<b>To:</b> Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt;; <a href="mailto:dts@dpdk.org" target="_blank">dts@dpdk.org</a><br>
<b>Cc:</b> Lincoln Lavoie &lt;<a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a>&gt;<br>
<b>Subject:</b> RE: [PATCH V1] tests/checksum_offload: Bugfix for bug 529<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)">Thanks response of that, in the log file, I find the result of new cases test_hardware_checksum_check_l4_rx and test_hardware_checksum_check_l4_tx are failed,
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)">Is it expected result of now or there is bug of it ?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)">Regards,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)">Ma,lihong<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:12pt;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0in 0in 0in 4pt">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(225,225,225);padding:3pt 0in 0in">
<p class="MsoNormal"><b>From:</b> Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt;
<br>
<b>Sent:</b> Thursday, September 10, 2020 5:14 AM<br>
<b>To:</b> <a href="mailto:dts@dpdk.org" target="_blank">dts@dpdk.org</a>; Ma, LihongX &lt;<a href="mailto:lihongx.ma@intel.com" target="_blank">lihongx.ma@intel.com</a>&gt;<br>
<b>Cc:</b> Lincoln Lavoie &lt;<a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a>&gt;<br>
<b>Subject:</b> Re: [PATCH V1] tests/checksum_offload: Bugfix for bug 529<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hello Ma,lihong,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">While I was re-testing the entire suite to get the test log file for you, I found a few more issues that occur when running the entire test suite at once. I&#39;ve included fixes for these but apparently checkpatch doesn&#39;t like something about
 the patch, so I&#39;ll resubmit. Sorry about that. I&#39;ve included the log file after stripping some of the output. Due to how the test was constructed, I wasn&#39;t able to use the normal method to run scapy and had to do it through send_expect, which means that all
 of the colorings in the shell were logged. I&#39;ve done my best to remove all of the lines with color symbols in them since they aren&#39;t needed to understand the output. <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Sorry about messing up the submission again,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Owen<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Sep 9, 2020 at 5:08 PM Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt; wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0in 0in 0in 6pt;margin:5pt 0in 5pt 4.8pt">
<p class="MsoNormal" style="margin-bottom:12pt">added missing quote in template for scapy packets.<br>
rearraged closing down scapy and testpmd to avoid issues with other test<br>
cases.<br>
<br>
Signed-off-by: Owen Hilyard &lt;<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>&gt;<br>
---<br>
 tests/TestSuite_checksum_offload.py | 11 ++++++-----<br>
 1 file changed, 6 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py<br>
index c4a877d..f2e9878 100644<br>
--- a/tests/TestSuite_checksum_offload.py<br>
+++ b/tests/TestSuite_checksum_offload.py<br>
@@ -374,7 +374,7 @@ class TestChecksumOffload(TestCase):<br>
     def replay_pcap_file_on_tester(self, iface, packet_file_path):<br>
         self.tester.send_expect(&quot;scapy&quot;, &quot;&gt;&gt;&gt;&quot;)<br>
         self.scapy_exec(f&quot;packets = rdpcap(&#39;{packet_file_path}&#39;)&quot;)<br>
-        self.scapy_exec(f&quot;sendp(packets, iface={iface})&quot;)<br>
+        self.scapy_exec(f&quot;sendp(packets, iface=&#39;{iface}&#39;)&quot;)<br>
         self.tester.send_expect(&quot;quit()&quot;, &quot;# &quot;)<br>
<br>
     def validate_packet_list_checksums(self, packets):<br>
@@ -703,7 +703,7 @@ class TestChecksumOffload(TestCase):<br>
         for l4 in l4_protos:<br>
             for chksum in &quot;&quot;, &quot;chksum=0xf&quot;:<br>
                 vf = self.send_pkt_expect_good_bad_from_flag_catch_failure(<br>
-                    f&quot;eth/IP({chksum})/{l4}()/(X&#39;*50)&quot;,<br>
+                    f&quot;eth/IP({chksum})/{l4}()/(&#39;X&#39;*50)&quot;,<br>
                     &quot;PKT_RX_IP_CKSUM_&quot;, f&quot;{l4}&quot;,<br>
                     should_pass=(chksum == &quot;&quot;))<br>
                 if vf is not None:<br>
@@ -846,14 +846,13 @@ class TestChecksumOffload(TestCase):<br>
         #                             if vf is not None:<br>
         #                                 verification_errors.append(vf)<br>
<br>
-        # tunneled inner<br>
+        self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
+        self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
<br>
         for err in verification_errors:<br>
             self.logger.error(str(err))<br>
         self.verify(len(verification_errors) == 0, &quot;See previous output&quot;)<br>
<br>
        -        self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
-        self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
<br>
     def test_hardware_checksum_check_l4_tx(self):<br>
         self.checksum_enablehw(self.dut_ports[0])<br>
@@ -887,7 +886,9 @@ class TestChecksumOffload(TestCase):<br>
<br>
         error_messages = self.validate_packet_list_checksums(captured_packets)<br>
<br>
+        self.tester.send_expect(&quot;quit&quot;, &quot;#&quot;)<br>
         self.dut.send_expect(&quot;stop&quot;, &quot;testpmd&gt;&quot;)<br>
+<br>
         if len(error_messages) != 0:<br>
             for error_msg in error_messages:<br>
                 self.logger.error(error_msg)<br>
-- <br>
2.25.1<u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</div>

</blockquote></div>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
  2020-09-09 21:16           ` Owen Hilyard
@ 2020-09-15  8:27             ` Tu, Lijuan
  0 siblings, 0 replies; 12+ messages in thread
From: Tu, Lijuan @ 2020-09-15  8:27 UTC (permalink / raw)
  To: Owen Hilyard, dts, Ma, LihongX; +Cc: lylavoie

> Subject: [dts] [PATCH V1] tests/checksum_offload: Bugfix for bug 529
> 
> added missing quote in template for scapy packets.
> rearraged closing down scapy and testpmd to avoid issues with other test cases.
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>

Applied

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, back to index

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26 15:53 [dts] [PATCH] l4 hardware checksum: Bugfix for bug 529 Owen Hilyard
2020-08-27  7:35 ` Chen, BoX C
2020-09-01  2:55 ` Ma, LihongX
2020-09-04  7:13   ` [dts] [PATCH V1] tests/checksum_offload: " Owen Hilyard
2020-09-09  5:32     ` Ma, LihongX
2020-09-09 21:08       ` Owen Hilyard
2020-09-09 21:14         ` Owen Hilyard
2020-09-09 21:16           ` Owen Hilyard
2020-09-15  8:27             ` Tu, Lijuan
2020-09-10  1:45           ` Ma, LihongX
2020-09-10  1:50             ` Ma, LihongX
2020-09-11 18:33               ` Owen Hilyard

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox