test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts][PATCH V1] tests/vf_vlan:modify code to adapt avx2 and avx512 on vlan offload
@ 2023-01-06 18:09 Zhimin Huang
  2023-01-09  3:28 ` Li, WeiyuanX
  2023-01-10  7:56 ` lijuan.tu
  0 siblings, 2 replies; 3+ messages in thread
From: Zhimin Huang @ 2023-01-06 18:09 UTC (permalink / raw)
  To: dts; +Cc: Zhimin Huang

add parameter "--enable-hw-vlan" in testpmd.
the dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35 fixed avx2 not support this parameter.
the avx2 behavior is not appropriate,it has gap between avx2 and avx512.
so we add parameter "enable-hw-vlan" in testpmd,there is no gap in avx2 and avx512 to test vlan strip.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/vf_vlan_test_plan.rst | 5 +++++
 tests/TestSuite_vf_vlan.py       | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/test_plans/vf_vlan_test_plan.rst b/test_plans/vf_vlan_test_plan.rst
index 24877c6c..8612bd84 100644
--- a/test_plans/vf_vlan_test_plan.rst
+++ b/test_plans/vf_vlan_test_plan.rst
@@ -186,6 +186,11 @@ Test case4: VF tagged vlan rx
 Test case5: VF Vlan strip test
 ==============================
 
+.. note::
+   according to dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35,if not add parameter "enable-hw-vlan", the vlan
+   offload should be disable.the avx2 behavior is not appropriate, the avx2 and avx512 shouldn't have gap on vlan
+   offload. so add parameter "--enable-hw-vlan" in testpmd to test vlan strip.
+
 1. Start testpmd with mac forward mode::
 
      testpmd> set fwd mac
diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index d5a29c04..14c675c7 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -423,7 +423,8 @@ class TestVfVlan(TestCase):
         self.vm0_dut_ports = self.vm_dut_0.get_ports("any")
 
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
-        self.launch_testpmd(dcf_flag=self.dcf_mode)
+        param = "--enable-hw-vlan" if not self.dcf_mode else ""
+        self.launch_testpmd(dcf_flag=self.dcf_mode, param=param)
         self.vm0_testpmd.execute_cmd("set fwd rxonly")
         self.vm0_testpmd.execute_cmd("set verbose 1")
         self.vm0_testpmd.execute_cmd("start")
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-10  7:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 18:09 [dts][PATCH V1] tests/vf_vlan:modify code to adapt avx2 and avx512 on vlan offload Zhimin Huang
2023-01-09  3:28 ` Li, WeiyuanX
2023-01-10  7:56 ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).