test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V4] tests/cbdma:fix multi_app_mode test case use the same prefix to start
@ 2021-02-04 10:29 Ling Wei
  2021-02-04 10:31 ` Ling, WeiX
  0 siblings, 1 reply; 3+ messages in thread
From: Ling Wei @ 2021-02-04 10:29 UTC (permalink / raw)
  To: dts; +Cc: Ling Wei

v1:
When start multi apps, if one as primary, another as secondary, we need use the same prefix to start.

v2:
Fix world spelling errors.

v3:
Fix world spelling errors and remove print logs code.

v4:
Add import os module.

Signed-off-by: Ling Wei <weix.ling@intel.com>
---
 tests/TestSuite_cbdma.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_cbdma.py b/tests/TestSuite_cbdma.py
index f95e2942..055eba0c 100755
--- a/tests/TestSuite_cbdma.py
+++ b/tests/TestSuite_cbdma.py
@@ -36,6 +36,7 @@ DPDK Test suite.
 import utils
 import re
 import time
+import os
 from test_case import TestCase
 from packet import Packet
 from pktgen import TRANSMIT_CONT
@@ -59,6 +60,7 @@ class TestCBDMA(TestCase):
         self.cbdma_proc = '--proc-type=primary'
         # default v_dev is None, case 1-6 use default None values, case7 use --vdev net_null_0
         self.v_dev = ''
+        self.prefix_subfix = 'dpdk' + '_' + str(os.getpid()) + '_' + time.strftime("%Y%m%d%H%M%S", time.localtime())
         out = self.dut.build_dpdk_apps('./examples/ioat')
         self.ioat_path = self.dut.apps_name['ioat']
         self.verify('Error' not in out, 'compilation ioat error')
@@ -382,11 +384,11 @@ class TestCBDMA(TestCase):
         self.get_core_list()
         self.pmdout = PmdOutput(self.dut)
         self.pmdout.start_testpmd(cores='', eal_param='--vdev net_null_0 --proc-type=primary',
-                                    ports=dev_info)
+                                 fixed_prefix=True, prefix=self.prefix_subfix,  ports=dev_info)
         self.pmdout.execute_cmd('port stop all')
         self.cbdma_proc = '--proc-type=secondary'
-        eal_params = self.dut.create_eal_parameters(cores=self.core_list,
-                                        ports=dev_info)
+        eal_params = self.dut.create_eal_parameters(cores=self.core_list, fixed_prefix=True,
+                                                   prefix=self.prefix_subfix ,ports=dev_info)
         self.launch_ioatfwd_app(eal_params)
         self.send_session.send_expect('^C','#')
         self.pmdout.execute_cmd('^C')
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V4] tests/cbdma:fix multi_app_mode test case use the same prefix to start
  2021-02-04 10:29 [dts] [PATCH V4] tests/cbdma:fix multi_app_mode test case use the same prefix to start Ling Wei
@ 2021-02-04 10:31 ` Ling, WeiX
  2021-02-05  2:25   ` Zhao, HaiyangX
  0 siblings, 1 reply; 3+ messages in thread
From: Ling, WeiX @ 2021-02-04 10:31 UTC (permalink / raw)
  To: Ling, WeiX, dts

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

Tested-by: Wei Ling <weix.ling@intel.com>

Regards,
Ling Wei

> -----Original Message-----
> From: Ling Wei <weix.ling@intel.com>
> Sent: Thursday, February 4, 2021 06:29 PM
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts][PATCH V4] tests/cbdma:fix multi_app_mode test case use the
> same prefix to start


[-- Attachment #2: TestCBDMA.log --]
[-- Type: application/octet-stream, Size: 152710 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V4] tests/cbdma:fix multi_app_mode test case use the same prefix to start
  2021-02-04 10:31 ` Ling, WeiX
@ 2021-02-05  2:25   ` Zhao, HaiyangX
  0 siblings, 0 replies; 3+ messages in thread
From: Zhao, HaiyangX @ 2021-02-05  2:25 UTC (permalink / raw)
  To: Ling, WeiX, Ling, WeiX, dts

Hi, Ling, Wei,
Zhou, Jun has up streamed the patch to fix this issue in framework/dut, 
So you do not have to fix it in suite.

Best Regards,
Zhao Haiyang

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Ling, WeiX
> Sent: Thursday, February 4, 2021 18:31
> To: Ling, WeiX <weix.ling@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH V4] tests/cbdma:fix multi_app_mode test case use
> the same prefix to start
> 
> Tested-by: Wei Ling <weix.ling@intel.com>
> 
> Regards,
> Ling Wei
> 
> > -----Original Message-----
> > From: Ling Wei <weix.ling@intel.com>
> > Sent: Thursday, February 4, 2021 06:29 PM
> > To: dts@dpdk.org
> > Cc: Ling, WeiX <weix.ling@intel.com>
> > Subject: [dts][PATCH V4] tests/cbdma:fix multi_app_mode test case use
> > the same prefix to start


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-05  2:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-04 10:29 [dts] [PATCH V4] tests/cbdma:fix multi_app_mode test case use the same prefix to start Ling Wei
2021-02-04 10:31 ` Ling, WeiX
2021-02-05  2:25   ` Zhao, HaiyangX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).