test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Fu, Qi" <qi.fu@intel.com>
To: "Xu, Ke1" <ke1.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WeiyuanX" <weiyuanx.li@intel.com>,
	"Tu, Lijuan" <lijuan.tu@intel.com>
Subject: RE: [DTS][PATCH V3 0/5] Improve checksum validate and tso packet counting.
Date: Tue, 3 Jan 2023 06:05:45 +0000	[thread overview]
Message-ID: <DM6PR11MB4611EDFF2983649CCDC0692EEAF49@DM6PR11MB4611.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221228051503.36747-1-ke1.xu@intel.com>

Acked-by: Fu, Qi <qi.fu@intel.com>

> -----Original Message-----
> From: Xu, Ke1 <ke1.xu@intel.com>
> Sent: Wednesday, December 28, 2022 1:15 PM
> To: dts@dpdk.org
> Cc: Fu, Qi <qi.fu@intel.com>; Li, WeiyuanX <weiyuanx.li@intel.com>; Tu,
> Lijuan <lijuan.tu@intel.com>; Xu, Ke1 <ke1.xu@intel.com>
> Subject: [DTS][PATCH V3 0/5] Improve checksum validate and tso packet
> counting.
> 
> This patch updates checksum_validate method and remove the tunnel one.
> 
> Use packet.show(dump) methods and packet reading to validate the
> packets in a faster, more common and more stable way. This allows
> packets other than the plain packets can be verified by method
> checksum_validate. This updated method replaces
> checksum_validate_tunnel  in checksum offload cases.
> 
> This patch also updates TSO packet checking. Replace the tcpdump
> implementation to a packet reading implementation.
> 
> Packet reading implementation is more common to use when to verify the
> received packet count and payload size. The tcpdump method is not  able
> to recognize some of the tunnel packets, leading to a wrong output  failing
> the validation. Newly added tcpdump_analyse_sniff method is
> implemented by sniff packet reading and analysing and can replace  the
> lagacy methods number_of_packets and number_of_bytes.
> 
> This patch also removes a redundant variable.
> 
> Ke Xu (5):
>   tests/vf_offload: Improve checksum_validate method.
>   tests/vf_offload: Remove redundant variable used.
>   tests/vf_offload: Use modified checksum_validate to replace
>     checksum_validate_tunnel.
>   tests/vf_offload: Improve tcpdump_analyse_sniff method
>   tests/vf_offload: Replace the tcpdump implementation to a packet
>     reading implementation.
> 
>  tests/TestSuite_vf_offload.py | 247 +++++++++-------------------------
>  1 file changed, 66 insertions(+), 181 deletions(-)
> 
> --
> 2.25.1


  parent reply	other threads:[~2023-01-03  6:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28  5:14 Ke Xu
2022-12-28  5:14 ` [DTS][PATCH V3 1/5] tests/vf_offload: Improve checksum_validate method Ke Xu
2022-12-28  5:15 ` [DTS][PATCH V3 2/5] tests/vf_offload: Remove redundant variable used Ke Xu
2022-12-28  5:15 ` [DTS][PATCH V3 3/5] tests/vf_offload: Use modified checksum_validate to replace checksum_validate_tunnel Ke Xu
2022-12-28  5:15 ` [DTS][PATCH V3 4/5] tests/vf_offload: Improve tcpdump_analyse_sniff method Ke Xu
2022-12-28  5:15 ` [DTS][PATCH V3 5/5] tests/vf_offload: Replace the tcpdump implementation to a packet reading implementation Ke Xu
2022-12-28  6:08   ` Li, WeiyuanX
2023-01-03  6:05 ` Fu, Qi [this message]
2023-01-04  1:08 ` [DTS][PATCH V3 0/5] Improve checksum validate and tso packet counting Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4611EDFF2983649CCDC0692EEAF49@DM6PR11MB4611.namprd11.prod.outlook.com \
    --to=qi.fu@intel.com \
    --cc=dts@dpdk.org \
    --cc=ke1.xu@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=weiyuanx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).