test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xie, WeiX" <weix.xie@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xie, WeiX" <weix.xie@intel.com>
Subject: Re: [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size
Date: Thu, 7 Jan 2021 05:16:49 +0000
Message-ID: <b93509be5f5741af8be9cd00943e6e7b@intel.com> (raw)
In-Reply-To: <20210106065233.5401-2-weix.xie@intel.com>

> DTS framework has switched i40evf to iavf, so align with it.
> After testing, found that:
> when send a packet which length is 1513 bytes.
> for iavf driver; the statistic from "show port stats 0" is: RX-bytes: 1513 for
> i40evf driver; the statistic from "show port stats 0" is: RX-bytes: 1517
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_vf_jumboframe.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_jumboframe.py
> b/tests/TestSuite_vf_jumboframe.py
> index 6da2c5e5..75480f1f 100644
> --- a/tests/TestSuite_vf_jumboframe.py
> +++ b/tests/TestSuite_vf_jumboframe.py
> @@ -219,10 +219,8 @@ class TestVfJumboFrame(TestCase):
>          if received:
>              self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert
> error")
> 
> -            if self.kdriver == "ixgbe" or self.kdriver == 'ice':
> +            if self.kdriver in ["ixgbe", "ice", "i40e"]:
>                  self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be
> packet size - 4")
> -            else:
> -                self.verify(rx_bytes == pktsize, "Rx packet size should be equal to
> packet size")

If not matched the if condition, miss verification, so there is a gap, thanks.

> 
>              if self.kdriver == "igb":
>                  self.verify(tx_bytes == pktsize, "Tx packet size should be packet
> size")
> --
> 2.17.1


  reply	other threads:[~2021-01-07  5:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
2021-01-07  5:16   ` Tu, Lijuan [this message]
2021-01-06  6:52 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes Xie wei
2021-01-06  6:58 ` [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie, WeiX
2021-01-06  7:30 ` Zhao, HaiyangX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b93509be5f5741af8be9cd00943e6e7b@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=weix.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git