test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it
@ 2021-01-06  6:52 Xie wei
  2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Xie wei @ 2021-01-06  6:52 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.

Xie wei (2):
  tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet
    size
  tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes

 tests/TestSuite_veb_switch.py    | 3 +--
 tests/TestSuite_vf_jumboframe.py | 4 +---
 2 files changed, 2 insertions(+), 5 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size
  2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
@ 2021-01-06  6:52 ` Xie wei
  2021-01-07  5:16   ` Tu, Lijuan
  2021-01-06  6:52 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes Xie wei
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Xie wei @ 2021-01-06  6:52 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.
After testing, found that:
when send a packet which length is 1513 bytes.
for iavf driver; the statistic from "show port stats 0" is: RX-bytes: 1513
for i40evf driver; the statistic from "show port stats 0" is: RX-bytes: 1517

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_vf_jumboframe.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/TestSuite_vf_jumboframe.py b/tests/TestSuite_vf_jumboframe.py
index 6da2c5e5..75480f1f 100644
--- a/tests/TestSuite_vf_jumboframe.py
+++ b/tests/TestSuite_vf_jumboframe.py
@@ -219,10 +219,8 @@ class TestVfJumboFrame(TestCase):
         if received:
             self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert error")
 
-            if self.kdriver == "ixgbe" or self.kdriver == 'ice':
+            if self.kdriver in ["ixgbe", "ice", "i40e"]:
                 self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be packet size - 4")
-            else:
-                self.verify(rx_bytes == pktsize, "Rx packet size should be equal to packet size")
 
             if self.kdriver == "igb":
                 self.verify(tx_bytes == pktsize, "Tx packet size should be packet size")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes
  2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
  2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
@ 2021-01-06  6:52 ` Xie wei
  2021-01-06  6:58 ` [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie, WeiX
  2021-01-06  7:30 ` Zhao, HaiyangX
  3 siblings, 0 replies; 6+ messages in thread
From: Xie wei @ 2021-01-06  6:52 UTC (permalink / raw)
  To: dts; +Cc: Xie wei

DTS framework has switched i40evf to iavf, so align with it.
After testing, found that:
when send a packet which length is 60 bytes.
for iavf driver; the statistic from "show port stats 0" is: RX-bytes:56,
but set verbose 1, we can see the packet length is 60.
for i40evf driver; the statistic from "show port stats 0" is: RX-bytes: 60

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_veb_switch.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/TestSuite_veb_switch.py b/tests/TestSuite_veb_switch.py
index 00dd76e7..915296ff 100644
--- a/tests/TestSuite_veb_switch.py
+++ b/tests/TestSuite_veb_switch.py
@@ -286,8 +286,7 @@ class TestVEBSwitching(TestCase):
 
         vf0_tx_stats = self.veb_get_pmd_stats("first", 0, "tx")
         vf1_rx_stats = self.veb_get_pmd_stats("second", 0, "rx")
-        if self.kdriver == 'ice':
-            vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
+        vf1_rx_stats[-1] = vf1_rx_stats[-1] + 4
         self.verify(vf0_tx_stats[0] != 0, "no packet was sent by VF0")
         self.verify(vf0_tx_stats == vf1_rx_stats, "VF1 failed to receive packets from VF0")
     
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it
  2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
  2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
  2021-01-06  6:52 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes Xie wei
@ 2021-01-06  6:58 ` Xie, WeiX
  2021-01-06  7:30 ` Zhao, HaiyangX
  3 siblings, 0 replies; 6+ messages in thread
From: Xie, WeiX @ 2021-01-06  6:58 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Wednesday, January 6, 2021 2:53 PM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts][PATCH V1 0/2] DTS framework has switched i40evf to iavf, so
> align with it

[-- Attachment #2: TestVEBSwitching.log --]
[-- Type: application/octet-stream, Size: 6637 bytes --]

06/01/2021 14:43:21                            dts: 
TEST SUITE : TestVEBSwitching
06/01/2021 14:43:21                            dts: NIC :        fortville_25g
06/01/2021 14:43:22             dut.10.240.183.247: 
06/01/2021 14:43:22                         tester: 
06/01/2021 14:43:25               TestVEBSwitching: Test Case test_VEB_switching_inter_vfs_mac_fwd Begin
06/01/2021 14:43:25             dut.10.240.183.247: 
06/01/2021 14:43:26                         tester: 
06/01/2021 14:43:26             dut.10.240.183.247: kill_all: called by dut and has no prefix list.
06/01/2021 14:43:32             dut.10.240.183.247: cat /sys/bus/pci/devices/0000\:83\:02.0/vendor
06/01/2021 14:43:32             dut.10.240.183.247: 0x8086
06/01/2021 14:43:32             dut.10.240.183.247: cat /sys/bus/pci/devices/0000\:83\:02.0/device
06/01/2021 14:43:32             dut.10.240.183.247: 0x154c
06/01/2021 14:43:32             dut.10.240.183.247: cat /sys/bus/pci/devices/0000\:83\:02.0/vendor
06/01/2021 14:43:32             dut.10.240.183.247: 0x8086
06/01/2021 14:43:32             dut.10.240.183.247: cat /sys/bus/pci/devices/0000\:83\:02.0/device
06/01/2021 14:43:32             dut.10.240.183.247: 0x154c
06/01/2021 14:43:32             dut.10.240.183.247: cat /sys/bus/pci/devices/0000\:83\:02.1/vendor
06/01/2021 14:43:32             dut.10.240.183.247: 0x8086
06/01/2021 14:43:32             dut.10.240.183.247: cat /sys/bus/pci/devices/0000\:83\:02.1/device
06/01/2021 14:43:32             dut.10.240.183.247: 0x154c
06/01/2021 14:43:32             dut.10.240.183.247: cat /sys/bus/pci/devices/0000\:83\:02.1/vendor
06/01/2021 14:43:33             dut.10.240.183.247: 0x8086
06/01/2021 14:43:33             dut.10.240.183.247: cat /sys/bus/pci/devices/0000\:83\:02.1/device
06/01/2021 14:43:33             dut.10.240.183.247: 0x154c
06/01/2021 14:43:33             dut.10.240.183.247: ip link set ens260f0 vf 0 mac 00:11:22:33:44:11
06/01/2021 14:43:33             dut.10.240.183.247: 
06/01/2021 14:43:33             dut.10.240.183.247: ip link set ens260f0 vf 1 mac 00:11:22:33:44:12
06/01/2021 14:43:33             dut.10.240.183.247: 
06/01/2021 14:43:36             dut.10.240.183.247: x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1,2 -n 4 -a 0000:83:02.0 --file-prefix=test1_20757_20210106144257   -- -i --eth-peer=0,00:11:22:33:44:12
06/01/2021 14:43:37             dut.10.240.183.247: EAL: Detected 72 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/test1_20757_20210106144257/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL:   using IOMMU type 1 (Type 1)
EAL: Probe PCI driver: net_iavf (8086:154c) device: 0000:83:02.0 (socket 1)
Interactive-mode selected
testpmd: create a new mbuf pool <mb_pool_0>: n=155456, size=2176, socket=0
testpmd: preferred mempool ops selected: ring_mp_mc
testpmd: create a new mbuf pool <mb_pool_1>: n=155456, size=2176, socket=1
testpmd: preferred mempool ops selected: ring_mp_mc

Warning! port-topology=paired and odd forward ports number, the last port will pair with itself.

Configuring Port 0 (socket 1)

Port 0: link state change event
iavf_init_rss(): RSS is enabled by PF by default
iavf_configure_queues(): RXDID[1] is not supported, request default RXDID[1] in Queue[0]

Port 0: link state change event

Port 0: link state change event
Port 0: 00:11:22:33:44:11
Checking link statuses...
Done
06/01/2021 14:43:47             dut.10.240.183.247: set fwd mac
06/01/2021 14:43:47             dut.10.240.183.247: 
Set mac packet forwarding mode
06/01/2021 14:43:47             dut.10.240.183.247: set promisc all off
06/01/2021 14:43:47             dut.10.240.183.247: 
06/01/2021 14:43:47             dut.10.240.183.247: start
06/01/2021 14:43:47             dut.10.240.183.247: 
mac packet forwarding - ports=1 - cores=1 - streams=1 - NUMA support enabled, MP allocation mode: native
Logical Core 2 (socket 0) forwards packets on 1 streams:
  RX P=0/Q=0 (socket 1) -> TX P=0/Q=0 (socket 1) peer=00:11:22:33:44:12

  mac packet forwarding packets/burst=32
  nb forwarding cores=1 - nb forwarding ports=1
  port 0: RX queue number: 1 Tx queue number: 1
    Rx offloads=0x0 Tx offloads=0x10000
    RX queue: 0
      RX desc=512 - RX free threshold=32
      RX threshold registers: pthresh=0 hthresh=0  wthresh=0
      RX Offloads=0x0
    TX queue: 0
      TX desc=512 - TX free threshold=32
      TX threshold registers: pthresh=0 hthresh=0  wthresh=0
      TX offloads=0x10000 - TX RS bit threshold=32
06/01/2021 14:44:03             dut.10.240.183.247: start
06/01/2021 14:44:03             dut.10.240.183.247: 
Packet forwarding already ed
06/01/2021 14:44:03             dut.10.240.183.247: stop
06/01/2021 14:44:03             dut.10.240.183.247: 
Telling cores to ...
Waiting for lcores to finish...

  ---------------------- Forward statistics for port 0  ----------------------
  RX-packets: 1              RX-dropped: 0             RX-total: 1
  TX-packets: 1              TX-dropped: 0             TX-total: 1
  ----------------------------------------------------------------------------

  +++++++++++++++ Accumulated forward statistics for all ports+++++++++++++++
  RX-packets: 1              RX-dropped: 0             RX-total: 1
  TX-packets: 1              TX-dropped: 0             TX-total: 1
  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Done.
06/01/2021 14:44:04             dut.10.240.183.247: show port stats 0
06/01/2021 14:44:04             dut.10.240.183.247: 

  ######################## NIC statistics for port 0  ########################
  RX-packets: 1          RX-missed: 0          RX-bytes:  60
  RX-errors: 0
  RX-nombuf:  0         
  TX-packets: 1          TX-errors: 0          TX-bytes:  60

  Throughput (since last show)
  Rx-pps:            0          Rx-bps:            0
  Tx-pps:            0          Tx-bps:            0
  ############################################################################
06/01/2021 14:44:04               TestVEBSwitching: Test Case test_VEB_switching_inter_vfs_mac_fwd Result PASSED:
06/01/2021 14:44:06             dut.10.240.183.247: quit
06/01/2021 14:44:07             dut.10.240.183.247: 

Stopping port 0...
Stopping ports...
Done

Shutting down port 0...
Closing ports...
Port 0 is closed
Done

Bye...
06/01/2021 14:44:12             dut.10.240.183.247: kill_all: called by dut and prefix list has value.
06/01/2021 14:44:13                            dts: 
TEST SUITE ENDED: TestVEBSwitching

[-- Attachment #3: TestVfJumboFrame.log --]
[-- Type: application/octet-stream, Size: 53736 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it
  2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
                   ` (2 preceding siblings ...)
  2021-01-06  6:58 ` [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie, WeiX
@ 2021-01-06  7:30 ` Zhao, HaiyangX
  3 siblings, 0 replies; 6+ messages in thread
From: Zhao, HaiyangX @ 2021-01-06  7:30 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

Acked-by: Haiyang Zhao <haiyangx.zhao@intel.com>

Best Regards,
Zhao Haiyang

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
> Sent: Wednesday, January 6, 2021 14:53
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so
> align with it


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size
  2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
@ 2021-01-07  5:16   ` Tu, Lijuan
  0 siblings, 0 replies; 6+ messages in thread
From: Tu, Lijuan @ 2021-01-07  5:16 UTC (permalink / raw)
  To: Xie, WeiX, dts; +Cc: Xie, WeiX

> DTS framework has switched i40evf to iavf, so align with it.
> After testing, found that:
> when send a packet which length is 1513 bytes.
> for iavf driver; the statistic from "show port stats 0" is: RX-bytes: 1513 for
> i40evf driver; the statistic from "show port stats 0" is: RX-bytes: 1517
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_vf_jumboframe.py | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_vf_jumboframe.py
> b/tests/TestSuite_vf_jumboframe.py
> index 6da2c5e5..75480f1f 100644
> --- a/tests/TestSuite_vf_jumboframe.py
> +++ b/tests/TestSuite_vf_jumboframe.py
> @@ -219,10 +219,8 @@ class TestVfJumboFrame(TestCase):
>          if received:
>              self.verify((rx_pkts == 1) and (tx_pkts == 1), "Packet forward assert
> error")
> 
> -            if self.kdriver == "ixgbe" or self.kdriver == 'ice':
> +            if self.kdriver in ["ixgbe", "ice", "i40e"]:
>                  self.verify((rx_bytes + 4) == pktsize, "Rx packet size should be
> packet size - 4")
> -            else:
> -                self.verify(rx_bytes == pktsize, "Rx packet size should be equal to
> packet size")

If not matched the if condition, miss verification, so there is a gap, thanks.

> 
>              if self.kdriver == "igb":
>                  self.verify(tx_bytes == pktsize, "Tx packet size should be packet
> size")
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-07  5:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-06  6:52 [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie wei
2021-01-06  6:52 ` [dts] [PATCH V1 1/2] tests/TestSuite_vf_jumboframe:Rx packet size should be equal to packet size Xie wei
2021-01-07  5:16   ` Tu, Lijuan
2021-01-06  6:52 ` [dts] [PATCH V1 2/2] tests/TestSuite_veb_switch:vf1 RX-bytes need add four bytes Xie wei
2021-01-06  6:58 ` [dts] [PATCH V1 0/2] DTS framework has switched i40evf to iavf, so align with it Xie, WeiX
2021-01-06  7:30 ` Zhao, HaiyangX

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).